emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Do not drop const qualifier for Basename

Browse Source 
The private Basename() implementation does not modify its argument, so
a cast to a non-const char pointer is not necessary.

newgrp.c:790:39: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
  790 |         progbase = (char *) Basename ((char *) prog);
      |                                       ^
newgrp.c:790:20: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
  790 |         progbase = (char *) Basename ((char *) prog);
      |                    ^

shell.c:48:70: warning: cast discards ‘const’ qualifier from pointer target type [-Wcast-qual]
   48 |                 (void) snprintf (arg0, sizeof arg0, "-%s", Basename ((char *) file));
      |                                                                      ^
This commit is contained in:
Christian Göttsche 2022-01-03 12:17:22 +01:00
parent 45bba0e190
commit 946eb84182
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libmisc/shell.c
View File

@ -45,7 +45,7 @@ int shell (const char *file, /*@null@*/const char *arg, char *const envp[])
* don't want to tell us what it is themselves. * don't want to tell us what it is themselves.
*/ */
if (arg == (char *) 0) { if (arg == (char *) 0) {
(void) snprintf (arg0, sizeof arg0, "-%s", Basename ((char *) file)); (void) snprintf (arg0, sizeof arg0, "-%s", Basename (file));
arg0[sizeof arg0 - 1] = '\0'; arg0[sizeof arg0 - 1] = '\0';
arg = arg0; arg = arg0;
} }

4
src/newgrp.c
View File

@ -379,7 +379,7 @@ int main (int argc, char **argv)
int err = 0; int err = 0;
gid_t gid; gid_t gid;
char *cp; char *cp;
char *progbase; const char *progbase;
const char *name, *prog; const char *name, *prog;
char *group = NULL; char *group = NULL;
char *command = NULL; char *command = NULL;
@ -787,7 +787,7 @@ int main (int argc, char **argv)
* Now I try to find the basename of the login shell. This will * Now I try to find the basename of the login shell. This will
* become argv[0] of the spawned command. * become argv[0] of the spawned command.
*/ */
progbase = (char *) Basename ((char *) prog); progbase = Basename (prog);
/* /*
* Switch back to her home directory if i am doing login * Switch back to her home directory if i am doing login