emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

libmisc: add check fopen return value in read_random_bytes()

Browse Source 
Returns null when fopen fails. Then, using fread with a null pointer will cause a segfault.

Signed-off-by: Yan Zhu <zhuyan34@huawei.com>
This commit is contained in:
juyin 2022-03-30 19:21:32 +08:00 committed by Serge Hallyn
parent e9bf727253
commit a43d0b95c4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libmisc/salt.c
View File

@ -175,6 +175,9 @@ static long read_random_bytes (void)
#else #else
FILE *f = fopen ("/dev/urandom", "r"); FILE *f = fopen ("/dev/urandom", "r");
if (NULL == f) {
goto fail;
}
if (fread (&randval, sizeof (randval), 1, f) != 1) { if (fread (&randval, sizeof (randval), 1, f) != 1) {
fclose(f); fclose(f);