emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Fix change_field() buffer underrun

Browse Source 
* lib/fields.c (change_field): Don't point
before array start; that has undefined behavior.

Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Reviewed-by: Iker Pedrosa <ipedrosa@redhat.com>
This commit is contained in:
Paul Eggert 2023-03-11 13:43:36 -08:00 committed by Iker Pedrosa
parent 690ca8c238
commit a926a26f0c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/fields.c
View File

@ -91,8 +91,9 @@ void change_field (char *buf, size_t maxsize, const char *prompt)
* entering a space. --marekm * entering a space. --marekm
*/ */
while (--cp >= newf && isspace (*cp)); while (newf < cp && isspace (cp[-1])) {
cp++; cp--;
}
*cp = '\0'; *cp = '\0';
cp = newf; cp = newf;