emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* lib/commonio.c: Ignore teh return values of fclose() and

Browse Source 
unlink() in case of failure of fopen_set_perms() or
	create_backup().
	* lib/commonio.c: Should the backup file be unlink'ed in case of
	failure of create_backup()?
This commit is contained in:
nekral-guest 2009-04-30 21:53:54 +00:00
parent 4da0573bf7
commit ba65b06b4a
2 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ChangeLog
View File

@ -1,3 +1,11 @@
2009-04-30 Nicolas François <nicolas.francois@centraliens.net>
* lib/commonio.c: Ignore teh return values of fclose() and
unlink() in case of failure of fopen_set_perms() or
create_backup().
* lib/commonio.c: Should the backup file be unlink'ed in case of
failure of create_backup()?
2009-04-30 Nicolas François <nicolas.francois@centraliens.net> 2009-04-30 Nicolas François <nicolas.francois@centraliens.net>
* lib/getulong.c: Added splint annotations. * lib/getulong.c: Added splint annotations.

9
lib/commonio.c
View File

@ -222,8 +222,9 @@ static /*@null@*/ /*@dependent@*/FILE *fopen_set_perms (
return fp; return fp;
fail: fail:
fclose (fp); (void) fclose (fp);
unlink (name); /* fopen_set_perms is used for intermediate files */
(void) unlink (name);
return NULL; return NULL;
} }
@ -257,11 +258,13 @@ static int create_backup (const char *backup, FILE * fp)
} }
} }
if ((c != EOF) || (ferror (fp) != 0) || (fflush (bkfp) != 0)) { if ((c != EOF) || (ferror (fp) != 0) || (fflush (bkfp) != 0)) {
fclose (bkfp); (void) fclose (bkfp);
/* FIXME: unlink the backup file? */
return -1; return -1;
} }
if ( (fsync (fileno (bkfp)) != 0) if ( (fsync (fileno (bkfp)) != 0)
|| (fclose (bkfp) != 0)) { || (fclose (bkfp) != 0)) {
/* FIXME: unlink the backup file? */
return -1; return -1;
} }