From c089196e15dcafc186474469c4914638da233b31 Mon Sep 17 00:00:00 2001 From: skyler-ferrante Date: Wed, 22 Mar 2023 12:46:56 -0400 Subject: [PATCH] Fix null dereference in basename On older kernels (<=linux-5.17), argv[0] can be null. Basename would call strrchr with null if argc==0. Fixes issue #680 --- libmisc/basename.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libmisc/basename.c b/libmisc/basename.c index fe916532..95a2f85d 100644 --- a/libmisc/basename.c +++ b/libmisc/basename.c @@ -21,6 +21,10 @@ #include "prototypes.h" /*@observer@*/const char *Basename (const char *str) { + if (str == NULL) { + abort (); + } + char *cp = strrchr (str, '/'); return (NULL != cp) ? cp + 1 : str;