emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

usermod: check if shell exists & is executable

Browse Source
This commit is contained in:
Geert Ijewski 2021-02-07 19:26:55 +01:00
parent ae169c4046
commit fe159b7668
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/usermod.c
View File

@ -1032,7 +1032,7 @@ static void grp_update (void)
static void process_flags (int argc, char **argv) static void process_flags (int argc, char **argv)
{ {
const struct group *grp; const struct group *grp;
struct stat st;
bool anyflag = false; bool anyflag = false;
{ {
@ -1180,12 +1180,25 @@ static void process_flags (int argc, char **argv)
case 'P': /* no-op, handled in process_prefix_flag () */ case 'P': /* no-op, handled in process_prefix_flag () */
break; break;
case 's': case 's':
if (!VALID (optarg)) { if ( ( !VALID (optarg) )
|| ( ('\0' != optarg[0])
&& ('/' != optarg[0])
&& ('*' != optarg[0]) )) {
fprintf (stderr, fprintf (stderr,
_("%s: invalid field '%s'\n"), _("%s: invalid shell '%s'\n"),
Prog, optarg); Prog, optarg);
exit (E_BAD_ARG); exit (E_BAD_ARG);
} }
if ( '\0' != optarg[0]
&& '*' != optarg[0]
&& strcmp(optarg, "/sbin/nologin") != 0
&& ( stat(optarg, &st) != 0
|| S_ISDIR(st.st_mode)
|| access(optarg, X_OK) != 0)) {
fprintf (stderr,
_("%s: Warning: missing or non-executable shell '%s'\n"),
Prog, optarg);
}
user_newshell = optarg; user_newshell = optarg;
sflg = true; sflg = true;
break; break;