emo/shadow
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

* lib/commonio.c: Avoid implicit conversion of pointers to

Browse Source 
booleans.
	* lib/commonio.c: Ignore the return value of close when a
	failure is reported.
This commit is contained in:
nekral-guest
2010-03-17 23:59:47 +00:00
parent a013f8519b
commit fe71812b1d
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
ChangeLog
View File

@ -1,3 +1,10 @@
2010-03-17 Nicolas François <nicolas.francois@centraliens.net>
* lib/commonio.c: Avoid implicit conversion of pointers to
booleans.
* lib/commonio.c: Ignore the return value of close when a
failure is reported.
2010-03-16 Nicolas François <nicolas.francois@centraliens.net> 2010-03-16 Nicolas François <nicolas.francois@centraliens.net>
* man/faillog.8.xml: Document the behavior in display mode of the * man/faillog.8.xml: Document the behavior in display mode of the
@ -878,7 +885,7 @@
2009-04-30 Nicolas François <nicolas.francois@centraliens.net> 2009-04-30 Nicolas François <nicolas.francois@centraliens.net>
* lib/commonio.c: Ignore teh return values of fclose() and * lib/commonio.c: Ignore the return values of fclose() and
unlink() in case of failure of fopen_set_perms() or unlink() in case of failure of fopen_set_perms() or
create_backup(). create_backup().
* lib/commonio.c: Should the backup file be unlink'ed in case of * lib/commonio.c: Should the backup file be unlink'ed in case of

4
lib/commonio.c
View File

@ -572,8 +572,8 @@ int commonio_open (struct commonio_db *db, int mode)
#endif /* WITH_TCB */ #endif /* WITH_TCB */
db->fp = fdopen (fd, db->readonly ? "r" : "r+"); db->fp = fdopen (fd, db->readonly ? "r" : "r+");
saved_errno = errno; saved_errno = errno;
if (!db->fp) { if (NULL == db->fp) {
close (fd); (void) close (fd);
} }
} }
errno = saved_errno; errno = saved_errno;