4976708c00
* src/gpasswd.c: Document the long options in the usage.
nekral-guest
2008-09-06 22:20:19 +00:00
761cdf5dfc
Remove done item: - groupmems: - need some work on add PAM and i18n support. - userdel: - add lookop and remove per user group.
nekral-guest
2008-09-06 21:53:12 +00:00
2fb1dbfcd1
Remove done item: PAM: add support for customization of the PAM support (i.e. support the Debian PAM configuration)
nekral-guest
2008-09-06 21:50:15 +00:00
8b3029e430
* NEWS: Added configure --enable-account-tools-setuid (default) / --disable-account-tools-setuid options. This permits to disable the PAM authentication of the caller for chage, chgpasswd, chpasswd, groupadd, groupdel, groupmod, newusers, useradd, userdel, and usermod. This authentication is not necessary when these tools are not installed setuid root.
nekral-guest
2008-09-06 21:42:26 +00:00
f8aef607ae
* configure.in: Added option --enable-account-tools-setuid to enable/disable the usage of PAM to authenticate the callers of account management tools: chage, chgpasswd, chpasswd, groupadd, groupdel, groupmod, useradd, userdel, usermod. * src/Makefile.am: Do not link the above tools with libpam if account-tools-setuid is disabled. * src/userdel.c, src/newusers.c, src/chpasswd.c, src/usermod.c, src/groupdel.c, src/chgpasswd.c, src/useradd.c, src/groupmod.c, src/groupadd.c, src/chage.c: Implement ACCT_TOOLS_SETUID (--enable-account-tools-setuid). * etc/pam.d/Makefile.am: Install the pam service file for the above tools only when needed. * src/useradd.c, src/userdel.c, src/usermod.c: It is no more needed to initialize retval to PAM_SUCCESS.
nekral-guest
2008-09-06 21:35:37 +00:00
bbae92e76f
* libmisc/tz.c: tz() is only used when USE_PAM is not defined. * lib/prototypes.h: Indicate functions whose presence depends on the USE_PAM flag.
nekral-guest
2008-09-06 16:43:21 +00:00
c89eb6d7eb
* libmisc/tz.c: tz() is only used when USE_PAM is not defined. * lib/prototypes.h: Indicate functions whose presence depends on the USE_PAM flag.
nekral-guest
2008-09-06 16:42:41 +00:00
70cf08329b
* src/groupmems.c: Call open_files() and close_files(). * src/groupmems.c: Always call check_perms(), which takes care of checking if --list is used.
nekral-guest
2008-09-06 16:27:21 +00:00
a7b3bcb43c
Fix typo. s/Prog/%s/ in the format string.
nekral-guest
2008-09-06 16:00:00 +00:00
18b7c8d188
* libmisc/obscure.c: Compare characters to '\0', not NULL.
nekral-guest
2008-09-06 15:59:28 +00:00
f34a638b38
* lib/defines.h: Do not include <config.h>. This complicate undefining some configuration macros when the file is included multiple times. * libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c, libmisc/xgetgrgid.c, libmisc/xgetgrnam.c, libmisc/xgetspnam.c: Include <config.h> from teh compiled C file, not the included getXXbyYY.c.
nekral-guest
2008-09-06 15:58:23 +00:00
18fc4505d3
* src/userdel.c, src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c, src/usermod.c, src/groupdel.c, src/chgpasswd.c, src/useradd.c, src/groupmod.c, src/groupadd.c, src/chage.c, src/chsh.c: Simplify the PAM error handling. Do not keep the pamh handle, but terminate the PAM transaction as soon as possible if there are no PAM session opened.
nekral-guest
2008-09-06 13:28:02 +00:00
ee4e367ea8
* src/newgrp.c, src/userdel.c, src/grpck.c, src/gpasswd.c, src/newusers.c, src/pwconv.c, src/chpasswd.c, src/logoutd.c, src/chfn.c, src/groupmems.c, src/usermod.c, src/pwunconv.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c, src/useradd.c, src/su.c, src/groupmod.c, src/passwd.c, src/pwck.c, src/groupadd.c, src/chage.c, src/login.c, src/grpconv.c, src/groups.c, src/grpunconv.c, src/chsh.c: Prog is now global (not static to the file) so that it can be used by the helper functions of libmisc. * lib/prototypes.h: Added extern char *Prog. * libmisc/find_new_gid.c, libmisc/find_new_uid.c: Indicate the program name with the warning.
nekral-guest
2008-09-06 12:51:53 +00:00
7034a913fd
* configure.in: Check if AUDIT_ADD_USER, AUDIT_DEL_USER, AUDIT_ADD_GROUP, and AUDIT_DEL_GROUP are defined in <libaudit.h>.
nekral-guest
2008-09-04 22:34:20 +00:00
e3ebd2c736
* src/useradd.c: Fix comment of lflg: it is also used for faillog.
nekral-guest
2008-09-04 20:46:00 +00:00
25d67da1da
Updated TODO list.
nekral-guest
2008-09-04 20:41:18 +00:00
7e17182e4c
* NEWS, src/groupmems.c, man/groupmems.8.xml: Document the long options.
nekral-guest
2008-09-04 20:20:20 +00:00
7e0008a2d7
* lib/prototypes.h, libmisc/audit_help.c: Define new type shadow_audit_result for the result argument of audit_logger(). This permits stronger type checking and a better readability of the results (SHADOW_AUDIT_FAILURE/SHADOW_AUDIT_SUCCESS constants). * src/groupadd.c, src/groupdel.c, src/useradd.c, src/userdel.c: Use the SHADOW_AUDIT_FAILURE/SHADOW_AUDIT_SUCCESS results instead of 0 or 1 in audit_logger().
nekral-guest
2008-09-04 19:36:27 +00:00
a21809cdae
* lib/prototypes.h, libmisc/audit_help.c: Define new type shadow_audit_result for the result argument of audit_logger(). This permits stronger type checking and a better readability of the results (SHADOW_AUDIT_FAILURE/SHADOW_AUDIT_SUCCESS constants). * src/groupadd.c, src/groupdel.c, src/useradd.c, src/userdel.c: Use the SHADOW_AUDIT_FAILURE/SHADOW_AUDIT_SUCCESS results instead of 0 or 1 in audit_logger().
nekral-guest
2008-09-04 19:35:48 +00:00
3dcaaf87e7
* src/userdel.c: Log failures to remove the mailbox to syslog and audit. * src/userdel.c: Log successful removal of home directory to audit only in case of success. * src/userdel.c: Move the audit log of failure to remove the home directory before the call to function that may exit. * src/userdel.c: Document that errors is only used to count errors during the removal of the home directory.
nekral-guest
2008-09-03 21:22:04 +00:00
f3c7ca59c5
* src/useradd.c: Log errors to syslog in grp_update() since changes have started to be reported to syslog. * src/userdel.c: Fix some result parameters sent to audit_logger().
nekral-guest
2008-09-03 21:02:32 +00:00
118303b9da
* man/useradd.8.xml: Document that -o is only valid with -u
nekral-guest
2008-08-31 17:31:08 +00:00
f74d7a9fd0
* man/useradd.8.xml: Document the /etc/default/useradd variables. * man/useradd.8.xml: Fix the documentation of the GROUP variable (and -g/--gid option).
nekral-guest
2008-08-31 17:31:00 +00:00
12a9942732
Added TODO items for useradd.
nekral-guest
2008-08-31 17:30:52 +00:00
a109ff1d85
* shadow.spec.in: Fix the source (new FTP).
nekral-guest
2008-08-31 17:30:45 +00:00
81e1dbc90e
* src/groupmems.c: The grp structure returned by gr_locate is a const. Duplicate this structure before working on it. * src/groupmems.c: Do not fail and do not display warnings if a close failure happens with the --list option. (Files are opened read-only).
nekral-guest
2008-08-31 17:29:08 +00:00
281721cd15
* src/gpasswd.c: Replace the 'valid' variable by is_valid to avoid clashes with the valid() function.
nekral-guest
2008-08-31 17:28:59 +00:00
0fcae007a0
* libmisc/obscure.c: Add brackets and parenthesis. * libmisc/obscure.c: Avoid implicit conversion of pointers / chars to booleans. * libmisc/obscure.c: Simplify the list of if.
nekral-guest
2008-08-31 17:28:49 +00:00
6b3266f228
* src/passwd.c: Fix a typo in the Usage string.
nekral-guest
2008-08-31 17:28:39 +00:00
ce4152c817
* src/logoutd.c: Fail if unexpected parameters are provided.
nekral-guest
2008-08-31 17:28:30 +00:00
73877b22c4
* src/grpunconv.c: Fail if unexpected parameters are provided. * src/grpunconv.c: Indicate that argc is not used in the no SHADOWGRP version.
nekral-guest
2008-08-31 17:28:21 +00:00
bf3e8f290c
* src/grpconv.c, src/groups.c: Name the parameters in the prototypes of the static functions. * src/grpconv.c: Fail if unexpected parameters are provided. * src/grpconv.c: Indicate that argc is not used in the no SHADOWGRP version.
nekral-guest
2008-08-31 17:28:12 +00:00
81a4edb776
Name the parameters in the prototypes of the static functions.
nekral-guest
2008-08-31 17:28:03 +00:00
399f453b4d
* src/chgpasswd.c, src/chpasswd.c: Removed variable ok, which is no more used.
nekral-guest
2008-08-31 17:27:56 +00:00
8e6c4b2e07
* src/chage.c: Fix the format for long integers (from %ul to %lu).
nekral-guest
2008-08-31 17:27:47 +00:00
4507bd32af
* libmisc/utmp.c: Mark the line and host arguments of setutmp() as not used in the __linux__ version.
nekral-guest
2008-08-31 17:27:37 +00:00
cd6a300222
* configure.in, src/login.c: Do not use HAVE_PAM_FAIL_DELAY, but HAS_PAM_FAIL_DELAY, to avoid a redefinition with Linux PAM.
nekral-guest
2008-08-31 17:27:16 +00:00
da693710f6
Revert " * src/groupmems.c: Added function open_°files and close_files to"
nekral-guest
2008-08-31 17:26:55 +00:00
71656e3cba
* src/groupmems.c: Added function open_°files and close_files to ease the support of gshadow. * src/groupmems.c: Always call check_perms(). This function now succeed when the requested action is to list the members.
nekral-guest
2008-08-30 18:34:43 +00:00
72d75d50d9
* src/groupmems.c: Added functions add_user(), remove_user(), and purge_members() to ease the support of gshadow.
nekral-guest
2008-08-30 18:34:24 +00:00
cdf963b2b3
* src/expiry.c: Use Basename for Prog. * src/expiry.c: Added missing OPENLOG.
nekral-guest
2008-08-30 18:34:04 +00:00
de11907053
* lib/nscd.c: Make sure the file is not empty when configured without nscd support.
nekral-guest
2008-08-30 18:33:13 +00:00
8075d27e32
* configure.in: Remove the USE_NSCD AM_CONDITIONAL (USE_NSCD is not used in any Makefile.am). * configure.in: Make sure posix_spawn is present when configured with nscd support.
nekral-guest
2008-08-30 18:32:43 +00:00
cf4aea18b4
* libmisc/mail.c: Added brackets and parenthesis. * libmisc/mail.c: Avoid assignments in comparisons.
nekral-guest
2008-08-30 18:31:56 +00:00
7bbaec8fed
Added missing changes from last commit.
nekral-guest
2008-08-30 18:31:35 +00:00
68b7aad535
* configure.in: Check if the stat structure has a st_atim or st_atimensec field. * libmisc/copydir.c: Conditionally use the stat's st_atim and st_atimensec fields.
nekral-guest
2008-08-30 18:31:21 +00:00
f86b2704d5
* lib/groupio.h, lib/prototypes.h, lib/pwio.h, lib/sgetgrent.c: Include <sys/types.h> before <pwd.h> and <grp.h>. It is necessary for the definition of uid_t and gid_t. * lib/pwmem.c: do not include <pwd.h>, "pwio.h" is sufficient here.
nekral-guest
2008-08-30 18:30:58 +00:00
c59126a817
* configure.in, lib/nscd.h, lib/nscd.c: Added --with-nscd flag to support systems without nscd.
nekral-guest
2008-08-30 18:30:36 +00:00
b4899946ef
Added missing include file (assert.h).
nekral-guest
2008-08-30 18:30:15 +00:00
76ea48bb64
* NEWS: Added support for uclibc. * configure.in, libmisc/copydir.c: futimes() and lutimes() are not standard. Check if they are implemented before using them. Do not set the time of links if lutimes() does not exist, and use utimes() as a replacement for futimes().
nekral-guest
2008-08-30 18:29:55 +00:00
0c7df2f9a0
* src/groupmems.c: When removing an user, check if deluser is on the list, not adduser. This fixes a segmentation fault for every call of groupmems -d. * libmisc/list.c: Add assertions to help identifying these issues. * libmisc/list.c: Avoid implicit conversion of pointers to booleans.
nekral-guest
2008-08-30 18:29:08 +00:00
77f81fa0b6
* NEWS, src/groupmems.c: Use the "groupmems" PAM service name instead of "groupmod".
nekral-guest
2008-08-30 18:28:45 +00:00
aa2fee4969
* src/useradd.c: Harmonize some error messages. * src/userdel.c: Add log to syslog when the mail file could not be removed. * src/userdel.c: Give more context an error message (merge with perror()). * src/usermod.c: Harmonize some error messages.
nekral-guest
2008-08-30 18:27:59 +00:00
d7b55ce2bb
* src/groupmems.c: Check the return value of gr_update(). * src/chage.c, src/chfn.c, src/chgpasswd.c, src/chpasswd.c, src/chsh.c, src/gpasswd.c, src/groupadd.c, src/groupmems.c, src/groupmod.c, src/grpck.c, src/grpconv.c, src/grpunconv.c, src/passwd.c, src/pwck.c, src/pwconv.c, src/pwunconv.c, src/useradd.c, src/userdel.c, src/usermod.c: Harmonize the error message sent to stderr in case of *_update () failure. * src/chage.c, src/chsh.c, src/groupadd.c, src/passwd.c: Do not log to syslog when pw_update() or spw_update() fail. * src/newusers.c: Do not log specific error message to stderr when sgr_update() fails. * src/pwconv.c: Remove duplicated definition of Prog.
nekral-guest
2008-08-30 18:27:34 +00:00
38a50366bc
* src/chfn.c, src/chsh.c, src/expiry.c, src/gpasswd.c, src/newgrp.c, src/passwd.c, src/su.c: Use the same stderr and syslog warnings when the username cannot be determined. * src/newgrp.c: Reuse the same stderr message for groups which do not exist in the system.
nekral-guest
2008-08-30 18:27:07 +00:00
307f703b99
* src/usermod.c: Log errors while *_close to syslog. * src/usermod.c: Added missing }
nekral-guest
2008-08-22 02:34:04 +00:00
306f19b805
* src/grpconv.c: Use Basename for the definition of Prog. Prog needs a file visibility. * src/grpunconv.c: Likewise.
nekral-guest
2008-08-22 02:33:08 +00:00
a3be8ff055
* src/chfn.c: Do not exit on pw_unlock failures. * src/grpconv.c, src/grpunconv.c, src/pwconv.c, src/pwunconv.c, src/vipw.c: Open syslog with the right identification name. * src/vipw.c: Log unlock errors to syslog. * src/vipw.c: Log edits to syslog. * src/chage.c, src/chfn.c, src/chsh.c, src/gpasswd.c, src/groupadd.c, src/groupdel.c, src/groupmod.c, src/grpconv.c, src/grpunconv.c, src/passwd.c, src/pwck.c, src/pwunconv.c, src/useradd.c, src/usermod.c: Harmonize the syslog levels. Failure to close or unlock are errors. Failure to open files are warnings.
nekral-guest
2008-08-22 02:30:33 +00:00
c9119dc6bb
* src/newusers.c: Open syslog with the right identification name. * src/newusers.c: Mark the files as locked only if they are really locked (i.e. if shadow is not enabled, the files are not locked).
nekral-guest
2008-08-22 02:29:31 +00:00
cfeacc4d67
* NEWS, src/gpasswd.c: Use getopt_long instead of getopt. Added support for long options --add (-a), --delete (-d), --remove-password (-r), --restrict (-R), --administrators (-A), and --members (-M) * man/gpasswd.1.xml: Document the new long options. * src/gpasswd.c: The sgrp structure is only used if SHADOWGRP is defined.
nekral-guest
2008-08-22 02:28:15 +00:00
2bdcb9c33d
* src/grpck.c: Added function fail_exit(). Check failure to unlock files. Report errors to stderr and syslog, but continue. * src/grpconv.c: Check failure to unlock files. Report errors to stderr and syslog, but continue.
nekral-guest
2008-08-22 02:26:46 +00:00
7ae6b8fc34
* src/passwd.c: Check failure to unlock files. Report errors to stderr and syslog, but continue.
nekral-guest
2008-08-22 02:24:29 +00:00
82779cd336
* src/chfn.c, src/chgpasswd.c, src/chpasswd.c, src/gpasswd.c, src/groupadd.c, src/groupdel.c, src/groupmems.c, src/groupmod.c, src/grpconv.c, src/grpunconv.c, src/newusers.c, src/pwconv.c, src/pwunconv.c, src/useradd.c, src/userdel.c: Harmonize the name of the variables keeping the lock status, to match the shadow library prefixes.
nekral-guest
2008-08-22 02:22:34 +00:00
82ed690817
* src/chage.c, src/chgpasswd.c, src/chpasswd.c, src/chsh.c, src/gpasswd.c, src/groupadd.c, src/groupdel.c, src/groupmems.c, src/groupmod.c, src/grpck.c, src/grpconv.c, src/grpunconv.c, src/newusers.c, src/passwd.c, src/pwck.c, src/pwconv.c, src/pwunconv.c, src/useradd.c, src/userdel.c, src/usermod.c: In case of a lock failure, indicate to the user that she can try again later. Do not log to syslog.
nekral-guest
2008-08-22 02:20:53 +00:00
130553a578
Sort the NEWS entry alphabetically (per program name).
nekral-guest
2008-08-22 02:18:48 +00:00
1355d5d3eb
* NEWS, src/passwd.c: For compatibility with other passwd version, the --lock an --unlock options do not lock or unlock the user account anymore. They only lock or unlock the user's password. * man/passwd.1.xml: Document above change. Document how an account can be locked and what a password lock means.
nekral-guest
2008-08-22 02:16:21 +00:00
fa33bb9d0e
* man/groupadd.8.xml: Fix the regular expression for group policy. The final $ character is optional. * man/groupadd.8.xml: Likewise. * man/groupadd.8.xml: Indicate the maximum size of usernames.
nekral-guest
2008-08-15 15:25:53 +00:00
2c950c5cb5
* man/pl/Makefile.am: Do not build the Polish translation of login.1 and su.1 (not enough translated). See http://bugs.debian.org/491460
nekral-guest
2008-08-13 06:55:55 +00:00
2722e6bb68
* man/shadow.5.xml: Fix typo. The password must be changed before the maximum number of days, not after.
nekral-guest
2008-08-13 06:55:37 +00:00
ce4e0b78bc
Updated TODO file.
nekral-guest
2008-08-09 23:34:04 +00:00
b6cc69cd8f
* src/pwck.c: Added fail_exit(). * src/pwck.c: Report failure to unlock files to stderr and syslog. * src/pwck.c: Report failure to sort to stderr, and exit with E_CANTSORT. * man/pwck.8.xml: Document return code 6 (E_CANTSORT).
nekral-guest
2008-08-09 23:33:26 +00:00
10e78fbd8e
* src/vipw.c: Report failures to remove files to stderr. * src/vipw.c: Report failures to unlock files to stderr.
nekral-guest
2008-08-09 23:31:36 +00:00
e3e99974f8
* NEWS, src/groupmems.c: Added syslog support. * src/groupmems.c: members() renamed display_members() to avoid name clash with its members argument. * src/groupmems.c: Report failure to unlock to syslog. * src/groupmems.c: Harmonize error messages. * src/groupmems.c: Report failures to write the new group file to syslog (gr_close() failure). * src/groupmems.c: Don't use fail_exit for non-failure exit.
nekral-guest
2008-08-09 23:28:30 +00:00
e069125a2c
* src/chsh.c: Added fail_exit(). * src/chsh.c: Use fail_exit() instead of exit(), this avoid calling closelog() every times. * src/chsh.c: Ignore the return value or pam_end(). * src/chsh.c: Simplify the PAM error handling. * src/chsh.c: Report failure to unlock files to stderr and syslog.
nekral-guest
2008-08-09 23:27:50 +00:00
0528803da6
Include missing exitcodes.h
nekral-guest
2008-08-09 23:27:05 +00:00
e5e00ce9d6
Improve commonalities between chgpasswd and chpasswd.
nekral-guest
2008-08-09 23:25:49 +00:00
nekral-guest