- Every non-const pointer converts automatically to void *. - Every pointer converts automatically to void *. - void * converts to any other pointer. - const void * converts to any other const pointer. - Integer variables convert to each other. I changed the declaration of a few variables in order to allow removing a cast. However, I didn't attempt to edit casts inside comparisons, since they are very delicate. I also kept casts in variadic functions, since they are necessary, and in allocation functions, because I have other plans for them. I also changed a few casts to int that are better as ptrdiff_t. This change has triggered some warnings about const correctness issues, which have also been fixed in this patch (see for example src/login.c). Signed-off-by: Alejandro Colomar <alx@kernel.org>
		
			
				
	
	
		
			69 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			69 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * SPDX-FileCopyrightText: 2017, Chris Lamb
 | 
						|
 *
 | 
						|
 * SPDX-License-Identifier: BSD-3-Clause
 | 
						|
 */
 | 
						|
 | 
						|
#include <config.h>
 | 
						|
 | 
						|
#ident "$Id$"
 | 
						|
 | 
						|
#include <errno.h>
 | 
						|
#include <limits.h>
 | 
						|
#include <stdio.h>
 | 
						|
#include "defines.h"
 | 
						|
#include "prototypes.h"
 | 
						|
#include "shadowlog.h"
 | 
						|
 | 
						|
/*
 | 
						|
 * gettime() returns the time as the number of seconds since the Epoch
 | 
						|
 *
 | 
						|
 * Like time(), gettime() returns the time as the number of seconds since the
 | 
						|
 * Epoch, 1970-01-01 00:00:00 +0000 (UTC), except that if the SOURCE_DATE_EPOCH
 | 
						|
 * environment variable is exported it will use that instead.
 | 
						|
 */
 | 
						|
/*@observer@*/time_t gettime ()
 | 
						|
{
 | 
						|
	char *endptr;
 | 
						|
	char *source_date_epoch;
 | 
						|
	time_t fallback;
 | 
						|
	unsigned long long epoch;
 | 
						|
	FILE *shadow_logfd = log_get_logfd();
 | 
						|
 | 
						|
	fallback = time (NULL);
 | 
						|
	source_date_epoch = shadow_getenv ("SOURCE_DATE_EPOCH");
 | 
						|
 | 
						|
	if (!source_date_epoch)
 | 
						|
		return fallback;
 | 
						|
 | 
						|
	errno = 0;
 | 
						|
	epoch = strtoull (source_date_epoch, &endptr, 10);
 | 
						|
	if ((errno == ERANGE && (epoch == ULLONG_MAX || epoch == 0))
 | 
						|
			|| (errno != 0 && epoch == 0)) {
 | 
						|
		fprintf (shadow_logfd,
 | 
						|
			 _("Environment variable $SOURCE_DATE_EPOCH: strtoull: %s\n"),
 | 
						|
			 strerror(errno));
 | 
						|
	} else if (endptr == source_date_epoch) {
 | 
						|
		fprintf (shadow_logfd,
 | 
						|
			 _("Environment variable $SOURCE_DATE_EPOCH: No digits were found: %s\n"),
 | 
						|
			 endptr);
 | 
						|
	} else if (*endptr != '\0') {
 | 
						|
		fprintf (shadow_logfd,
 | 
						|
			 _("Environment variable $SOURCE_DATE_EPOCH: Trailing garbage: %s\n"),
 | 
						|
			 endptr);
 | 
						|
	} else if (epoch > ULONG_MAX) {
 | 
						|
		fprintf (shadow_logfd,
 | 
						|
			 _("Environment variable $SOURCE_DATE_EPOCH: value must be smaller than or equal to %lu but was found to be: %llu\n"),
 | 
						|
			 ULONG_MAX, epoch);
 | 
						|
	} else if ((time_t)epoch > fallback) {
 | 
						|
		fprintf (shadow_logfd,
 | 
						|
			 _("Environment variable $SOURCE_DATE_EPOCH: value must be smaller than or equal to the current time (%lu) but was found to be: %llu\n"),
 | 
						|
			 fallback, epoch);
 | 
						|
	} else {
 | 
						|
		/* Valid */
 | 
						|
		return epoch;
 | 
						|
	}
 | 
						|
 | 
						|
	return fallback;
 | 
						|
}
 |