9adfc136b6
libmisc/xgetXXbyYY.c, libmisc/xgetpwnam.c, libmisc/xgetpwuid.c, libmisc/xgetgrnam.c, libmisc/xgetgrgid.c, libmisc/xgetspnam.c: Added functions xgetpwnam(), xgetpwuid(), xgetgrnam(), xgetgrgid(), and xgetspnam(). They allocate memory for the returned structure and are more robust to successive calls. They are implemented with the libc's getxxyyy_r() functions if available. * libmisc/limits.c, libmisc/entry.c, libmisc/chowntty.c, libmisc/addgrps.c, libmisc/myname.c, libmisc/rlogin.c, libmisc/pwdcheck.c, src/newgrp.c, src/login_nopam.c, src/userdel.c, src/lastlog.c, src/grpck.c, src/gpasswd.c, src/newusers.c, src/chpasswd.c, src/chfn.c, src/groupmems.c, src/usermod.c, src/expiry.c, src/groupdel.c, src/chgpasswd.c, src/su.c, src/useradd.c, src/groupmod.c, src/passwd.c, src/pwck.c, src/groupadd.c, src/chage.c, src/login.c, src/suauth.c, src/faillog.c, src/groups.c, src/chsh.c, src/id.c: Review all the usage of one of the getpwnam(), getpwuid(), getgrnam(), getgrgid(), and getspnam() functions. It was noticed on http://bugs.debian.org/341230 that chfn and chsh use a passwd structure after calling a pam function, which result in using information from the passwd structure requested by pam, not the original one. It is much easier to use the new xget... functions to avoid these issues. I've checked which call to the original get... functions could be left (reducing the scope of the structure if possible), and I've left comments to ease future reviews (e.g. /* local, no need for xgetpwnam */). Note: the getpwent/getgrent calls should probably be checked also. * src/groupdel.c, src/expiry.c: Fix typos in comments. * src/groupmod.c: Re-indent. * libmisc/Makefile.am, lib/groupmem.c, lib/groupio.c, lib/pwmem.c, lib/pwio.c, lib/shadowmem.c, lib/shadowio.c: Move the __<xx>_dup functions (used by the xget... functions) from the <xx>io.c files to the new <xx>mem.c files. This avoid linking some utils against the SELinux library.
86 lines
1.6 KiB
C
86 lines
1.6 KiB
C
#include <config.h>
|
|
|
|
#ifdef HAVE_SETGROUPS
|
|
|
|
#include "prototypes.h"
|
|
#include "defines.h"
|
|
|
|
#include <stdio.h>
|
|
#include <grp.h>
|
|
#include <errno.h>
|
|
|
|
#ident "$Id$"
|
|
|
|
#define SEP ",:"
|
|
/*
|
|
* Add groups with names from LIST (separated by commas or colons)
|
|
* to the supplementary group set. Silently ignore groups which are
|
|
* already there. Warning: uses strtok().
|
|
*/
|
|
int add_groups (const char *list)
|
|
{
|
|
GETGROUPS_T *grouplist, *tmp;
|
|
int i, ngroups, added;
|
|
char *token;
|
|
char buf[1024];
|
|
|
|
if (strlen (list) >= sizeof (buf)) {
|
|
errno = EINVAL;
|
|
return -1;
|
|
}
|
|
strcpy (buf, list);
|
|
|
|
i = 16;
|
|
for (;;) {
|
|
grouplist = (gid_t *) malloc (i * sizeof (GETGROUPS_T));
|
|
if (!grouplist)
|
|
return -1;
|
|
ngroups = getgroups (i, grouplist);
|
|
if (i > ngroups)
|
|
break;
|
|
/* not enough room, so try allocating a larger buffer */
|
|
free (grouplist);
|
|
i *= 2;
|
|
}
|
|
if (ngroups < 0) {
|
|
free (grouplist);
|
|
return -1;
|
|
}
|
|
|
|
added = 0;
|
|
for (token = strtok (buf, SEP); token; token = strtok (NULL, SEP)) {
|
|
struct group *grp;
|
|
|
|
grp = getgrnam (token); /* local, no need for xgetgrnam */
|
|
if (!grp) {
|
|
fprintf (stderr, _("Warning: unknown group %s\n"),
|
|
token);
|
|
continue;
|
|
}
|
|
|
|
for (i = 0; i < ngroups && grouplist[i] != grp->gr_gid; i++);
|
|
|
|
if (i < ngroups)
|
|
continue;
|
|
|
|
if (ngroups >= sysconf (_SC_NGROUPS_MAX)) {
|
|
fprintf (stderr, _("Warning: too many groups\n"));
|
|
break;
|
|
}
|
|
tmp = (gid_t *) realloc (grouplist, (ngroups + 1) * sizeof (GETGROUPS_T));
|
|
if (!tmp) {
|
|
free (grouplist);
|
|
return -1;
|
|
}
|
|
tmp[ngroups++] = grp->gr_gid;
|
|
grouplist = tmp;
|
|
added++;
|
|
}
|
|
|
|
if (added)
|
|
return setgroups (ngroups, grouplist);
|
|
|
|
return 0;
|
|
}
|
|
#endif
|