bddcd9b095
- Every non-const pointer converts automatically to void *. - Every pointer converts automatically to void *. - void * converts to any other pointer. - const void * converts to any other const pointer. - Integer variables convert to each other. I changed the declaration of a few variables in order to allow removing a cast. However, I didn't attempt to edit casts inside comparisons, since they are very delicate. I also kept casts in variadic functions, since they are necessary, and in allocation functions, because I have other plans for them. I also changed a few casts to int that are better as ptrdiff_t. This change has triggered some warnings about const correctness issues, which have also been fixed in this patch (see for example src/login.c). Signed-off-by: Alejandro Colomar <alx@kernel.org>
109 lines
2.3 KiB
C
109 lines
2.3 KiB
C
/*
|
|
* SPDX-FileCopyrightText: 1991 , Julianne Frances Haugh
|
|
* SPDX-FileCopyrightText: 1991 , Chip Rosenthal
|
|
* SPDX-FileCopyrightText: 1996 - 1998, Marek Michałkiewicz
|
|
* SPDX-FileCopyrightText: 2003 - 2005, Tomasz Kłoczko
|
|
* SPDX-FileCopyrightText: 2007 - 2010, Nicolas François
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <config.h>
|
|
#include "defines.h"
|
|
#include <stdio.h>
|
|
#include "getdef.h"
|
|
#include "prototypes.h"
|
|
|
|
#ident "$Id$"
|
|
|
|
/*
|
|
* This is now rather generic function which decides if "tty" is listed
|
|
* under "cfgin" in config (directly or indirectly). Fallback to default if
|
|
* something is bad.
|
|
*/
|
|
static bool is_listed (const char *cfgin, const char *tty, bool def)
|
|
{
|
|
FILE *fp;
|
|
char buf[1024], *s;
|
|
const char *cons;
|
|
|
|
/*
|
|
* If the CONSOLE configuration definition isn't given,
|
|
* fallback to default.
|
|
*/
|
|
|
|
cons = getdef_str (cfgin);
|
|
if (NULL == cons) {
|
|
return def;
|
|
}
|
|
|
|
/*
|
|
* If this isn't a filename, then it is a ":" delimited list of
|
|
* console devices upon which root logins are allowed.
|
|
*/
|
|
|
|
if (*cons != '/') {
|
|
char *pbuf;
|
|
strlcpy (buf, cons, sizeof (buf));
|
|
pbuf = &buf[0];
|
|
while ((s = strtok (pbuf, ":")) != NULL) {
|
|
if (strcmp (s, tty) == 0) {
|
|
return true;
|
|
}
|
|
|
|
pbuf = NULL;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/*
|
|
* If we can't open the console list, then call everything a
|
|
* console - otherwise root will never be allowed to login.
|
|
*/
|
|
|
|
fp = fopen (cons, "r");
|
|
if (NULL == fp) {
|
|
return def;
|
|
}
|
|
|
|
/*
|
|
* See if this tty is listed in the console file.
|
|
*/
|
|
|
|
while (fgets (buf, sizeof (buf), fp) != NULL) {
|
|
/* Remove optional trailing '\n'. */
|
|
buf[strcspn (buf, "\n")] = '\0';
|
|
if (strcmp (buf, tty) == 0) {
|
|
(void) fclose (fp);
|
|
return true;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* This tty isn't a console.
|
|
*/
|
|
|
|
(void) fclose (fp);
|
|
return false;
|
|
}
|
|
|
|
/*
|
|
* console - return 1 if the "tty" is a console device, else 0.
|
|
*
|
|
* Note - we need to take extreme care here to avoid locking out root logins
|
|
* if something goes awry. That's why we do things like call everything a
|
|
* console if the consoles file can't be opened. Because of this, we must
|
|
* warn the user to protect against the remove of the consoles file since
|
|
* that would allow an unauthorized root login.
|
|
*/
|
|
|
|
bool console (const char *tty)
|
|
{
|
|
if (strncmp (tty, "/dev/", 5) == 0) {
|
|
tty += 5;
|
|
}
|
|
|
|
return is_listed ("CONSOLE", tty, true);
|
|
}
|
|
|