emo/sysklogd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

If fstat() failes logrotate() cannot run, found by Coverity Scan

Browse Source 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This commit is contained in:
Joachim Nilsson 2019-11-05 10:23:17 +01:00
parent 1fe3c311ca
commit 2e8dffe893
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/syslogd.c
View File

@ -1461,7 +1461,9 @@ void logrotate(struct filed *f)
if (!f->f_rotatesz) if (!f->f_rotatesz)
return; return;
fstat(f->f_file, &statf); if (fstat(f->f_file, &statf))
return;
/* bug (mostly harmless): can wrap around if file > 4gb */ /* bug (mostly harmless): can wrap around if file > 4gb */
if (S_ISREG(statf.st_mode) && statf.st_size > f->f_rotatesz) { if (S_ISREG(statf.st_mode) && statf.st_size > f->f_rotatesz) {
if (f->f_rotatecount > 0) { /* always 0..999 */ if (f->f_rotatecount > 0) { /* always 0..999 */