From 50539e29d42029fae71a640138fc0271bd99196b Mon Sep 17 00:00:00 2001 From: Joey Schulze Date: Tue, 12 Sep 2000 21:53:31 +0000 Subject: [PATCH] . Close symbol file before returning with 0 when an error occurred while reading it. This will enable systems to umount that partition with no open file descriptor left over. --- CHANGES | 3 +++ ksym.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/CHANGES b/CHANGES index 0aa9404..29a2caf 100644 --- a/CHANGES +++ b/CHANGES @@ -2,6 +2,9 @@ Version 1.4 . Skip newline when reading in klog messages . Use lseek64() instead of llseek() which is deprecated these days + . Close symbol file before returning with 0 when an error occurred + while reading it. This will enable systems to umount that + partition with no open file descriptor left over. . Keith Owens - Fixed bug that caused klogd to die if there is no sym_array available. - When symbols are expanded, print the line twice. Once with diff --git a/ksym.c b/ksym.c index 3c74b66..0a6d715 100644 --- a/ksym.c +++ b/ksym.c @@ -102,6 +102,9 @@ * * Sun Feb 21 22:27:49 EST 1999: Keith Owens * Fixed bug that caused klogd to die if there is no sym_array available. + * + * Tue Sep 12 23:48:12 CEST 2000: Martin Schulze + * Close symbol file in InitKsyms() when an error occurred. */ @@ -247,6 +250,7 @@ extern int InitKsyms(mapfile) if ( AddSymbol(address, sym) == 0 ) { Syslog(LOG_ERR, "Error adding symbol - %s.", sym); + fclose(sym_file); return(0); }