emo/sysklogd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

syslogd: Use snprintf() rather than sprintf()

Browse Source 
Protects against buffer overruns.

Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This commit is contained in:
Joachim Nilsson 2019-12-16 22:04:14 +01:00
parent 0afdfb4911
commit ff03287d5a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/syslogd.c
View File

@ -1297,8 +1297,8 @@ void logrotate(struct filed *f)
/* rename: f.8 -> f.9; f.7 -> f.8; ... */ /* rename: f.8 -> f.9; f.7 -> f.8; ... */
for (i = 1; i > 0; i--) { for (i = 1; i > 0; i--) {
sprintf(oldFile, "%s.%d", f->f_un.f_fname, i - 1); snprintf(oldFile, len, "%s.%d", f->f_un.f_fname, i - 1);
sprintf(newFile, "%s.%d", f->f_un.f_fname, i); snprintf(newFile, len, "%s.%d", f->f_un.f_fname, i);
if (!rename(oldFile, newFile) && i > 0) { if (!rename(oldFile, newFile) && i > 0) {
size_t len = 18 + strlen(newFile) + 1; size_t len = 18 + strlen(newFile) + 1;
@ -1310,7 +1310,7 @@ void logrotate(struct filed *f)
} }
/* newFile == "f.0" now */ /* newFile == "f.0" now */
sprintf(newFile, "%s.0", f->f_un.f_fname); snprintf(newFile, len, "%s.0", f->f_un.f_fname);
(void)rename(f->f_un.f_fname, newFile); (void)rename(f->f_un.f_fname, newFile);
close(f->f_file); close(f->f_file);