Commit Graph

157 Commits

Author SHA1 Message Date
Jesse Smith
483dc777d2 Changed the way the "when" variable is used internally in shutdown.c.
It starts as a NULL pointer, then might get set as a pointer to optarg,
then it might get set to point to an argv parameter, then it might have
a string value copied into it, over-writing the original data. We should
not risk over-writing internal variables which might get used for something
else (it's rude and security risk). Set up "when" as its own buffer
that has data from optargs and/or argv copied into it.

Minor code fixes across multiple source files to avoid buffer
overflows, or uninitialized strings.
2019-01-27 15:55:08 -04:00
Jesse Smith
43b5c64126 Use defined constant for field length for easier updating/patching
in sulogin.c
2019-01-13 12:24:12 -04:00
Jesse Smith
5af4ee50a8 Minor update to defines and Makefile to avoid compile warnings
when building logsave.
2019-01-01 17:06:07 -04:00
Jesse Smith
3f2b4a5704 Added logsave.c and logsave.8 manual page from e2fsprogs to make
sure logsave is available to initscripts.

Updated src/Makefile to make sure bootlogd compiles with Clang.
2018-12-31 16:31:34 -04:00
Jesse Smith
5d955d55c8 Increased the size of the kernel command line buffer in bootlogd
from 256 characters to 4096. This size is defined in KERNEL_COMMAND_LENGTH
for easy modification downstream.
2018-12-29 14:46:10 -04:00
Jesse Smith
9e8553cacb Updated copyright in init and removed unused Version variable from killall5.c 2018-12-27 15:31:14 -04:00
Jesse Smith
be8d584161 Added some defines and compile-time conditionals to make some
components of sysvinit compile on FreeBSD.
2018-12-09 19:32:04 -04:00
Jesse Smith
5dc965ba10 Removed references to malloc.h Allocating and freeing memory
is now handled by stdlib.h
2018-12-09 17:55:52 -04:00
Jesse Smith
f0e93128bc When the halt command is called with the -p flag (or as poweroff)
the command now passes the "-h -P" flags to shutdown. This
in turn sets the INIT_HALT environment variable to POWEROFF.
Assuming this value is checked by initscripts during the
shutting down procedure, it should cause the system to
be powered off.
If halt is called without -p then the value of INIT_HALT
is not set and the default action (often set in /etc/defaut/halt)
is taken.
2018-11-23 22:11:42 -04:00
Jesse Smith
c03e2fac2b Added fix to pidof which re-enabled the omit (-o) flag.
this was broken when formatting was added in the 2.92 release.
Closes Debian bug #914494.
2018-11-23 18:00:23 -04:00
Jesse Smith
c679a49aac Added patch from Samuel Thibault to make project compile
on Hurd branch of Debian.
2018-11-19 18:12:13 -04:00
Jesse Smith
5d3815b0ff Added manual page and options for readbootlog. 2018-11-12 20:53:52 -04:00
Jesse Smith
7c1a8d932a Added new tool (readbootlog) which will read the /var/log/boot file
produced by bootlogd. The output is displayed cleaned up so there
are no control characters. This avoids the need to use sed or related
tools to try to clean up the contents of the log.
2018-11-12 20:29:28 -04:00
Jesse Smith
aa6873b85b Removed typos from pidof manual page and killall5 page.
Closes Debian bugs #815839, #905245 and #890478

Added -f <format> option to pidof program to allow printf
style formating.
Closes Debian bug #571590
Thanks to Philipp Marek for the patch.
2018-11-10 21:27:11 -04:00
Jesse Smith
2ece2c0364 Updated src/Makefile to confirm we build all the necessary software
prior to trying to install it.
2018-11-07 17:24:55 -04:00
Jesse Smith
848ee05104 Updated init manual page to include GRUB in boot loader comment
as LILO is rarely used outside of the Slackware family these days.

Switched stty flags to use ECHOE instead of ECHOPRT. This should
give smoother, more natural backspac-erase behaviour on emergency
consoles. (Created in init -b mode.)
2018-11-05 23:15:11 -04:00
Jesse Smith
c45219c64f Added -q and -Q flags to shutdown command to make the "system is going down"
message appear less often. The -q flag causes messages to only appear at the
10 minute, 5 minute and x-hour intervals.
The -Q flag maintains complete silence up until the final "now" warning.
2018-11-01 17:21:47 -03:00
Jesse Smith
44fce86dde Added -l flag to "last" command. When used it allows "last" to
display usernames longer than 8 characters long.
2018-10-30 21:46:04 -03:00
Jesse Smith
be8e6b9e1c shutdown command was setting environment variable INIT_HALT to
"POWERDOWN", this should have been "POWERDOWN" as specified in the
manual page. Fixed code to match manual page and init scripts.
2018-10-28 16:19:26 -03:00
Jesse Smith
a17f736a42 Applied patch from Regid Ichira to clarify shutdown command
line options. Updated manual page for shutdown.
Closes Debian bug #630661.
2018-10-27 20:37:47 -03:00
Jesse Smith
1b659c8ebe Applied patch from Daniel Povey which should allow killall5/pidof to
avoid locking up if it encounters stopped or zombie processes
due to broken NFS mount points.
This should allow Debian bug #719273 to be closed.
2018-10-27 20:26:15 -03:00
Jesse Smith
ed85143837 Removed super loud PC speaker beep during shutdown.
Closes Debian bug #614893. Patch from Andreas Fackler.
2018-10-22 22:03:09 -03:00
Jesse Smith
d27e34754a Unified shutdown and init to use 3 second wait between SIGTERM and
SIGKILL. Defined this value in init.h (WAIT_BETWEEN_SIGNALS) for
easy modification.
Updated documentation to address Debian bug #375274.
2018-10-22 21:44:39 -03:00
Jesse Smith
7b1d470949 Added check for kernel parameter init.autocon=1. If this exists, then
init will try to open its own console. If not, then any console=
parameters will be ignored. This avoids conflicts with native kernel
created consoles.
2018-09-29 17:12:12 -03:00
Jesse Smith
f1ca96e1c1 Added patch from Walter Harms which allows pidof to run without
displaying output. In this mode pidof simply returns true or false
without displaying PID values.

Updated manual page with new -q (quiet) mode.

Added -h flag for pidof, which was recognized before, but not used.
The -h flag now displays brief usage information for pidof.
2018-09-08 17:19:21 -03:00
Jesse Smith
6e8323e9fb The init process now writes the current runlevel to /var/run/runlevel.
This information can be read by the "runlevel" command as well as "halt"
and "reboot". Having the information logged in /var/run/runlevel as
well as the utmp file means systems without utmp (like those running
the musl C library) can still check the current runlevel. This is
useful when running halt/reboot as these programs want to check the
runlevel.

Updated the changelog, and manual pages for halt and runlevel.
2018-07-07 20:19:03 -03:00
Jesse Smith
6b26692584 Added new runlevel log code which saves (and reads) the current runlevel
from /var/run/runlevel. Added test code to runlevel.c to confirm it works.

Will use this to save/restore runlevel on systems where utmp is not
available.
2018-07-07 18:49:04 -03:00
Jesse Smith
7656f9d5f9 Version information is now fetched and defined by the Makefile.
No more need to update the version manually in the init.c source.
2018-07-01 18:44:57 -03:00
Jesse Smith
4438de4e50 Added --version flag to init and updated manual page. 2018-06-22 17:04:47 -03:00
Jesse Smith
2a61e2b029 Adjusted order of compile flags to make it possible to select optimization
level by setting CFLAGS at compile file.
2018-06-21 20:22:44 -03:00
Jesse Smith
40f40a4166 Removed DATE define from init.c, not needed anymore.
Updated Changelog in prep for release.
2018-06-18 19:35:53 -03:00
Jesse Smith
c229965b62 Fixed typo. Corrected by Radostin Stoyanov. 2018-06-11 13:06:04 -03:00
Jesse Smith
2d6d2bc0d3 Updated toplevel Makefile to avoid created unnecessary temporary
directories when they are not wanted/required.
2018-06-03 20:14:01 -03:00
Jesse Smith
108b31e284 Switched from using -fstack-protector to -fstack-protector-strong compile
flag. Tested with both GCC and Clang.
2018-06-02 16:50:35 -03:00
Jesse Smith
56e1041034 Updated Makefile and version information. 2018-05-20 17:21:18 -03:00
Jesse Smith
bed25016b1 Updated sulogin.c to pull in crypt.h as it is a new, undocumented
dependency on Fedora 28.
Confirmed we can still build on other/older platforms.
2018-05-09 17:55:35 -03:00
Jesse Smith
828c2704a1 Removed old LSM file.
Added .gitignore files to avoid git tracking object files.
Removed old start-stop-daemon from contrib directory.
2018-05-04 22:08:38 -03:00
Jesse Smith
e0cfd39728 Added "Fall through" comments to some switch statements where multiple
approaches are tried in order to prevent warnings from GCC 7 (and newer).

Added includes on Linux for sys/sysmacros.h as the old defines in
the sys/types.h file will be removed in the future.
2018-05-04 14:51:40 -03:00
Jesse Smith
cfb39b573f Updated init.c to remove some old notes and answer questions
that were flagged in comments or FIXME labels.
2018-04-23 00:09:49 -03:00
Jesse Smith
272f112c98 Added new signal handler for SIGUSR2. When init receives SIGUSR2
it closes (and leaves closed) the named pipe /run/initctl. This
can be used to make sure init does not have any files open. However,
it also means we cannot switch run levels or bring down the system.
The pipe can be re-opened by sending init the SIGUSR1 signal.

Updated the man pages for initctl and init to include this information.
2018-04-17 19:44:50 -03:00
Jesse Smith
f09da9cb55 Add check to make sure /run/initctl is open before we try to close
it when receiving SIGUSR1. Avoids crashing upon receiving signal.
2018-04-15 14:09:33 -03:00
Jesse Smith
aee28b3292 Updated init page to reference the initctl manual page instead of
telling people to read the source code to learn how to use
the /run/initctl named pipe. Updated Makefile to install
the initctl.5 manual page.
2018-04-14 19:19:18 -03:00
Jesse Smith
a4508479f5 Updated shutdown to check if time has lapsed when we did not
notice. For example if the computer was in sleep mode pending
a shutdown. The shutdown command now notices time has past
and adjusts its countdown clock to compensate. Accurate
to the nearest minute.
Closes Savannah bug #36279
2018-04-04 23:12:25 -03:00
Jesse Smith
d9b6475d85 Removed unneeded "count" variable in utmpdump.c.
Fixed typo in accidental wrote_wtmp_rlevel == 0 || wrote_wtmp_rlevel
comparison so the latter is wrote_utmp_rlevel.

Simplified logic in mountpoint.c when testing for same device or same inode.

Thanks to David Binderman for pointing out the above three issues.
2018-03-30 22:15:04 -03:00
Jesse Smith
8c8172349e Updated mountpoint to search for circular mount points when using
the -p parameter. This works around mountpoint not recognizing
circular mounts where /a/b/c/d and /a/b are the same location
(ie the same device and same inode).
Closes Savannah bug #37114.
2018-03-07 16:25:53 -04:00
Jesse Smith
2e1f87635e Removed extra sleep() calls from shutting down process since we use
sync() anyway to pause and make sure data is written out to disk.
2018-02-22 21:07:51 -04:00
Jesse Smith
2b651b469e Fixed Clang compiler warning when calling sprintf() with
variable number of data parameters.
2018-02-21 18:05:58 -04:00
Jesse Smith
c6f29e96c0 Cleared up compiler warnings from unused variables and findtty()
function in bootlogd.c
2018-02-20 19:40:14 -04:00
Jesse Smith
1d24d576f1 Add fscanf checks to init.c to warn us if calls fail.
Mostly to clean up compiler warnings.
2018-02-20 19:38:40 -04:00
Jesse Smith
d21c8fc44b Perform error check on setuid() call in shutdown as manual page suggests. 2018-02-20 19:37:29 -04:00