[block-manager] ensure the superblock cannot be taken concurrently with any other lock.
This commit is contained in:
parent
3724f78a13
commit
0d3942cae8
@ -504,6 +504,12 @@ block_cache::get_nr_blocks() const
|
||||
return nr_data_blocks_;
|
||||
}
|
||||
|
||||
uint64_t
|
||||
block_cache::get_nr_locked() const
|
||||
{
|
||||
return nr_locked_;
|
||||
}
|
||||
|
||||
void
|
||||
block_cache::zero_block(block &b)
|
||||
{
|
||||
|
@ -119,6 +119,7 @@ namespace bcache {
|
||||
~block_cache();
|
||||
|
||||
uint64_t get_nr_blocks() const;
|
||||
uint64_t get_nr_locked() const;
|
||||
|
||||
enum get_flags {
|
||||
GF_ZERO = (1 << 0),
|
||||
|
@ -36,7 +36,6 @@
|
||||
namespace persistent_data {
|
||||
using namespace bcache;
|
||||
|
||||
|
||||
uint32_t const MD_BLOCK_SIZE = 4096;
|
||||
|
||||
template <uint32_t BlockSize = MD_BLOCK_SIZE>
|
||||
|
@ -268,6 +268,9 @@ namespace persistent_data {
|
||||
block_manager<BlockSize>::superblock(block_address location,
|
||||
typename bcache::validator::ptr v)
|
||||
{
|
||||
if (bc_.get_nr_locked() > 0)
|
||||
throw std::runtime_error("attempt to lock superblock while other locks are still held");
|
||||
|
||||
block_cache::block &b = bc_.get(location, block_cache::GF_BARRIER, v);
|
||||
return write_ref(b, superblock_ref_count_);
|
||||
}
|
||||
@ -277,6 +280,9 @@ namespace persistent_data {
|
||||
block_manager<BlockSize>::superblock_zero(block_address location,
|
||||
typename bcache::validator::ptr v)
|
||||
{
|
||||
if (bc_.get_nr_locked() > 0)
|
||||
throw std::runtime_error("attempt to lock superblock while other locks are still held");
|
||||
|
||||
block_cache::block &b = bc_.get(location, block_cache::GF_ZERO | block_cache::GF_BARRIER, v);
|
||||
return write_ref(b, superblock_ref_count_);
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user