From 1cfdcd58c5866fc661ef58cfebe2872eef820a82 Mon Sep 17 00:00:00 2001 From: Ming-Hung Tsai Date: Wed, 12 Aug 2020 08:29:16 +0800 Subject: [PATCH] [metadata_checker] Disable checking data block ref-counts due to performance concerns --- thin-provisioning/metadata_checker.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/thin-provisioning/metadata_checker.cc b/thin-provisioning/metadata_checker.cc index 23ce449..5a6eebb 100644 --- a/thin-provisioning/metadata_checker.cc +++ b/thin-provisioning/metadata_checker.cc @@ -388,8 +388,11 @@ namespace { print_info(tm, sb, info_out_); if (options_.sm_opts_ == check_options::SPACE_MAP_FULL) { + // data block reference counting is disabled + // until that there's a better solution in space + // and time complexity space_map::ptr data_sm{open_disk_sm(*tm, &sb.data_space_map_root_)}; - optional core_sm{create_core_map(data_sm->get_nr_blocks())}; + optional core_sm; err_ << examine_data_mappings(tm, sb, options_.data_mapping_opts_, out_, core_sm); if (err_ == FATAL) @@ -399,7 +402,7 @@ namespace { // then we should check the space maps too. err_ << examine_metadata_space_map(tm, sb, options_.sm_opts_, out_, expected_rc_); - // check the data space map + // verify ref-counts of data blocks if (err_ != FATAL && core_sm) err_ << compare_space_maps(data_sm, *core_sm, out_); } else