emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[thin_check (rust)] Make --sync-io the default.

Browse Source 
For some systems you have to adjust the ulimits to get io_uring
to work, so we now default to using sync io.

Also added --async-io flag.
This commit is contained in:
Joe Thornber 2020-12-02 11:33:05 +00:00
parent 0e4622f337
commit ba7fd7bd2b
1 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
src/bin/thin_check.rs
View File

@ -68,9 +68,14 @@ fn main() {
.required(true) .required(true)
.index(1), .index(1),
) )
.arg(
Arg::with_name("ASYNC_IO")
.help("Force use of io_uring for asynchronous IO")
.long("async-io"),
)
.arg( .arg(
Arg::with_name("SYNC_IO") Arg::with_name("SYNC_IO")
.help("Force use of synchronous io") .help("Force use of synchronous IO (currently the default)")
.long("sync-io"), .long("sync-io"),
); );
@ -92,9 +97,25 @@ fn main() {
report = Arc::new(mk_simple_report()); report = Arc::new(mk_simple_report());
} }
if matches.is_present("SYNC_IO") &&
matches.is_present("ASYNC_IO") {
eprintln!("--sync-io and --async-io may not be used at the same time.");
process::exit(1);
}
let mut async_io = false;
if matches.is_present("ASYNC_IO") {
async_io = true;
}
// redundant since sync is the default.
if matches.is_present("SYNC_IO") {
async_io = false;
}
let opts = ThinCheckOptions { let opts = ThinCheckOptions {
dev: &input_file, dev: &input_file,
async_io: !matches.is_present("SYNC_IO"), async_io: async_io,
sb_only: matches.is_present("SB_ONLY"), sb_only: matches.is_present("SB_ONLY"),
skip_mappings: matches.is_present("SKIP_MAPPINGS"), skip_mappings: matches.is_present("SKIP_MAPPINGS"),
ignore_non_fatal: matches.is_present("IGNORE_NON_FATAL"), ignore_non_fatal: matches.is_present("IGNORE_NON_FATAL"),
@ -103,7 +124,7 @@ fn main() {
}; };
if let Err(reason) = check(opts) { if let Err(reason) = check(opts) {
println!("{}", reason); eprintln!("{}", reason);
process::exit(1); process::exit(1);
} }
} }