emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[btree] Remove FIXMEs

Browse Source
This commit is contained in:
Ming-Hung Tsai 2021-03-25 16:42:36 +08:00
parent 8bfe7ee6f3
commit c496e8a4c8
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
persistent-data/data-structures/btree-remove.tcc
View File

@ -145,11 +145,11 @@ namespace persistent_data {
{ {
internal_node n = spine.get_node<block_traits>(); internal_node n = spine.get_node<block_traits>();
// compact the path if there's only one child
if (n.get_nr_entries() == 1) { if (n.get_nr_entries() == 1) {
block_address b = n.value_at(0); block_address b = n.value_at(0);
read_ref child = tm_.read_lock(b, validator_); read_ref child = tm_.read_lock(b, validator_);
// FIXME: is it safe?
::memcpy(n.raw(), child.data(), read_ref::BLOCK_SIZE); ::memcpy(n.raw(), child.data(), read_ref::BLOCK_SIZE);
tm_.get_sm()->dec(child.get_location()); tm_.get_sm()->dec(child.get_location());
@ -341,7 +341,6 @@ namespace persistent_data {
if (nr_left < nr_right) { if (nr_left < nr_right) {
int s = nr_left - target_left; int s = nr_left - target_left;
// FIXME: signed & unsigned comparison
if (s < 0 && nr_center < static_cast<unsigned>(-s)) { if (s < 0 && nr_center < static_cast<unsigned>(-s)) {
// not enough in central node // not enough in central node
left.move_entries(center, -nr_center); left.move_entries(center, -nr_center);