emo/thin-provisioning-tools
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[cache_dump/restore] Use base64 encoding for the hints

Browse Source
This commit is contained in:
Joe Thornber 2013-10-10 10:34:37 +01:00
parent a29b5c8d07
commit d5a93691e1
1 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
caching/xml_format.cc
View File

@ -1,3 +1,4 @@
#include "base/base64.h"
#include "caching/xml_format.h" #include "caching/xml_format.h"
#include <boost/lexical_cast.hpp> #include <boost/lexical_cast.hpp>
@ -11,15 +12,6 @@ using namespace std;
//---------------------------------------------------------------- //----------------------------------------------------------------
namespace { namespace {
// base64 encoding?
string encode(vector<unsigned char> const &data) {
return "";
}
vector<unsigned char> decode(string const &data) {
return vector<unsigned char>();
}
//-------------------------------- //--------------------------------
// Emitter // Emitter
//-------------------------------- //--------------------------------
@ -87,9 +79,11 @@ namespace {
virtual void hint(block_address cblock, virtual void hint(block_address cblock,
vector<unsigned char> const &data) { vector<unsigned char> const &data) {
using namespace base;
out_ << "<hint" out_ << "<hint"
<< " cache_block=\"" << cblock << "\"" << " cache_block=\"" << cblock << "\""
<< " data=\"" << encode(data) << "\"" << " data=\"" << base64_encode(data) << "\""
<< ">" << endl; << ">" << endl;
} }
@ -187,8 +181,18 @@ namespace {
} }
void parse_hint(emitter *e, attributes const &attr) { void parse_hint(emitter *e, attributes const &attr) {
e->hint(get_attr<uint64_t>(attr, "cache_block"), using namespace base;
decode(get_attr<string>(attr, "data")));
block_address cblock = get_attr<uint64_t>(attr, "cache_block");
decoded_or_error doe = base64_decode(get_attr<string>(attr, "data"));
if (!get<vector<unsigned char> >(&doe)) {
ostringstream msg;
msg << "invalid base64 encoding of hint for cache block "
<< cblock << ": " << get<string>(doe);
throw runtime_error(msg.str());
}
e->hint(cblock, get<vector<unsigned char> >(doe));
} }
void start_tag(void *data, char const *el, char const **attr) { void start_tag(void *data, char const *el, char const **attr) {