emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
9effec0c4e
xbps/lib/pkgdb.c

479 lines
11 KiB
C
Raw Normal View History

Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
/*-
Use shared LICENSE file for all xbps code.
2020-04-24 15:14:19 +05:30
* Licensed under the SPDX BSD-2-Clause identifier.
* Use is subject to license terms, as specified in the LICENSE file.
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
*/
#include <stdio.h>
#include <stdbool.h>
#include <stdlib.h>
#include <string.h>
#include <errno.h>
set umask for pkgdb creation/access so that pkgdb remains readable for world, even if xbps tools have been called with a very restrictive umask
2015-07-19 15:17:09 +05:30
#include <sys/types.h>
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
#include <sys/stat.h>
#include <fcntl.h>
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
Starting to clean up the public API, move private stuff into xbps_api_impl.h.
2010-11-13 07:48:58 +05:30
#include "xbps_api_impl.h"
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
Improve API documentation round 1.
2012-01-20 16:47:27 +05:30
/**
* @file lib/pkgdb.c
* @brief Package database handling routines
* @defgroup pkgdb Package database handling functions
*
* Functions to manipulate the main package database plist file (pkgdb).
*
* The following image shown below shows the proplib structure used
* by the main package database plist:
*
Update API documentation and dot files.
2013-09-25 14:45:04 +05:30
* @image html images/xbps_pkgdb_dictionary.png
Improve API documentation round 1.
2012-01-20 16:47:27 +05:30
*
* Legend:
Update API documentation and dot files.
2013-09-25 14:45:04 +05:30
* - <b>Salmon filled box</b>: \a pkgdb plist internalized.
Improve API documentation round 1.
2012-01-20 16:47:27 +05:30
* - <b>White filled box</b>: mandatory objects.
* - <b>Grey filled box</b>: optional objects.
* - <b>Green filled box</b>: possible value set in the object, only one
* of them is set.
*
* Text inside of white boxes are the key associated with the object, its
* data type is specified on its edge, i.e array, bool, integer, string,
* dictionary.
*/
lib/pkgdb.c: initialize pkgdb_fd. otherwise xbps_pkgdb_unlock will always succeed.
2019-06-23 14:35:03 +05:30
static int pkgdb_fd = -1;
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
static bool pkgdb_map_names_done = false;
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
int
xbps_pkgdb_lock(struct xbps_handle *xhp)
{
set umask for pkgdb creation/access so that pkgdb remains readable for world, even if xbps tools have been called with a very restrictive umask
2015-07-19 15:17:09 +05:30
mode_t prev_umask;
libxbps: sane umask for pkgdb and files plists
2017-02-27 22:32:39 +05:30
int rv = 0;
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
/*
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
* Use a mandatory file lock to only allow one writer to pkgdb,
* other writers will block.
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
*/
libxbps: sane umask for pkgdb and files plists
2017-02-27 22:32:39 +05:30
prev_umask = umask(022);
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
xhp->pkgdb_plist = xbps_xasprintf("%s/%s", xhp->metadir, XBPS_PKGDB);
if (xbps_pkgdb_init(xhp) == ENOENT) {
/* if metadir does not exist, create it */
if (access(xhp->metadir, R_OK|X_OK) == -1) {
libxbps: sane umask for pkgdb and files plists
2017-02-27 22:32:39 +05:30
if (errno != ENOENT) {
rv = errno;
goto ret;
}
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
if (xbps_mkpath(xhp->metadir, 0755) == -1) {
rv = errno;
xbps_dbg_printf(xhp, "[pkgdb] failed to create metadir "
"%s: %s\n", xhp->metadir, strerror(rv));
libxbps: sane umask for pkgdb and files plists
2017-02-27 22:32:39 +05:30
goto ret;
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
}
}
/* if pkgdb is unexistent, create it with an empty dictionary */
xhp->pkgdb = xbps_dictionary_create();
Switch back to uncompressed plists. There's no point in slowing down read performance just to save a few bytes.
2014-10-24 13:45:41 +05:30
if (!xbps_dictionary_externalize_to_file(xhp->pkgdb, xhp->pkgdb_plist)) {
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
rv = errno;
xbps_dbg_printf(xhp, "[pkgdb] failed to create pkgdb "
"%s: %s\n", xhp->pkgdb_plist, strerror(rv));
libxbps: sane umask for pkgdb and files plists
2017-02-27 22:32:39 +05:30
goto ret;
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
}
}
set umask for pkgdb creation/access so that pkgdb remains readable for world, even if xbps tools have been called with a very restrictive umask
2015-07-19 15:17:09 +05:30
libxbps: open fds with O_CLOEXEC to avoid warnings of leaked fds.
2015-04-16 00:32:38 +05:30
if ((pkgdb_fd = open(xhp->pkgdb_plist, O_CREAT|O_RDWR|O_CLOEXEC, 0664)) == -1) {
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
rv = errno;
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
xbps_dbg_printf(xhp, "[pkgdb] cannot open pkgdb for locking "
"%s: %s\n", xhp->pkgdb_plist, strerror(rv));
free(xhp->pkgdb_plist);
libxbps: sane umask for pkgdb and files plists
2017-02-27 22:32:39 +05:30
goto ret;
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
}
set umask for pkgdb creation/access so that pkgdb remains readable for world, even if xbps tools have been called with a very restrictive umask
2015-07-19 15:17:09 +05:30
xbps_pkgdb_lock(): check if rootfs is writable. As shown in https://github.com/void-linux/xbps/issues/110 /var might be rw, while / might be ro. Check this via xbps_pkgdb_lock() for both things. Close #110 Signed-off-by: Juan RP <xtraeme@gmail.com>
2019-06-13 20:34:32 +05:30
/*
* If we've acquired the file lock, then pkgdb is writable.
*/
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
if (lockf(pkgdb_fd, F_TLOCK, 0) == -1) {
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
rv = errno;
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
xbps_dbg_printf(xhp, "[pkgdb] cannot lock pkgdb: %s\n", strerror(rv));
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
}
xbps_pkgdb_lock(): check if rootfs is writable. As shown in https://github.com/void-linux/xbps/issues/110 /var might be rw, while / might be ro. Check this via xbps_pkgdb_lock() for both things. Close #110 Signed-off-by: Juan RP <xtraeme@gmail.com>
2019-06-13 20:34:32 +05:30
/*
* Check if rootdir is writable.
*/
if (access(xhp->rootdir, W_OK) == -1) {
rv = errno;
xbps_dbg_printf(xhp, "[pkgdb] rootdir %s: %s\n", xhp->rootdir, strerror(rv));
}
libxbps: sane umask for pkgdb and files plists
2017-02-27 22:32:39 +05:30
ret:
umask(prev_umask);
return rv;
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
}
void
xbps_pkgdb_unlock(struct xbps_handle *xhp)
{
pkgdb: fix two issues in _update() and _release(). xbps_pkgdb_update: inverted condition that made it 'flush' when !flush. xbps_pkgdb_release: xhp->pkgdb might be NULL, but unlock pkgdb anyway.
2019-06-22 22:17:13 +05:30
xbps_dbg_printf(xhp, "%s: pkgdb_fd %d\n", __func__, pkgdb_fd);
Improve xbps_end() and use it before exit(3)ing. - Simplify xbps_repo_open::repo_get_dict(). - Use xbps_end() in the utils where necessary. - Make xbps_end() call xbps_pkgdb_unlock() if necessary. - Make xbps_end() release rpool resources. - Make xbps_end() release resources from xbps_handle. - Fixed 90% of reported leaks (still reachable at exit) from valgrind. That was to silence valgrind's memcheck with --leak-check=full.
2015-01-10 23:41:31 +05:30
if (pkgdb_fd != -1) {
if (lockf(pkgdb_fd, F_ULOCK, 0) == -1)
xbps_dbg_printf(xhp, "[pkgdb] failed to unlock pkgdb: %s\n", strerror(errno));
Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points. - Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
2014-03-04 19:07:10 +05:30
Improve xbps_end() and use it before exit(3)ing. - Simplify xbps_repo_open::repo_get_dict(). - Use xbps_end() in the utils where necessary. - Make xbps_end() call xbps_pkgdb_unlock() if necessary. - Make xbps_end() release rpool resources. - Make xbps_end() release resources from xbps_handle. - Fixed 90% of reported leaks (still reachable at exit) from valgrind. That was to silence valgrind's memcheck with --leak-check=full.
2015-01-10 23:41:31 +05:30
(void)close(pkgdb_fd);
pkgdb_fd = -1;
}
Fix concurrency issues in pkgdb: only allow 1 write transaction at the same time. This implementation relies on a POSIX named semaphore, which is also required by xbps-rindex(8).
2014-02-23 12:53:14 +05:30
}
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
static int
pkgdb_map_vpkgs(struct xbps_handle *xhp)
{
xbps_object_iterator_t iter;
xbps_object_t obj;
int rv = 0;
if (!xbps_dictionary_count(xhp->pkgdb))
return 0;
if (xhp->vpkgd == NULL) {
xhp->vpkgd = xbps_dictionary_create();
assert(xhp->vpkgd);
}
/*
* This maps all pkgs that have virtualpkgs in pkgdb.
*/
iter = xbps_dictionary_iterator(xhp->pkgdb);
assert(iter);
while ((obj = xbps_object_iterator_next(iter))) {
xbps_array_t provides;
xbps_dictionary_t pkgd;
Added LTO support and fix warnings (maybe-uninitialized).
2019-06-27 20:39:43 +05:30
const char *pkgver = NULL;
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
char pkgname[XBPS_NAME_SIZE] = {0};
unsigned int cnt;
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
pkgd = xbps_dictionary_get_keysym(xhp->pkgdb, obj);
provides = xbps_dictionary_get(pkgd, "provides");
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
cnt = xbps_array_count(provides);
if (!cnt)
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
continue;
xbps_dictionary_get_cstring_nocopy(pkgd, "pkgver", &pkgver);
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
if (!xbps_pkg_name(pkgname, sizeof(pkgname), pkgver)) {
rv = EINVAL;
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
goto out;
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
}
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
for (unsigned int i = 0; i < cnt; i++) {
Added LTO support and fix warnings (maybe-uninitialized).
2019-06-27 20:39:43 +05:30
const char *vpkg = NULL;
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
xbps_array_get_cstring_nocopy(provides, i, &vpkg);
if (!xbps_dictionary_set_cstring(xhp->vpkgd, vpkg, pkgname)) {
xbps_dbg_printf(xhp, "%s: set_cstring vpkg "
"%s pkgname %s\n", __func__, vpkg, pkgname);
rv = EINVAL;
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
goto out;
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
}
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
xbps_dbg_printf(xhp, "[pkgdb] added vpkg %s for %s\n", vpkg, pkgname);
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
}
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
}
out:
xbps_object_iterator_release(iter);
return rv;
}
static int
pkgdb_map_names(struct xbps_handle *xhp)
{
xbps_object_iterator_t iter;
xbps_object_t obj;
int rv = 0;
if (pkgdb_map_names_done || !xbps_dictionary_count(xhp->pkgdb))
return 0;
/*
* This maps all pkgs in pkgdb to have the "pkgname" string property.
* This way we do it once and not multiple times.
*/
iter = xbps_dictionary_iterator(xhp->pkgdb);
assert(iter);
while ((obj = xbps_object_iterator_next(iter))) {
xbps_dictionary_t pkgd;
const char *pkgver;
char pkgname[XBPS_NAME_SIZE] = {0};
pkgd = xbps_dictionary_get_keysym(xhp->pkgdb, obj);
if (!xbps_dictionary_get_cstring_nocopy(pkgd, "pkgver", &pkgver)) {
continue;
}
if (!xbps_pkg_name(pkgname, sizeof(pkgname), pkgver)) {
rv = EINVAL;
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
break;
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
}
if (!xbps_dictionary_set_cstring(pkgd, "pkgname", pkgname)) {
rv = EINVAL;
break;
}
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
}
xbps_object_iterator_release(iter);
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
if (!rv) {
pkgdb_map_names_done = true;
}
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
return rv;
}
XBPS major changes in June 2011. - A configuration file "xbps-conf.plist" replaces the (un)register target in xbps-repo(8) and (un)set-prop in xbps-bin(8). For now, you can set the repositories and prefered virtual packages. - New package pattern matching code from NetBSD. Supports more ways of matching patterns in packages. - Multiple bugs fixed in virtual packages related matching code. --HG-- rename : LICENSE => COPYING
2011-06-04 17:07:53 +05:30
int HIDDEN
regpkgdb rototill: renamed to pkgdb, improve the public API.
2012-01-20 15:40:52 +05:30
xbps_pkgdb_init(struct xbps_handle *xhp)
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
{
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
int rv;
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
assert(xhp);
if (xhp->pkgdb)
return 0;
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
if (!xhp->pkgdb_plist)
xbps_pkgdb_init: initialize xhp->pkgdb_plist if it wasn't before.
2014-03-04 19:29:58 +05:30
xhp->pkgdb_plist = xbps_xasprintf("%s/%s", xhp->metadir, XBPS_PKGDB);
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
pkgdb: disable pkgdb conversion code; 0.38 was released long ago.
2015-01-10 23:56:37 +05:30
#if 0
Welcome pkgdb-0.38.
2014-09-11 03:42:12 +05:30
if ((rv = xbps_pkgdb_conversion(xhp)) != 0)
return rv;
pkgdb: disable pkgdb conversion code; 0.38 was released long ago.
2015-01-10 23:56:37 +05:30
#endif
Welcome pkgdb-0.38.
2014-09-11 03:42:12 +05:30
xbps_pkgdb_update: added 3rd bool arg "update", not update in memory pkgdb. If true, the in memory pkgdb dict will be updated with data from the on-disk pkgdb.
2015-01-11 00:12:09 +05:30
if ((rv = xbps_pkgdb_update(xhp, false, true)) != 0) {
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
if (rv != ENOENT)
libxbps: require a pointer to xbps_handle in functions that need it. This removes 2 global vars from lib/initend.c and easier to know what functions require access to xbps_handle.
2012-06-14 11:52:11 +05:30
xbps_dbg_printf(xhp, "[pkgdb] cannot internalize "
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
"pkgdb dictionary: %s\n", strerror(rv));
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
return rv;
}
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
if ((rv = pkgdb_map_names(xhp)) != 0) {
xbps_dbg_printf(xhp, "[pkgdb] pkgdb_map_names %s\n", strerror(rv));
return rv;
}
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
if ((rv = pkgdb_map_vpkgs(xhp)) != 0) {
xbps_dbg_printf(xhp, "[pkgdb] pkgdb_map_vpkgs %s\n", strerror(rv));
return rv;
}
Alternatives framework for xbps (2/2). See xbps-alternatives(1) for more information. Thanks to all who helped to design this and for fixing grammar in the manual page.
2015-10-30 16:54:46 +05:30
assert(xhp->pkgdb);
libxbps: require a pointer to xbps_handle in functions that need it. This removes 2 global vars from lib/initend.c and easier to know what functions require access to xbps_handle.
2012-06-14 11:52:11 +05:30
xbps_dbg_printf(xhp, "[pkgdb] initialized ok.\n");
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
return 0;
}
int
xbps_pkgdb_update: added 3rd bool arg "update", not update in memory pkgdb. If true, the in memory pkgdb dict will be updated with data from the on-disk pkgdb.
2015-01-11 00:12:09 +05:30
xbps_pkgdb_update(struct xbps_handle *xhp, bool flush, bool update)
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
{
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_dictionary_t pkgdb_storage;
lib/pkgdb.c: set a sane umask for pkgdb plist
2017-02-27 22:54:46 +05:30
mode_t prev_umask;
libxbps: performance improvements by caching the most accessed paths. 1- We can cache the result of the first xbps_pkgdb_init() when it fails and avoid the malloc/free/access from it. 2- We cache the uname(2) result into a private var in xbps_handle and use it in xbps_pkg_arch_match(). This improves performance by ~5% approx and it's close as it was before introducing the repository index format 1.5.
2012-06-15 19:03:11 +05:30
static int cached_rv;
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
int rv = 0;
libxbps: performance improvements by caching the most accessed paths. 1- We can cache the result of the first xbps_pkgdb_init() when it fails and avoid the malloc/free/access from it. 2- We cache the uname(2) result into a private var in xbps_handle and use it in xbps_pkg_arch_match(). This improves performance by ~5% approx and it's close as it was before introducing the repository index format 1.5.
2012-06-15 19:03:11 +05:30
if (cached_rv && !flush)
return cached_rv;
pkgdb: fix two issues in _update() and _release(). xbps_pkgdb_update: inverted condition that made it 'flush' when !flush. xbps_pkgdb_release: xhp->pkgdb might be NULL, but unlock pkgdb anyway.
2019-06-22 22:17:13 +05:30
if (xhp->pkgdb && flush) {
Fixed a regression in vpkgs and improve xbps.d(5) virtualpkg declarations. See the NEWS file for more information.
2014-12-31 13:21:45 +05:30
pkgdb_storage = xbps_dictionary_internalize_from_file(xhp->pkgdb_plist);
pkgdb: some fixes for e545429fa1f7eb10c347282ea747c841b705e0c3.
2012-10-26 14:35:17 +05:30
if (pkgdb_storage == NULL ||
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
!xbps_dictionary_equals(xhp->pkgdb, pkgdb_storage)) {
pkgdb: if plist from storage and memory do not differ do not flush to storage.
2012-10-26 13:55:14 +05:30
/* flush dictionary to storage */
lib/pkgdb.c: set a sane umask for pkgdb plist
2017-02-27 22:54:46 +05:30
prev_umask = umask(022);
if (!xbps_dictionary_externalize_to_file(xhp->pkgdb, xhp->pkgdb_plist)) {
umask(prev_umask);
pkgdb: if plist from storage and memory do not differ do not flush to storage.
2012-10-26 13:55:14 +05:30
return errno;
lib/pkgdb.c: set a sane umask for pkgdb plist
2017-02-27 22:54:46 +05:30
}
umask(prev_umask);
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
}
pkgdb: some fixes for e545429fa1f7eb10c347282ea747c841b705e0c3.
2012-10-26 14:35:17 +05:30
if (pkgdb_storage)
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_object_release(pkgdb_storage);
pkgdb: some fixes for e545429fa1f7eb10c347282ea747c841b705e0c3.
2012-10-26 14:35:17 +05:30
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_object_release(xhp->pkgdb);
regpkgdb rototill: renamed to pkgdb, improve the public API.
2012-01-20 15:40:52 +05:30
xhp->pkgdb = NULL;
libxbps: performance improvements by caching the most accessed paths. 1- We can cache the result of the first xbps_pkgdb_init() when it fails and avoid the malloc/free/access from it. 2- We cache the uname(2) result into a private var in xbps_handle and use it in xbps_pkg_arch_match(). This improves performance by ~5% approx and it's close as it was before introducing the repository index format 1.5.
2012-06-15 19:03:11 +05:30
cached_rv = 0;
libxbps: regpkgdb: use a mutex for {inc,dec}rementing the refcnt.
2011-01-19 00:48:27 +05:30
}
xbps_pkgdb_update: added 3rd bool arg "update", not update in memory pkgdb. If true, the in memory pkgdb dict will be updated with data from the on-disk pkgdb.
2015-01-11 00:12:09 +05:30
if (!update)
return rv;
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
/* update copy in memory */
Fixed a regression in vpkgs and improve xbps.d(5) virtualpkg declarations. See the NEWS file for more information.
2014-12-31 13:21:45 +05:30
if ((xhp->pkgdb = xbps_dictionary_internalize_from_file(xhp->pkgdb_plist)) == NULL) {
xbps_pkgdb_update: return EINVAL if pkgdb cannot be internalized.
2015-05-22 15:48:54 +05:30
rv = errno;
if (!rv)
rv = EINVAL;
if (rv == ENOENT)
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xhp->pkgdb = xbps_dictionary_create();
lib/pkgdb.c: print to stderr a meaningful msg on error.
2013-01-15 17:44:30 +05:30
else
xbps_pkgdb_update: return EINVAL if pkgdb cannot be internalized.
2015-05-22 15:48:54 +05:30
xbps_error_printf("cannot access to pkgdb: %s\n", strerror(rv));
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
xbps_pkgdb_update: if pkgdb cannot be internalized, create it to simplify code.
2012-11-11 14:33:14 +05:30
cached_rv = rv = errno;
}
libxbps: regpkgdb: use a mutex for {inc,dec}rementing the refcnt.
2011-01-19 00:48:27 +05:30
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
return rv;
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
}
XBPS major changes in June 2011. - A configuration file "xbps-conf.plist" replaces the (un)register target in xbps-repo(8) and (un)set-prop in xbps-bin(8). For now, you can set the repositories and prefered virtual packages. - New package pattern matching code from NetBSD. Supports more ways of matching patterns in packages. - Multiple bugs fixed in virtual packages related matching code. --HG-- rename : LICENSE => COPYING
2011-06-04 17:07:53 +05:30
void HIDDEN
regpkgdb rototill: renamed to pkgdb, improve the public API.
2012-01-20 15:40:52 +05:30
xbps_pkgdb_release(struct xbps_handle *xhp)
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
{
pkgdb: fix two issues in _update() and _release(). xbps_pkgdb_update: inverted condition that made it 'flush' when !flush. xbps_pkgdb_release: xhp->pkgdb might be NULL, but unlock pkgdb anyway.
2019-06-22 22:17:13 +05:30
assert(xhp);
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
Improve xbps_end() and use it before exit(3)ing. - Simplify xbps_repo_open::repo_get_dict(). - Use xbps_end() in the utils where necessary. - Make xbps_end() call xbps_pkgdb_unlock() if necessary. - Make xbps_end() release rpool resources. - Make xbps_end() release resources from xbps_handle. - Fixed 90% of reported leaks (still reachable at exit) from valgrind. That was to silence valgrind's memcheck with --leak-check=full.
2015-01-10 23:41:31 +05:30
xbps_pkgdb_unlock(xhp);
pkgdb: fix two issues in _update() and _release(). xbps_pkgdb_update: inverted condition that made it 'flush' when !flush. xbps_pkgdb_release: xhp->pkgdb might be NULL, but unlock pkgdb anyway.
2019-06-22 22:17:13 +05:30
if (xhp->pkgdb)
xbps_object_release(xhp->pkgdb);
libxbps: require a pointer to xbps_handle in functions that need it. This removes 2 global vars from lib/initend.c and easier to know what functions require access to xbps_handle.
2012-06-14 11:52:11 +05:30
xbps_dbg_printf(xhp, "[pkgdb] released ok.\n");
Major changes in libxbps to implement caching in some cases. libxbps: - Moved repolist code to lib/repository_pool.c. - Renamed xbps_{prepare,release}_repolist_data() to xbps_repository_pool_{init,release} respectively. - Moved regpkgdb dict code to lib/regpkgs_dictionary.c. - Renamed xbps_{prepare,release}_regpkgdb_dict() to xbps_regpkgs_dictionary_{init,release} respectively. - Use a global reference count for repository_pool and regpkgs_dictionary, this gives a substantial performance gain while looking for dependencies in repository pool, among other things. - Make xbps_find_pkg_* functions return errno and use it to detect for spurious errors in code using them. - Add code to detect when a dependency is already unpacked. xbps-bin: - Do not set pkg state to unpacked in the transaction, it's set already while a package is unpacked. - While installing or updating packages, it now knows when a dependency is already unpacked and shows it as "unconfigured". Bump XBPS_RELVER to 20091126. --HG-- extra : convert_revision : xtraeme%40gmail.com-20091126022250-uu8x0fa86l4scb5x
2009-11-26 07:52:50 +05:30
}
Introduce xbps_regpkgdb_foreach_pkg_cb() and use it in xbps-bin check.
2011-12-22 18:55:27 +05:30
Introduce regpkgdb_foreach_reverse_pkg_cb, switch to regpkgdb_foreach_xxx.
2011-12-23 12:46:25 +05:30
int
libxbps: require a pointer to xbps_handle in functions that need it. This removes 2 global vars from lib/initend.c and easier to know what functions require access to xbps_handle.
2012-06-14 11:52:11 +05:30
xbps_pkgdb_foreach_cb(struct xbps_handle *xhp,
Introduce xbps_array_foreach_cb() and use it in random code. This routine will spawn a thread per core to process N items stored in the specified array, the last thread gets the remainder of items left. Results have shown that xbps benefits if there is a considerable amount of items and number of threads being spawned. Use it in xbps_pkgdb_foreach_cb(), xbps-pkgdb(8), xbps-query(8) and xbps-rindex(8). On UP systems there's no overhead because pthread(3) is not used at all. WIP! investigate if it can be used in libxbps (xbps_rpool_foreach()), and finish conversion of xbps-rindex(8) -c.
2013-07-27 13:17:16 +05:30
int (*fn)(struct xbps_handle *, xbps_object_t, const char *, void *, bool *),
void *arg)
Introduce regpkgdb_foreach_reverse_pkg_cb, switch to regpkgdb_foreach_xxx.
2011-12-23 12:46:25 +05:30
{
Introduce xbps_array_foreach_cb() and use it in random code. This routine will spawn a thread per core to process N items stored in the specified array, the last thread gets the remainder of items left. Results have shown that xbps benefits if there is a considerable amount of items and number of threads being spawned. Use it in xbps_pkgdb_foreach_cb(), xbps-pkgdb(8), xbps-query(8) and xbps-rindex(8). On UP systems there's no overhead because pthread(3) is not used at all. WIP! investigate if it can be used in libxbps (xbps_rpool_foreach()), and finish conversion of xbps-rindex(8) -c.
2013-07-27 13:17:16 +05:30
xbps_array_t allkeys;
New pkgdb (0.21) and repo index (1.7) format, see NEWS for info.
2013-03-05 08:38:42 +05:30
int rv;
if ((rv = xbps_pkgdb_init(xhp)) != 0)
return rv;
Introduce xbps_array_foreach_cb() and use it in random code. This routine will spawn a thread per core to process N items stored in the specified array, the last thread gets the remainder of items left. Results have shown that xbps benefits if there is a considerable amount of items and number of threads being spawned. Use it in xbps_pkgdb_foreach_cb(), xbps-pkgdb(8), xbps-query(8) and xbps-rindex(8). On UP systems there's no overhead because pthread(3) is not used at all. WIP! investigate if it can be used in libxbps (xbps_rpool_foreach()), and finish conversion of xbps-rindex(8) -c.
2013-07-27 13:17:16 +05:30
allkeys = xbps_dictionary_all_keys(xhp->pkgdb);
assert(allkeys);
rv = xbps_array_foreach_cb(xhp, allkeys, xhp->pkgdb, fn, arg);
xbps_object_release(allkeys);
New pkgdb (0.21) and repo index (1.7) format, see NEWS for info.
2013-03-05 08:38:42 +05:30
return rv;
Introduce regpkgdb_foreach_reverse_pkg_cb, switch to regpkgdb_foreach_xxx.
2011-12-23 12:46:25 +05:30
}
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
Introduce xbps_{array,pkgdb}_foreach_cb_multi() and use it where appropiate. In some tasks the single threaded implementation outperms the multithreaded one. Use it where it really makes a difference. The _multi() routines do not spawn any thread if _SC_NPROCESSORS_ONLN == 1. Bump XBPS_API_VERSION.
2013-09-17 20:00:13 +05:30
int
xbps_pkgdb_foreach_cb_multi(struct xbps_handle *xhp,
int (*fn)(struct xbps_handle *, xbps_object_t, const char *, void *, bool *),
void *arg)
{
xbps_array_t allkeys;
int rv;
if ((rv = xbps_pkgdb_init(xhp)) != 0)
return rv;
allkeys = xbps_dictionary_all_keys(xhp->pkgdb);
assert(allkeys);
rv = xbps_array_foreach_cb_multi(xhp, allkeys, xhp->pkgdb, fn, arg);
xbps_object_release(allkeys);
return rv;
}
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_dictionary_t
Major API/ABI cleanup bringing performance improvements and fixes. These are the core interfaces in the new API: rpool - Interface to interact with the repository pool. rindex - Interface to interact with repository indexes. pkgdb - Interface to interact with local packages. transaction - Interface to interact with a transaction. This also brings new repository index format, making the index file per architecture and being incompatible with previous versions. The transaction frequency flush option has been removed, and due to the nature of package states it was causing more harm than good. More changes coming soon, but the API shall remain stable from now on.
2012-11-30 11:41:51 +05:30
xbps_pkgdb_get_pkg(struct xbps_handle *xhp, const char *pkg)
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
{
regpkgdb rototill: renamed to pkgdb, improve the public API.
2012-01-20 15:40:52 +05:30
if (xbps_pkgdb_init(xhp) != 0)
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
return NULL;
New pkgdb (0.21) and repo index (1.7) format, see NEWS for info.
2013-03-05 08:38:42 +05:30
return xbps_find_pkg_in_dict(xhp->pkgdb, pkg);
Merged purge code in remove, configurable transaction regpkgdb flushing. See the NEWS file for info.
2011-12-24 05:35:26 +05:30
}
Introduce xbps_regpkgdb_remove_pkgd, and use regpkgdb funcs to make xbps-uhelper work.
2011-12-24 20:39:30 +05:30
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_dictionary_t
Major API/ABI cleanup bringing performance improvements and fixes. These are the core interfaces in the new API: rpool - Interface to interact with the repository pool. rindex - Interface to interact with repository indexes. pkgdb - Interface to interact with local packages. transaction - Interface to interact with a transaction. This also brings new repository index format, making the index file per architecture and being incompatible with previous versions. The transaction frequency flush option has been removed, and due to the nature of package states it was causing more harm than good. More changes coming soon, but the API shall remain stable from now on.
2012-11-30 11:41:51 +05:30
xbps_pkgdb_get_virtualpkg(struct xbps_handle *xhp, const char *vpkg)
Introduce xbps_pkgdb_get_virtualpkgd() and use in xbps_metadir_get_pkgd().
2012-11-20 02:16:54 +05:30
{
if (xbps_pkgdb_init(xhp) != 0)
return NULL;
New pkgdb (0.21) and repo index (1.7) format, see NEWS for info.
2013-03-05 08:38:42 +05:30
return xbps_find_virtualpkg_in_dict(xhp, xhp->pkgdb, vpkg);
Introduce xbps_pkgdb_get_virtualpkgd() and use in xbps_metadir_get_pkgd().
2012-11-20 02:16:54 +05:30
}
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
static void
generate_full_revdeps_tree(struct xbps_handle *xhp)
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
{
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_object_t obj;
xbps_object_iterator_t iter;
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
if (xhp->pkgdb_revdeps)
return;
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xhp->pkgdb_revdeps = xbps_dictionary_create();
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
assert(xhp->pkgdb_revdeps);
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
iter = xbps_dictionary_iterator(xhp->pkgdb);
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
assert(iter);
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
while ((obj = xbps_object_iterator_next(iter))) {
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
xbps_array_t rundeps;
xbps_dictionary_t pkgd;
Added LTO support and fix warnings (maybe-uninitialized).
2019-06-27 20:39:43 +05:30
const char *pkgver = NULL;
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
pkgd = xbps_dictionary_get_keysym(xhp->pkgdb, obj);
rundeps = xbps_dictionary_get(pkgd, "run_depends");
if (!xbps_array_count(rundeps))
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
continue;
libxbps: detection of orphaned packages is now 66% faster.
2015-01-10 10:13:35 +05:30
xbps_dictionary_get_cstring_nocopy(pkgd, "pkgver", &pkgver);
Use C99 for loop initializers. That means that a C99 compiler is now mandatory.
2013-09-15 13:36:49 +05:30
for (unsigned int i = 0; i < xbps_array_count(rundeps); i++) {
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
xbps_array_t pkg;
Added LTO support and fix warnings (maybe-uninitialized).
2019-06-27 20:39:43 +05:30
const char *pkgdep = NULL, *vpkgname = NULL;
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
char *v, curpkgname[XBPS_NAME_SIZE];
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). Binary packages do not need to provide those virtualpkg configuration files anymore; all vpkg info is now collected from pkgdb.
2014-11-04 15:47:27 +05:30
bool alloc = false;
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_array_get_cstring_nocopy(rundeps, i, &pkgdep);
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
if ((!xbps_pkgpattern_name(curpkgname, sizeof(curpkgname), pkgdep)) &&
(!xbps_pkg_name(curpkgname, sizeof(curpkgname), pkgdep))) {
abort();
}
Fix 29765271e correctly. xbps_find_virtualpkg_in_conf() needs to look at the vpkgs set up in configuration files, not from those set by pkgdb. As a result of this the two test cases that were failing yesterday are now fixed.
2016-03-24 14:53:20 +05:30
vpkgname = vpkg_user_conf(xhp, curpkgname, false);
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
if (vpkgname == NULL) {
v = strdup(curpkgname);
} else {
v = strdup(vpkgname);
}
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
pkg = xbps_dictionary_get(xhp->pkgdb_revdeps, v);
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
if (pkg == NULL) {
alloc = true;
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
pkg = xbps_array_create();
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
}
pkgdb: do not add dups in revdeps generation; remove old code.
2013-03-10 13:28:37 +05:30
if (!xbps_match_string_in_array(pkg, pkgver)) {
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_array_add_cstring_nocopy(pkg, pkgver);
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
xbps_dictionary_set(xhp->pkgdb_revdeps, v, pkg);
pkgdb: do not add dups in revdeps generation; remove old code.
2013-03-10 13:28:37 +05:30
}
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
free(v);
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
if (alloc)
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_object_release(pkg);
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
}
}
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_object_iterator_release(iter);
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
}
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_array_t
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
xbps_pkgdb_get_pkg_revdeps(struct xbps_handle *xhp, const char *pkg)
{
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_dictionary_t pkgd;
Added LTO support and fix warnings (maybe-uninitialized).
2019-06-27 20:39:43 +05:30
const char *pkgver = NULL;
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
char pkgname[XBPS_NAME_SIZE];
Faster generation of dynamic reverse dependencies and do this exactly once.
2012-12-15 12:03:49 +05:30
if ((pkgd = xbps_pkgdb_get_pkg(xhp, pkg)) == NULL)
return NULL;
generate_full_revdeps_tree(xhp);
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_dictionary_get_cstring_nocopy(pkgd, "pkgver", &pkgver);
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
if (!xbps_pkg_name(pkgname, sizeof(pkgname), pkgver))
lib/pkgdb.c: CID 62719 (NULL pointer dereference)
2014-10-07 11:27:38 +05:30
return NULL;
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
return xbps_dictionary_get(xhp->pkgdb_revdeps, pkgname);
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
}
Introduce xbps_{pkgdb,rpool}_get_pkg_fulldeptree(). These routines return a xbps_array_t with a full sorted dependency graph for the target pkg, by querying pkgdb or rpool. Update xbps-query(8) to use the new libxbps API.
2014-11-20 13:53:51 +05:30
xbps_array_t
xbps_pkgdb_get_pkg_fulldeptree(struct xbps_handle *xhp, const char *pkg)
{
return xbps_get_pkg_fulldeptree(xhp, pkg, false);
}
Get rid of libfetch and proplib external dependencies. The list of required external deps is now confuse, libarchive and openssl. libxbps now includes a wrapper for proplib prefixed with xbps_ rather than prop_.
2013-06-20 13:56:12 +05:30
xbps_dictionary_t
Welcome pkgdb-0.38.
2014-09-11 03:42:12 +05:30
xbps_pkgdb_get_pkg_files(struct xbps_handle *xhp, const char *pkg)
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
{
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
xbps_dictionary_t pkgd;
Added LTO support and fix warnings (maybe-uninitialized).
2019-06-27 20:39:43 +05:30
const char *pkgver = NULL;
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
char pkgname[XBPS_NAME_SIZE], plist[PATH_MAX];
xbps_pkgdb_get_pkg_metadata: avoid an extra function call.
2013-12-08 12:37:10 +05:30
if (pkg == NULL)
return NULL;
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
pkgd = xbps_pkgdb_get_pkg(xhp, pkg);
if (pkgd == NULL)
return NULL;
xbps_pkgdb_get_pkg_metadata: avoid an extra function call.
2013-12-08 12:37:10 +05:30
xbps_dictionary_get_cstring_nocopy(pkgd, "pkgver", &pkgver);
libxbps: ABI/API break due to xbps_pkg{,pattern}_name changes. The funcs xbps_pkg_name() and xbps_pkgpattern_name() were using malloc(3) to return the result, until now. They now have been changed to not allocate the result via malloc, the caller is responsible to provide a buffer at least of XBPS_NAME_SIZE (64). If for whatever reason the pkgname can't be guessed, returns false. This should avoid lots of small allocs around libxbps. New functions have the following prototype: bool xbps_pkg_name(char *dst, size_t len, const char *pkg) bool xbps_pkgpattern_name(char *dst, size_t len, const char *pkg) as suggested by @duncaen.
2020-02-09 00:01:29 +05:30
if (!xbps_pkg_name(pkgname, sizeof(pkgname), pkgver))
return NULL;
xbps_pkgdb_get_pkg_metadata: avoid an extra function call.
2013-12-08 12:37:10 +05:30
xbps_transaction_*: multiple performance improvements (v2). This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
2020-02-21 13:38:22 +05:30
snprintf(plist, sizeof(plist)-1, "%s/.%s-files.plist", xhp->metadir, pkgname);
return xbps_plist_dictionary_from_file(xhp, plist);
Added support for dynamic generation of revdeps for installed packages.
2012-11-30 22:10:52 +05:30
}
Reference in New Issue Copy Permalink