Use a POSIX lock for pkgdb and only issue pkgdb writes in exact points.
- Rather than using a POSIX named semaphore use a POSIX lock (lockf(3)) for pkgdb for writers. Writers that cannot acquire the pkgdb lock will get EAGAIN rather then being blocked. - Due to using a file lock we cannot write the pkgdb every time a package is being unpacked, configured or removed. Instead pkgdb is only written at the end of a specific point in the transaction (unpack, configure, remove) or via xbps_pkgdb_unlock().
This commit is contained in:
@@ -153,17 +153,22 @@ main(int argc, char **argv)
|
||||
exit(EXIT_FAILURE);
|
||||
}
|
||||
|
||||
if (all) {
|
||||
rv = xbps_configure_packages(&xh, true);
|
||||
} else {
|
||||
for (i = optind; i < argc; i++) {
|
||||
rv = xbps_configure_pkg(&xh, argv[i],
|
||||
true, false, true);
|
||||
if (rv != 0)
|
||||
fprintf(stderr, "Failed to reconfigure "
|
||||
"`%s': %s\n", argv[i], strerror(rv));
|
||||
}
|
||||
if ((rv = xbps_pkgdb_lock(&xh)) != 0) {
|
||||
fprintf(stderr, "failed to lock pkgdb: %s\n", strerror(rv));
|
||||
exit(EXIT_FAILURE);
|
||||
}
|
||||
|
||||
if (all) {
|
||||
rv = xbps_configure_packages(&xh);
|
||||
} else {
|
||||
for (i = optind; i < argc; i++) {
|
||||
rv = xbps_configure_pkg(&xh, argv[i], true, false);
|
||||
if (rv != 0) {
|
||||
fprintf(stderr, "Failed to reconfigure "
|
||||
"`%s': %s\n", argv[i], strerror(rv));
|
||||
}
|
||||
}
|
||||
}
|
||||
xbps_pkgdb_unlock(&xh);
|
||||
exit(rv ? EXIT_FAILURE : EXIT_SUCCESS);
|
||||
}
|
||||
|
Reference in New Issue
Block a user