tests/xbps-checkvers: new tests to detect incorrect behaviour.

tests/xbps/xbps-checkvers/checkvers.sh

@@ -1,12 +1,11 @@
 #! /usr/bin/env atf-sh
 
-atf_test_case install_existent
+atf_test_case srcpkg_older
 
-checkvers_older_head() {
+srcpkg_older_head() {
-	atf_set "descr" "xbps-checkvers(8): test checkversion when repo is older"
+	atf_set "descr" "xbps-checkvers(8): test when srcpkg contains an older version"
 }
-
+srcpkg_older_body() {
-checkvers_older_body() {
 	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
 	touch pkg_A/file00
 	cat > void-packages/srcpkgs/A/template <<EOF
@@ -28,11 +27,170 @@ EOF
 	atf_check_equal "$out" ""
 }
 
-checkvers_reverts_head() {
+atf_test_case srcpkg_newer
-	atf_set "descr" "xbps-checkvers(8): test checkversion with reverts"
+
+srcpkg_newer_head() {
+	atf_set "descr" "xbps-checkvers(8): test when srcpkg contains a newer version"
+}
+srcpkg_newer_body() {
+	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
+	touch pkg_A/file00
+	cat > void-packages/srcpkgs/A/template <<EOF
+pkgname=A
+version=1.1
+revision=1
+do_install() {
+	:
+}
+EOF
+	cd some_repo
+	xbps-create -A noarch -n A-1.0_1 -s "A pkg" ../pkg_A
+	atf_check_equal $? 0
+	xbps-rindex -d -a $PWD/*.xbps
+	atf_check_equal $? 0
+	cd ..
+	out=`xbps-checkvers -R $PWD/some_repo -D $PWD/void-packages`
+	atf_check_equal $? 0
+	atf_check_equal "$out" "pkgname: A repover: 1.0_1 srcpkgver: 1.1_1"
 }
 
-checkvers_reverts_body() {
+atf_test_case srcpkg_missing_pkgname
+
+srcpkg_missing_pkgname_head() {
+	atf_set "descr" "xbps-checkvers(8): test when srcpkg does not set pkgname"
+}
+srcpkg_missing_pkgname_body() {
+	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
+	cat > void-packages/srcpkgs/A/template <<EOF
+#pkgname=A
+version=1.1
+revision=1
+do_install() {
+	:
+}
+EOF
+	cd some_repo
+	xbps-create -A noarch -n A-1.0_1 -s "A pkg" ../pkg_A
+	atf_check_equal $? 0
+	xbps-rindex -d -a $PWD/*.xbps
+	atf_check_equal $? 0
+	cd ..
+	out=`xbps-checkvers -R $PWD/some_repo -D $PWD/void-packages`
+	atf_check_equal $? 0
+	atf_check_equal "$out" ""
+}
+
+atf_test_case srcpkg_missing_version
+
+srcpkg_missing_version_head() {
+	atf_set "descr" "xbps-checkvers(8): test when srcpkg does not set version"
+}
+srcpkg_missing_version_body() {
+	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
+	cat > void-packages/srcpkgs/A/template <<EOF
+pkgname=A
+#version=1.1
+revision=1
+do_install() {
+	:
+}
+EOF
+	cd some_repo
+	xbps-create -A noarch -n A-1.0_1 -s "A pkg" ../pkg_A
+	atf_check_equal $? 0
+	xbps-rindex -d -a $PWD/*.xbps
+	atf_check_equal $? 0
+	cd ..
+	out=`xbps-checkvers -R $PWD/some_repo -D $PWD/void-packages`
+	atf_check_equal $? 0
+	atf_check_equal "$out" ""
+}
+
+atf_test_case srcpkg_missing_revision
+
+srcpkg_missing_revision_head() {
+	atf_set "descr" "xbps-checkvers(8): test when srcpkg does not set revision"
+}
+srcpkg_missing_revision_body() {
+	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
+	cat > void-packages/srcpkgs/A/template <<EOF
+pkgname=A
+version=1.1
+#revision=1
+do_install() {
+	:
+}
+EOF
+	cd some_repo
+	xbps-create -A noarch -n A-1.0_1 -s "A pkg" ../pkg_A
+	atf_check_equal $? 0
+	xbps-rindex -d -a $PWD/*.xbps
+	atf_check_equal $? 0
+	cd ..
+	out=`xbps-checkvers -R $PWD/some_repo -D $PWD/void-packages`
+	atf_check_equal $? 0
+	atf_check_equal "$out" ""
+}
+
+atf_test_case srcpkg_missing_pkgver
+
+srcpkg_missing_pkgver_head() {
+	atf_set "descr" "xbps-checkvers(8): test when srcpkg does not set pkgname/version"
+}
+srcpkg_missing_pkgver_body() {
+	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
+	cat > void-packages/srcpkgs/A/template <<EOF
+#pkgname=A
+#version=1.1
+revision=1
+do_install() {
+	:
+}
+EOF
+	cd some_repo
+	xbps-create -A noarch -n A-1.0_1 -s "A pkg" ../pkg_A
+	atf_check_equal $? 0
+	xbps-rindex -d -a $PWD/*.xbps
+	atf_check_equal $? 0
+	cd ..
+	out=`xbps-checkvers -R $PWD/some_repo -D $PWD/void-packages`
+	atf_check_equal $? 0
+	atf_check_equal "$out" ""
+}
+
+atf_test_case srcpkg_missing_pkgverrev
+
+srcpkg_missing_pkgverrev_head() {
+	atf_set "descr" "xbps-checkvers(8): test when srcpkg does not set pkgname/version/revision"
+}
+srcpkg_missing_pkgverrev_body() {
+	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
+	cat > void-packages/srcpkgs/A/template <<EOF
+#pkgname=A
+#version=1.1
+revision=1
+do_install() {
+	:
+}
+EOF
+	cd some_repo
+	xbps-create -A noarch -n A-1.0_1 -s "A pkg" ../pkg_A
+	atf_check_equal $? 0
+	xbps-rindex -d -a $PWD/*.xbps
+	atf_check_equal $? 0
+	cd ..
+	out=`xbps-checkvers -R $PWD/some_repo -D $PWD/void-packages`
+	atf_check_equal $? 0
+	atf_check_equal "$out" ""
+}
+
+atf_test_case reverts
+
+reverts_head() {
+	atf_set "descr" "xbps-checkvers(8): test with reverts"
+}
+
+reverts_body() {
 	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
 	touch pkg_A/file00
 	cat > void-packages/srcpkgs/A/template <<EOF
@@ -55,34 +213,13 @@ EOF
 	atf_check_equal "$out" "pkgname: A repover: 1.1_1 srcpkgver: 1.0_1"
 }
 
-checkvers_newer_head() {
-	atf_set "descr" "xbps-checkvers(8): test checkversion with newer version"
-}
-
-checkvers_newer_body() {
-	mkdir -p some_repo pkg_A void-packages/srcpkgs/A
-	touch pkg_A/file00
-	cat > void-packages/srcpkgs/A/template <<EOF
-pkgname=A
-version=1.1
-revision=1
-do_install() {
-	:
-}
-EOF
-	cd some_repo
-	xbps-create -A noarch -n A-1.0_1 -s "A pkg" ../pkg_A
-	atf_check_equal $? 0
-	xbps-rindex -d -a $PWD/*.xbps
-	atf_check_equal $? 0
-	cd ..
-	out=`xbps-checkvers -R $PWD/some_repo -D $PWD/void-packages`
-	atf_check_equal $? 0
-	atf_check_equal "$out" "pkgname: A repover: 1.0_1 srcpkgver: 1.1_1"
-}
-
 atf_init_test_cases() {
-	atf_add_test_case checkvers_older
+	atf_add_test_case srcpkg_newer
-	atf_add_test_case checkvers_reverts
+	atf_add_test_case srcpkg_older
-	atf_add_test_case checkvers_newer
+	atf_add_test_case srcpkg_missing_pkgname
+	atf_add_test_case srcpkg_missing_version
+	atf_add_test_case srcpkg_missing_revision
+	atf_add_test_case srcpkg_missing_pkgver
+	atf_add_test_case srcpkg_missing_pkgverrev
+	atf_add_test_case reverts
 }