Fix all warnings found by clang analyzer as reported by ojab in issue 3.

This commit is contained in:
Juan RP
2011-02-03 17:49:43 +01:00
parent 0a26497b50
commit 097b50b3c2
6 changed files with 5 additions and 7 deletions

View File

@ -76,7 +76,7 @@ store_dependency(prop_dictionary_t transd, prop_dictionary_t repo_pkgd)
* Overwrite package state in dictionary if it was unpacked
* previously.
*/
if ((rv = xbps_get_pkg_state_installed(pkgname, &state)) == 0) {
if (xbps_get_pkg_state_installed(pkgname, &state) == 0) {
if ((rv = xbps_set_pkg_state_dictionary(dict, state)) != 0) {
prop_object_release(dict);
return rv;
@ -216,7 +216,7 @@ find_repo_deps(prop_dictionary_t transd, /* transaction dictionary */
* current package.
*/
while ((obj = prop_object_iterator_next(iter)) != NULL) {
tmpd = curpkgd = NULL;
curpkgd = NULL;
reqpkg = prop_string_cstring_nocopy(obj);
if (reqpkg == NULL) {
rv = EINVAL;