emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

xbps-rindex: clear file permission bits before creating our named semaphore.

Browse Source 
Due to the file permission bits (umask(3)) the semaphore wasn't created
with correct permissions.
This commit is contained in:
Juan RP 2014-02-05 15:27:35 +01:00
parent 9c124aa162
commit 306fe4968e
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
NEWS
View File

@ -1,5 +1,8 @@
xbps-0.32 (???): xbps-0.32 (???):
* xbps-rindex(8): set correct permissions to the POSIX semaphore
by clearing file permission bits before its creation.
xbps-0.31 (2014-02-01): xbps-0.31 (2014-02-01):
* xbps-rindex(8): use a POSIX named semaphore in modes that can modify * xbps-rindex(8): use a POSIX named semaphore in modes that can modify

4
bin/xbps-rindex/sem.c
View File

@ -36,6 +36,7 @@ struct idxlock *
index_lock(struct xbps_handle *xhp) index_lock(struct xbps_handle *xhp)
{ {
struct idxlock *il; struct idxlock *il;
mode_t myumask;
if ((il = malloc(sizeof(struct idxlock))) == NULL) if ((il = malloc(sizeof(struct idxlock))) == NULL)
return NULL; return NULL;
@ -48,7 +49,10 @@ index_lock(struct xbps_handle *xhp)
/* /*
* Create/open the POSIX named semaphore. * Create/open the POSIX named semaphore.
*/ */
myumask = umask(0);
il->sem = sem_open(il->semname, O_CREAT, 0660, 1); il->sem = sem_open(il->semname, O_CREAT, 0660, 1);
umask(myumask);
if (il->sem == SEM_FAILED) { if (il->sem == SEM_FAILED) {
fprintf(stderr, "%s: failed to create/open named " fprintf(stderr, "%s: failed to create/open named "
"semaphore: %s\n", _XBPS_RINDEX, strerror(errno)); "semaphore: %s\n", _XBPS_RINDEX, strerror(errno));