libxbps: simplify pkgdb_get_pkgd and find_pkg_dict_installed internals.

There's no need to prop_dictionary_copy the returned dictionary to
later have to free it again, just return directly the dictionary and
avoid the free(3)s.
This commit is contained in:
Juan RP
2012-06-16 09:02:07 +02:00
parent 068cab8d20
commit 974b2fe8ad
19 changed files with 28 additions and 96 deletions

View File

@ -103,16 +103,11 @@ xbps_configure_pkg(struct xbps_handle *xhp,
}
if (state == XBPS_PKG_STATE_INSTALLED) {
if ((xhp->flags & XBPS_FLAG_FORCE_CONFIGURE) == 0) {
prop_object_release(pkgd);
if ((xhp->flags & XBPS_FLAG_FORCE_CONFIGURE) == 0)
return 0;
}
} else if (state != XBPS_PKG_STATE_UNPACKED) {
prop_object_release(pkgd);
} else if (state != XBPS_PKG_STATE_UNPACKED)
return EINVAL;
}
}
prop_object_release(pkgd);
xbps_set_cb_state(xhp, XBPS_STATE_CONFIGURE, 0, pkgname, version, NULL);
buf = xbps_xasprintf("%s/metadata/%s/INSTALL",