emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Introduce xbps_repo_{un,}lock() to serialize write access to repodata.

Browse Source 
We use a simple file lock that is created with O_CREAT|O_EXCL.
This should fix the concurrency issues with multiple processes
running xbps-rindex -a/-c on the same repository/arch combo.
This commit is contained in:
Juan RP
2015-03-25 12:00:59 +01:00
parent bb4ebf8152
commit 9a16283575
7 changed files with 120 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
bin/xbps-rindex/index-clean.c
View File

@ -96,10 +96,17 @@ index_clean(struct xbps_handle *xhp, const char *repodir)
xbps_dictionary_t idx = NULL, idxmeta = NULL;
struct xbps_repo *repo;
struct cbdata cbd;
int rv = 0;
char *rlockfname = NULL;
int rv = 0, rlockfd = -1;
bool flush = false;
repo = xbps_repo_open(xhp, repodir, true);
if (!xbps_repo_lock(xhp, repodir, &rlockfd, &rlockfname)) {
rv = errno;
fprintf(stderr, "%s: cannot lock repository: %s\n",
_XBPS_RINDEX, strerror(rv));
return rv;
}
repo = xbps_repo_open(xhp, repodir);
if (repo == NULL) {
rv = errno;
if (rv == ENOENT)
@ -156,6 +163,8 @@ index_clean(struct xbps_handle *xhp, const char *repodir)
out:
xbps_repo_close(repo);
xbps_repo_unlock(rlockfd, rlockfname);
if (idx)
xbps_object_release(idx);
if (idxmeta)