Juan RP
3290df5d62
lib/portableproplib/prop_array.c: comment out a debug printf.
2014-11-13 15:22:13 +01:00
Juan RP
43c9497feb
Introduce xbps_array_add_first() to insert obj at the head of array.
...
The behaviour of this routine mimics the existing xbps_array_add() with
the difference that stored objects are moved to the right to insert
our object as the first element on the array.
Use this to add replaced packages in the transaction array at the head
rather than at the end, to preserve the proper sorting order.
2014-11-13 15:18:21 +01:00
Juan RP
74c30556fc
xbps_transaction_prepare: check for unresolved shlibs a bit early.
...
It's just better if we check for unresolved shlibs earlier because
the transaction array will be smaller if there are replaced packages.
2014-11-13 11:39:20 +01:00
Juan RP
04bde70969
xbps_init: print bestmatching value.
2014-11-07 10:18:01 +01:00
Juan RP
53f13d579e
Added the "bestmatching" configuration keyword to enable pkg best matching.
...
See the NEWS file for more information.
2014-11-07 10:07:51 +01:00
Juan RP
6c76f6786d
xbps_repo_open: do not create repodata file in locked mode.
...
... we want a proper errno value (ENOENT) if the archive does not exist.
2014-11-06 11:38:55 +01:00
Juan RP
5b522109f7
Replaced config/system {repo,preserve,virtualpkg}.d with a single directory.
...
See the NEWS file for more information.
2014-11-06 09:58:04 +01:00
Juan RP
9566a0e737
Re-add support for system virtualpkg.d (XBPS_SYS_VPKG_PATH).
...
This is still useful to set distro defaults for virtual packages, with
the option to override them via /etc/xbps/virtualpkg.d.
2014-11-05 09:40:32 +01:00
Juan RP
595136704e
Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d).
...
Binary packages do not need to provide those virtualpkg configuration files
anymore; all vpkg info is now collected from pkgdb.
2014-11-04 11:17:27 +01:00
Juan RP
5dba1108d1
lib/package_remove.c: simplify link relative check.
2014-10-25 10:32:58 +02:00
Juan RP
ff3960696f
lib/package_remove.c: fix a memleak.
2014-10-25 08:08:04 +02:00
Juan RP
e75beec76f
unpack: get rid of code that checks for modified symlinks.
...
Unpacking those symlinks is so cheap that there's no point in wasting
resources just to check if those have been modified, just unpack them
unconditionally.
2014-10-25 06:52:12 +02:00
Juan RP
5fe3594cb5
Make sure that modified symlinks are preserved.
...
When removing a package, symlinks owned by this package that have been
modified should be preserved, unless the force flag is set via xbps-remove(8).
2014-10-25 06:43:30 +02:00
Juan RP
b81dedb770
lib/transaction_package_replace.c: simplify.
2014-10-25 05:20:13 +02:00
Juan RP
789326cf3a
xbps_repo_sync: fix regression introduced in 87ca42f3
.
2014-10-24 11:16:24 +02:00
Juan RP
87ca42f399
Remove xdelta support: it never worked and wasn't fully implemented.
2014-10-24 11:04:51 +02:00
Juan RP
654c77df25
Switch back to uncompressed plists.
...
There's no point in slowing down read performance just to save a few bytes.
2014-10-24 10:15:41 +02:00
Juan RP
e35d0c202c
unpack: simplify pkg metadata extraction.
...
There's no need to internalize props.plist because there are no changes
compared to the pkg dictionary stored in the repo index, simply ignore it.
The code only cares for the files.plist to check for obsolete files.
2014-10-21 09:25:15 +02:00
Juan RP
627a5afaaf
Make sure that automatic/manual installation modes are set as expected.
2014-10-20 07:59:06 +02:00
Juan RP
231582e671
libxbps: make sure to not add dups in transaction for remove.
2014-10-19 11:22:17 +02:00
Juan RP
fb868454b2
libxbps: make sure to not add dups in transaction for install/update.
2014-10-19 11:00:40 +02:00
Juan RP
e884270e06
xbps_transaction_prepare: ignore pkgs that will be removed.
2014-10-18 16:07:52 +02:00
Juan RP
ff189fd210
Replaced redundant dependency sorting code with a simpler implementation.
...
This fixes the issue found by "xbps-src bootstrap" when a package
without "provides" was declared as a virtual package.
2014-10-18 12:35:47 +02:00
Juan RP
adc0643ee4
Fully switch to zplists.
2014-10-17 10:27:58 +02:00
Juan RP
b1eb62a2df
lib/package_unpack.c: switch pkg meta files to zplist too.
2014-10-17 10:23:12 +02:00
Juan RP
fc368e159d
lib/portableproplib/prop_zlib.c: use a stack buffer to process compressed chunks.
2014-10-17 10:12:12 +02:00
Juan RP
83f5e35ec7
pkgdb: switch to zplists by default.
2014-10-17 10:11:56 +02:00
Juan RP
47310d3408
lib/archive.c: remove support to read zplists in archives.
...
It was never used and the binpkgs are already compressed...
2014-10-17 10:10:16 +02:00
Juan RP
d7633e88e0
Fix #62 (Dup replaced pkgs in transaction)
2014-10-17 09:52:32 +02:00
Juan RP
1c20086896
Package remove: disable file owner checks if euid==0.
...
All package files even not owned by root should be removed, so make sure
that those checks return success while being root.
This fixes package removal for polkit, that had /etc/polkit/rules.d
files owned by the polkitd user.
2014-10-17 09:17:07 +02:00
Juan RP
fe76af7702
proplib: use GCC atomic builtins if supported.
2014-10-09 14:41:43 +02:00
Juan RP
09c630a825
lib/transaction_commit.c: CID 62740 (toctou)
2014-10-08 10:13:21 +02:00
Juan RP
513f8a2bae
lib/repo.c: CID 62757 (toctou)
2014-10-08 10:00:17 +02:00
Juan RP
805f6aa1b2
lib/repo_sync.c: CID 62763 (toctou)
2014-10-08 09:55:12 +02:00
Juan RP
0c74a5d7fe
Revert "lib/portableproplib/prop_object.c: CID 62694 (data race condition)"
...
This reverts commit dc63aed221
.
2014-10-07 11:51:53 +02:00
Juan RP
967acd82b0
lib/fetch/http.c: CID 62725 (NULL pointer dereference)
2014-10-07 11:12:04 +02:00
Juan RP
a6cdd9a698
lib/fetch/common.c: CID 62709 (NULL pointer dereference)
2014-10-07 11:07:24 +02:00
Juan RP
6e7c160195
lib/fetch/file.c: CID 62701 (NULL pointer dereference)
2014-10-07 11:02:12 +02:00
Juan RP
d434b44cfc
lib/fetch/http.c: CID 62698 (NULL pointer dereference)
2014-10-07 10:51:37 +02:00
Juan RP
dc63aed221
lib/portableproplib/prop_object.c: CID 62694 (data race condition)
2014-10-07 10:27:07 +02:00
Juan RP
9c5af90fae
lib/portableproplib/prop_object.c: CID 62703 (argument cannot be negative)
2014-10-07 10:23:02 +02:00
Juan RP
6a02cb6534
lib/portableproplib/prop_data.c: CID 62728 (integer overflowed argument)
2014-10-07 10:19:32 +02:00
Juan RP
3a71db1d0b
lib/pubkey2fp.c: fix CID 62724 correctly.
2014-10-07 09:34:14 +02:00
Juan RP
ec438c36f9
Fix 1a19adf85c
correctly.
2014-10-07 09:18:28 +02:00
Juan RP
680abe50e7
lib/fetch/ftp.c: CID 62745 (unusued value)
2014-10-07 08:25:57 +02:00
Juan RP
fe87bc1a88
lib/util.c: CID 62710 (dead code)
2014-10-07 08:16:45 +02:00
Juan RP
a730a61df9
lib/initend.c: CID 62720 (NULL pointer dereference)
2014-10-07 07:59:07 +02:00
Juan RP
4be2a0ee84
lib/pkgdb.c: CID 62719 (NULL pointer dereference)
2014-10-07 07:57:38 +02:00
Juan RP
fcf464d2fa
lib/transaction_sortdeps.c: CID 62717 (NULL pointer dereference)
2014-10-07 07:45:20 +02:00
Juan RP
1a19adf85c
lib/transaction_commit.c: CID 62716 (argument cannot be negative)
2014-10-07 07:29:58 +02:00
Juan RP
9fc6c9d70e
lib/repo.c: CID 62706 (argument cannot be negative)
2014-10-07 07:27:45 +02:00
Juan RP
3a77ab0847
lib/download.c: CID 62691 (dereference NULL check)
2014-10-06 08:23:34 +02:00
Juan RP
fae4ef0cd6
lib/pubkey2fp.c: CID 62724 (dereference NULL return value)
2014-10-06 08:17:53 +02:00
Juan RP
a6f128a578
lib/plist.c: CID 62704 (argument cannot be negative)
2014-10-05 13:22:28 +02:00
Juan RP
be256ed77b
lib/repo.c: fix CID 62783 correctly
2014-10-05 13:11:59 +02:00
Juan RP
68ef66eb51
lib/fetch/fetch.c: CID 62784 (uninitialized pointer read)
2014-10-05 13:10:05 +02:00
Juan RP
8ccb48e65b
lib/initend.c: CID 62697 (dereference before NULL check)
2014-10-05 12:55:07 +02:00
Juan RP
7310322cbf
lib/transaction_package_replace.c: CID 62693 (dereference NULL return value)
2014-10-05 12:50:50 +02:00
Juan RP
66292180a3
lib/repo.c: CID 62671 (unchecked return value)
2014-10-05 12:22:18 +02:00
Juan RP
2212a05f89
lib/download.c: CID 62696 (dead code)
2014-10-05 12:13:34 +02:00
Juan RP
44f5fb107e
lib/fetch/fetch.c: CID 62738 (unused value)
2014-10-05 12:01:25 +02:00
Juan RP
89b8c61c47
lib/package_unpack.c: remove unused var (CID 62731)
2014-10-05 11:57:20 +02:00
Juan RP
c3dc804bc0
lib/fetch/http.c: try to fix CID 62683 (resource leak)
2014-10-05 10:32:09 +02:00
Juan RP
25e8fca7b4
lib/fetch/common.c: fix CID 62681 correctly (resource leak).
2014-10-05 10:21:18 +02:00
Juan RP
23fccb17f7
lib/transaction_revdeps.c: use-after-free (CID 62765)
2014-10-05 09:18:59 +02:00
Juan RP
3378c4487d
lib/package_config_files.c: resource leak (CID 62682)
2014-10-05 09:13:03 +02:00
Juan RP
c1959b3915
lib/fetch/common.c: resource leak (CID 62681)
2014-10-05 09:08:05 +02:00
Juan RP
9d90c75fcc
lib/fetch/http.c: buffer not NUL terminated (CID 62666)
2014-10-05 09:04:16 +02:00
Juan RP
6dcac6a840
lib/transaction_sortdeps.c: resource leak (CID 62688)
2014-10-05 08:12:49 +02:00
Juan RP
b28e85bfaa
lib/repo_pkgdeps.c: resource leak (CID 62700)
2014-10-05 07:38:20 +02:00
Juan RP
0608e0057f
lib/repo.c: fix build after aa8d88272e
.
2014-10-05 07:38:14 +02:00
Juan RP
aa8d88272e
lib/repo.c: resource leak (CID 62715)
2014-10-05 07:32:43 +02:00
Juan RP
4ae3d03594
lib/transaction_revdeps.c: resource leak (CID 62723)
2014-10-05 07:29:23 +02:00
Juan RP
aae88aa253
lib/verifysig.c: resource leak (CID 62727)
2014-10-05 07:27:13 +02:00
Juan RP
dd851f18a2
lib/package_unpack.c: zero out struct (CID 62755)
2014-10-05 07:12:30 +02:00
Juan RP
96a117c558
lib/repo_pkgdeps.c: fix a double free in error branch (CID 62754)
2014-10-05 07:09:40 +02:00
Juan RP
bc9ddcfcc8
lib/initend.c: rename a var to make gcc-4.6.x happy.
2014-10-04 22:02:56 +02:00
Juan RP
2fe35a5bf3
lib/package_unpack.c: do not initialize xucd at all, unnecessary.
...
Initializing with {0} wasn't understood with gcc-4.6.x on travis-ci,
so just remove it.
2014-10-04 21:59:47 +02:00
Juan RP
742af69185
Fix libxbps/update_shlibs:shlib_bump_revdep_diff test.
...
How to reproduce it:
- A-1.0_1 provides liba.so.1
- B-1.0_1 provides libb.so.1
- C-1.0_1 requires liba.so.1 and libb.so.1
- A-2.0_1 provides liba.so.2
- C-2.0_1 required liba.so.2
This test case failed because it was checking the required shared libraries
from current installed package, rather than the updated pkg in transaction.
2014-09-29 15:25:09 +02:00
Enno Boland
42f0152dce
trans_find_pkg(): search for reverts match with correct pkgver
2014-09-28 22:22:20 +02:00
Juan RP
2711b07b77
Fix package files removal with only read bit set.
...
The previous code was checking incorrectly if the file had the write
bit set, and this is wrong because a package could have files with
only the read bit set (0444).
2014-09-28 13:33:15 +02:00
Juan RP
72cefcfc83
Introduce xbps_mmap_file() and use it in strategic points.
...
Rather than using a random buffer from stack or heap, and decide
what size to use, create a private memory mapped object...
This simplifies the code in lib/verifysig.c and xbps-create.
2014-09-27 13:00:34 +02:00
Juan RP
97045960f9
xbps_pkg_reverts: style.
2014-09-27 11:28:29 +02:00
Enno Boland
b5a169b65c
xbps_pkg_reverts: this function can do more than just return false!
2014-09-23 21:18:47 +02:00
Enno Boland
a421bf7db5
xbps_pkg_reverts: return bool instead of int.
2014-09-23 20:50:34 +02:00
Enno Boland
dbab3f2cfc
xbps_pkg_reverts: use version instead of pkgname-version to find reverts
2014-09-23 18:22:57 +02:00
Enno Boland
50fb6c1605
rename xbps_pkgver_is_reverted to xbps_pkg_reverts
2014-09-23 13:54:06 +02:00
Enno Boland
cd9a9e78a8
lib/transaction_ops.c: trans_find_pkg will check the revert field too.
...
- if a package on the repo has a lower version than installed
libxbps will check if this package reverts the one installed
and downgrades to it if so.
2014-09-23 13:54:06 +02:00
Enno Boland
18204aeac1
lib/util.c: add function which tests if a given pkgver is reverted by a given pkg.
2014-09-23 13:54:06 +02:00
Enno Boland
5bbcdf2c62
lib/util_hash.c: enlarge read buffer for xbps_file_hash to increase performance.
2014-09-18 18:34:15 +02:00
Juan RP
f52eea34d4
xbps-install: abort transaction if there's insufficient disk space on rootdir.
...
The free disk space wasn't computed correctly and xbps-install(8) wasn't
handling ENOSPC rval in xbps_transaction_prepare().
2014-09-18 12:11:02 +02:00
Juan RP
741f8fbe04
lib/util_hash.c: update copyright year.
2014-09-17 07:24:00 +02:00
Juan RP
72c64c7626
xbps_file_hash: reduce memory footprint and process file in small chunks.
...
With xbps-rindex(8) -c/-r being multithreaded, the memory usage was
insanely high in the build server, with peaks of almost 4GB (this depends
on the file size being processed and number of threads).
Process the file in small chunks instead to compute the SHA256 hash.
2014-09-17 06:50:46 +02:00
Juan RP
6894980983
lib/package_msg.c: fix a heap overflow (noticed by @Gottox).
2014-09-16 09:13:32 +02:00
Juan RP
e902619220
Remove empty self replaced pkg arrays from pkgdb.
2014-09-14 18:16:43 +02:00
Juan RP
ac2c517bd7
Fixed install/update tests on pkgs with no files.
2014-09-14 18:04:10 +02:00
Juan RP
c9514ad617
libxbps: fixed replaces/replace_vpkg test case.
2014-09-14 12:50:17 +02:00
Juan RP
2b7c4d568a
Remove pkg self replacement from pkgdb; this must not be propagated.
2014-09-13 18:14:04 +02:00
Juan RP
dea31f0a15
Add xbps_remove_{pkgname,string}_from_array() to the API.
2014-09-13 18:13:25 +02:00
Juan RP
b42c3d8498
lib/pkgdb_conversion.c: avoid copying dangling pointer if "repository-origin" is unexistent.
2014-09-13 16:59:19 +02:00