emo/xbps
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,054 Commits 1 Branch 0 Tags 11 MiB
9f52a7837f
Commit Graph

1322 Commits

Author SHA1 Message Date
Juan RP
92c07c126f xbps_repo_lock: sleep() for a second if the lock is already taken. 
... rather than looping continuously.
 2015-06-04 08:08:40 +02:00
Juan RP
07e8330936 xbps-install(1): added -U --unpack-only to only unpack pkgs, skips configuration. 2015-06-03 11:15:11 +02:00
Juan RP
c464874c1e unpack: make sure the xucd callbacks don't get a dangling pointer. 
If the current entry filename has been changed, the pointer must be updated
to point to the updated string.
 2015-05-28 10:39:39 +02:00
Juan RP
769a997afb Introduce xbps_plist_{array,dictionary}_from_file(). 
Those are a wrapper around xbps_{array,dictionary}_internalize_from_zfile()
that prints a debugging msg when the plist file cannot be internalized.

Update xbps to use these wrappers.
 2015-05-28 10:15:05 +02:00
Juan RP
2ba31e048a proplib: check for EOF a bit early on the internalized plist. 2015-05-28 09:34:03 +02:00
Juan RP
fd30a00cb4 proplib: fix a NULL pointer dereference when internalizing empty blobs. 
_prop_object_internalize_context_alloc: make sure that passed xml string
is not NULL before derefering it a bit later.
 2015-05-28 09:14:28 +02:00
Juan RP
4fdc8de9d6 repo: make index and index-meta dicts immutable. 
For clients that want to modify its content they will need to copy a mutable
dictionary instead. This will avoid unwanted modifications.
 2015-05-22 12:19:48 +02:00
Juan RP
5e97a1eb39 xbps_pkgdb_update: return EINVAL if pkgdb cannot be internalized. 2015-05-22 12:18:54 +02:00
Juan RP
da74e3dd9e libxbps: stop and error out if pkg signature is not valid. 2015-05-09 06:27:03 +02:00
Juan RP
c5d6556c50 xbps-remove: fix #95 (xbps-remove -R pkg lists/removes orphans) 2015-05-06 17:21:13 +02:00
Juan RP
ea364affc8 libxbps: open fds with O_CLOEXEC to avoid warnings of leaked fds. 2015-04-15 21:02:38 +02:00
Juan RP
15893caf0b fetch: support keep-alive even if the HTTP server returns 304 (Not-Modified). 2015-04-13 12:05:40 +02:00
Juan RP
2216c84eca libxbps: continue updating all pkgs if xbps is uptodate. 2015-03-29 11:06:18 +02:00
Juan RP
83ade39960 xbps now autoupdates itself exclusively if there's an update. 
That was added for 0.21, but for some reason that I cannot remember it was
disabled a bit later... looks like it's useful to have.
 2015-03-29 09:56:28 +02:00
Juan RP
9a16283575 Introduce xbps_repo_{un,}lock() to serialize write access to repodata. 
We use a simple file lock that is created with O_CREAT|O_EXCL.
This should fix the concurrency issues with multiple processes
running xbps-rindex -a/-c on the same repository/arch combo.
 2015-03-25 12:00:59 +01:00
Juan RP
dc47dfd593 xbps_get_pkg_fulldeptree: detect pkgs depending on itself via virtual pkgs. 
Reported by Duncan Overbrook.

Update NEWS with recent changes.
 2015-03-20 08:03:06 +01:00
Juan RP
f9b6dd9d2d proplib: anonymous mappings need MAP_ANON. 
Somehow I removed this accidentally in a previous change... sigh.
 2015-03-11 17:06:45 +01:00
Juan RP
95d650bdb1 lib/transaction_shlibs.c: add a printf to see what's going on. 2015-03-07 08:02:39 +01:00
Juan RP
441f147f05 Fix reinstallation of pkgs in repolock mode. 
At the time we've been searching for the pkg in a repo, no repos
were registered resulting in EINVAL. While here, if there's no
declared repos return ENOENT instead.
 2015-03-05 21:23:58 +01:00
Juan RP
4922c808f4 Implemented feature #77 (Add package repository locked mode) 
Close #77
 2015-03-03 12:11:28 +01:00
Juan RP
976718417b libxbps: remove "skip-obsoletes" handling; unnecessary with the mtime checks. 2015-02-26 19:51:03 +01:00
Juan RP
b6b446d32e libxbps: properly detect obsolete files with files being between pkgs. 
120 test cases now successfully pass, and all known issues about
pkg updates that move files between them should be gone (hopefully).
 2015-02-26 19:37:46 +01:00
Juan RP
cbe493858c libxbps: apply file timestamps to unmodified files on-disk while unpacking. 2015-02-25 11:10:18 +01:00
Juan RP
b133b9023c lib/package_unpack.c: wrap some long lines and fix an obvious error. 2015-02-24 09:34:39 +01:00
Juan RP
7e21f1ee1a xbps_symlink_target: rename var to avoid shadowing a global var. 2015-02-19 11:44:10 +01:00
Juan RP
9083191e4b xbps_symlink_target: double free in rootdir == '/' case. 2015-02-19 11:39:59 +01:00
Juan RP
6d65e76f91 xbps_symlink_target: fix a memleak. 2015-02-19 11:36:09 +01:00
Juan RP
a05e039cce Revert "Stop converting relative symlinks to absolute." 
This reverts commit 9ae3638429.

This change is ok, but cannot be used right now because all existing
binpkgs were created with an old xbps-create(8).
 2015-02-19 11:11:58 +01:00
Juan RP
9ae3638429 Stop converting relative symlinks to absolute. 
There's no reason to make them absolute, simply store in the metadata
the target file as is. This vastly simplifies the code and makes all
test pass correctly.
 2015-02-19 11:04:34 +01:00
Juan RP
67eba7d912 Improve detection of target file in relative symlinks. 
If xbps-create(8) did not guess the target file of relative symlinks for
some reason, just compare the current symlink and what's stored as is,
without converting it to absolute.

This might happen with dangling relative symlinks or existing binary
packages that were not created with a newer xbps-create(8).
 2015-02-19 10:24:24 +01:00
Juan RP
05f879ec09 Introduce xbps_symlink_target() and use it in two places. 
This code is now shared by xbps-pkgdb and libxbps/xbps-remove.
 2015-02-19 09:47:09 +01:00
Juan RP
1722635e08 Introduce xbps_sanitize_path() to fix #78 properly. 
This removes multiple slashes of a path and returns you a buffer with
the sanitized string.
 2015-02-18 15:12:39 +01:00
Juan RP
628a344560 libxbps: fix a memleak introduced in 1403826fa. 2015-02-17 16:39:04 +01:00
Juan RP
1403826fa6 libxbps: detect and remove properly symlinks with relative targets. 
Close #78
 2015-02-17 11:59:05 +01:00
Juan RP
0fc297a471 lib/transaction_ops.c: minor optimization. 2015-02-16 11:18:58 +01:00
Juan RP
2aa844f3f7 lib/Makefile: remove some disabled warnings for lib{fetch,portableproplib}. 
There's no need to set _GNU_SOURCE and disable those compiler warning flags.
 2015-02-15 05:47:35 +01:00
Juan RP
b8b4694b33 portableproplib: use posix_madvise rather than madvise. 
The posix variant is the standardized version of madvise.
 2015-02-15 05:42:18 +01:00
Juan RP
4e0ce0fbb4 libxbps: make the vpkg_provider_and_revdeps_downgrade test case work. 2015-02-10 10:55:05 +01:00
Juan RP
1ebb245672 xbps_transaction_store: print repo too. 2015-02-05 10:26:53 +01:00
Juan RP
c0d7d930de libxbps: make sure that revdeps of vpkg providers are always resolved. 
Added new test cases to verify its correctness in upgrades and removals.
 2015-02-05 10:04:42 +01:00
Juan RP
d607655371 libxbps: globally check for unresolved reverse dependencies. 
Close #46. See NEWS for more information.
 2015-02-03 10:20:13 +01:00
Juan RP
3bc6354550 lib/repo_pkgdeps.c: fix some debug printfs. 2015-02-02 09:37:34 +01:00
Juan RP
076b3f8c44 libxbps: add pkgs on hold mode to the transaction, but ignore them. 
Those are there mostly to be shown by the clients and notify that
there's an update in repos that is being ignored.

Idea by @chneukirchen.
 2015-01-28 12:07:47 +01:00
Juan RP
571d96fa92 libxbps: make sure to remove pkg metadata file on upgrades with skip-obsoletes. 
This fixes the following case:

 - A-1.0_1 is installed and owns bin/foo.
 - A-1.1_1 is in the transaction and depends on B-1.0_1 that owns bin/foo.
 - B-1.0_1 is in the transaction and replaces A<1.1_1.
 - A-1.1_1 in the transaction now has "skip-obsoletes".
 - A is updated to 1.1_1, its metadata file (<pkgname>-files.plist) wasn't removed.

Added two new test cases to verify moving files from/to a dependency.
 2015-01-27 17:53:37 +01:00
Juan RP
cbf1cfe0f5 libxbps: improve debug messages again. 2015-01-21 11:39:45 +01:00
Juan RP
b7fd0dcac5 xbps_transaction_shlibs: take into account shlibs from pkgs in the transaction. 2015-01-18 12:44:26 +01:00
Juan RP
f9eef6aa0d Perform global tracking of unresolved shlibs before accepting transaction. 
Rather than checking per package being installed or updated, check
all installed packages to have all its shlib-requires resolved.
 2015-01-18 10:23:52 +01:00
Juan RP
d11230a29d libxbps: abort pkg unpacking as soon as a file cannot be written. 
Close #74
 2015-01-18 10:22:05 +01:00
Juan RP
bce27b968e xbps_find_*pkg_in_array: fix logic when transaction obj string matches. 2015-01-17 06:04:22 +01:00
Juan RP
e438aae13c transaction_revdeps.c: remove dead code. 2015-01-14 21:00:37 +01:00
Juan RP
8263449f94 xbps_end: don't bother releasing everything; pkgdb is enough. 
xbps-query -L now: 115ms
xbps-query -L before: 148ms

Fuck you valgrind!
 2015-01-14 18:43:17 +01:00
Juan RP
a651f33832 xbps_pkgdb_release: don't bother releasing everything. 2015-01-14 17:34:00 +01:00
Juan RP
91b7b2fd5a Use a sane umask(2) before unpacking package files. 
See https://github.com/voidlinux/void-packages/issues/835
for more information.
 2015-01-11 11:01:09 +01:00
Juan RP
b23855f692 xbps_repo_close: only unlock the file lock if repo was opened as such. 
If xbps_repo_open() was called with the lock arg set, xbps_repo_close()
will now unlock the repo file lock, without the need to set it.

This avoids the need to always unlock the file lock even if it wasn't
locked previously. This also introduceds an ABI/API break, but this
way it's cleaner.
 2015-01-11 09:11:38 +01:00
Juan RP
7dea05f507 xbps_pkgdb_update: added 3rd bool arg "update", not update in memory pkgdb. 
If true, the in memory pkgdb dict will be updated with data from the on-disk pkgdb.
 2015-01-10 19:42:09 +01:00
Juan RP
7c153a2b15 pkgdb: disable pkgdb conversion code; 0.38 was released long ago. 2015-01-10 19:26:37 +01:00
Juan RP
ee175a2a68 Improve xbps_end() and use it before exit(3)ing. 
- Simplify xbps_repo_open::repo_get_dict().
- Use xbps_end() in the utils where necessary.
- Make xbps_end() call xbps_pkgdb_unlock() if necessary.
- Make xbps_end() release rpool resources.
- Make xbps_end() release resources from xbps_handle.
- Fixed 90% of reported leaks (still reachable at exit) from valgrind.

That was to silence valgrind's memcheck with --leak-check=full.
 2015-01-10 19:11:31 +01:00
Juan RP
8196811e2e lib/repo.c: indent previous. 2015-01-10 12:00:36 +01:00
Juan RP
b09faadebc xbps-{install,query}: --repository now accepts relative paths in local repos. 2015-01-10 11:59:31 +01:00
Juan RP
7b3a500139 libxbps: the provides obj now expects exact pkgver strings. 
This reduces extra allocs and simplifies the code, which was just
there to workaround some broken pkgs anyway.
 2015-01-10 07:26:23 +01:00
Juan RP
1f6a5c0e47 libxbps: detection of orphaned packages is now 66% faster. 2015-01-10 05:43:35 +01:00
Juan RP
5d7a5a646d xbps_repo_get_pkg_revdeps: find pkg via repo_get_xxx not rpool_get_xxx. 2015-01-06 07:58:45 +01:00
Juan RP
9d582abe0f Fixed a regression with virtual packages declared via xbps.d(5). 
Added a new test case to verify its correctness. Somehow virtual packages
declared via xbps.d(5) were not working correctly for dependencies.

This now works as expected with vpkgs declared with and without a version
component.
 2015-01-05 16:04:22 +01:00
Juan RP
eee895c6d8 Fixed a regression in vpkgs and improve xbps.d(5) virtualpkg declarations. 
See the NEWS file for more information.
 2014-12-31 08:51:45 +01:00
Juan RP
b513a5e15e libfetch: misc cleanups due to nbcompat removal. 2014-12-28 03:34:36 +01:00
Juan RP
4ee6f943dd libfetch: fix races in the cache connection code. 
Tested by @Gottox.
 2014-12-23 10:52:54 +01:00
Juan RP
6a985190aa xbps_archive_fetch_xxx: avoid races with multiple threads in the libfetch code. 
Protect our critical sections with a mutex for now, until libfetch
is really fixed to work correctly with multiple threads.
 2014-12-22 18:18:20 +01:00
Juan RP
c8ecf4ac6c xbps-reconfigure(8): new option -i, --ignore to ignore pkgs with -a, --all. 
-i, --ignore can be specified multiple times and can be used to
ignore configuration of those packages while configuration of all
packages is being performed.

Close #67
 2014-12-09 13:10:48 +01:00
Juan RP
16d2640df8 Files in the configuration directory have preference. 2014-12-09 12:05:18 +01:00
Juan RP
53c6a5d1d7 xbps_transaction_commit: if the pkg RSA signature is invalid print rval too. 2014-12-01 12:52:26 +01:00
Juan RP
c47beef740 xbps_transaction_commit: if pkg sha256 hash is invalid print rval. 2014-12-01 12:47:29 +01:00
Juan RP
4479bff03e repo: if local repodata archive is incomplete, remove it. 2014-11-29 08:44:21 +01:00
Juan RP
fe9a795995 xbps-{install,query}: added -M --memory-sync option. 
This explicitly enables the in memory fetch/store of remote repository
data archives mode, ignoring existing on-disk repodata archives.

This changes the previous behaviour of falling back to this mode if no
on-disk repodata archives were found.

Thanks to @Gottox and @dominikh for comments.
 2014-11-27 10:42:05 +01:00
Juan RP
7401ea3e64 Added support to fetch remote repodata on the fly. 
See the NEWS file for more information.
 2014-11-26 16:07:16 +01:00
Juan RP
89d11e871f xbps-{install,query}: added -i to ignore repos defined in xbps.d. 
See the NEWS file for more information.
 2014-11-21 10:56:41 +01:00
Juan RP
1789e527a9 Gratuitous ABI break: xbps_binpkg_get_xxx() -> xbps_archive_fetch_xxx(). 2014-11-21 09:51:57 +01:00
Juan RP
1bae26606e Introduce xbps_{pkgdb,rpool}_get_pkg_fulldeptree(). 
These routines return a xbps_array_t with a full sorted dependency graph
for the target pkg, by querying pkgdb or rpool.

Update xbps-query(8) to use the new libxbps API.
 2014-11-20 09:23:51 +01:00
Juan RP
eb90fcc50c xbps_binpkg_{arch,pkgver}: return a buffer of matched string instead. 
... otherwise will pass an invalid pointer to free(3) later on.
 2014-11-19 11:56:16 +01:00
Juan RP
428a747fad Fix #69 (No way to set globally a custom architecture) 
The "architecture" configuration keyword is now available to override
the native machine architecture returned by (uname(2)).

The XBPS_ARCH environment variable still has preference.
 2014-11-19 11:36:09 +01:00
Juan RP
b2bc7af66e Fix #68 (xbps_binpkg_arch() asserts if arch contains a dash) 2014-11-19 11:14:37 +01:00
Juan RP
c549252223 xbps_pkg_version: minor optimization. 2014-11-18 16:11:43 +01:00
Juan RP
77c6c3e504 Introduce xbps_binpkg_get_file_into_fd() and use it for xbps-query(8) --cat. 
This allows you to print to stdout any file stored in a binary package,
locally or remotely!

$ xbps-query -R --cat=/usr/bin/ls coreutils > ls
$ file ls
ls: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.32, BuildID[sha1]=7a195fc46d1d5cdca32bfccd3b30f81784e342ed, stripped
$
 2014-11-17 18:43:08 +01:00
Juan RP
a6516505e9 xbps-query(8: added --cat=FILE mode support. 
- This mode prints to stdout the matching FILE stored in a binary package.
- ABI break: renamed xbps_get_pkg_plist_from_binpkg() xbps_binpkg_get_plist().
- Added xbps_binpkg_get_file() as a generic way to get pkg file contents.
- Removed useless comments from xbps_api_impl.h.
 2014-11-17 15:45:46 +01:00
Juan RP
3afb9d709d Get rid of repodata index-files; the archive is now 8x smaller. 
See the NEWS file for more information.
 2014-11-13 17:09:43 +01:00
Juan RP
2153c87464 lib/portableproplib/prop_array.c: comment out another debug printf. 2014-11-13 15:22:58 +01:00
Juan RP
3290df5d62 lib/portableproplib/prop_array.c: comment out a debug printf. 2014-11-13 15:22:13 +01:00
Juan RP
43c9497feb Introduce xbps_array_add_first() to insert obj at the head of array. 
The behaviour of this routine mimics the existing xbps_array_add() with
the difference that stored objects are moved to the right to insert
our object as the first element on the array.

Use this to add replaced packages in the transaction array at the head
rather than at the end, to preserve the proper sorting order.
 2014-11-13 15:18:21 +01:00
Juan RP
74c30556fc xbps_transaction_prepare: check for unresolved shlibs a bit early. 
It's just better if we check for unresolved shlibs earlier because
the transaction array will be smaller if there are replaced packages.
 2014-11-13 11:39:20 +01:00
Juan RP
04bde70969 xbps_init: print bestmatching value. 2014-11-07 10:18:01 +01:00
Juan RP
53f13d579e Added the "bestmatching" configuration keyword to enable pkg best matching. 
See the NEWS file for more information.
 2014-11-07 10:07:51 +01:00
Juan RP
6c76f6786d xbps_repo_open: do not create repodata file in locked mode. 
... we want a proper errno value (ENOENT) if the archive does not exist.
 2014-11-06 11:38:55 +01:00
Juan RP
5b522109f7 Replaced config/system {repo,preserve,virtualpkg}.d with a single directory. 
See the NEWS file for more information.
 2014-11-06 09:58:04 +01:00
Juan RP
9566a0e737 Re-add support for system virtualpkg.d (XBPS_SYS_VPKG_PATH). 
This is still useful to set distro defaults for virtual packages, with
the option to override them via /etc/xbps/virtualpkg.d.
 2014-11-05 09:40:32 +01:00
Juan RP
595136704e Get rid of system virtualpkg.d support (<prefix>/share/xbps/virtualpkg.d). 
Binary packages do not need to provide those virtualpkg configuration files
anymore; all vpkg info is now collected from pkgdb.
 2014-11-04 11:17:27 +01:00
Juan RP
5dba1108d1 lib/package_remove.c: simplify link relative check. 2014-10-25 10:32:58 +02:00
Juan RP
ff3960696f lib/package_remove.c: fix a memleak. 2014-10-25 08:08:04 +02:00
Juan RP
e75beec76f unpack: get rid of code that checks for modified symlinks. 
Unpacking those symlinks is so cheap that there's no point in wasting
resources just to check if those have been modified, just unpack them
unconditionally.
 2014-10-25 06:52:12 +02:00
Juan RP
5fe3594cb5 Make sure that modified symlinks are preserved. 
When removing a package, symlinks owned by this package that have been
modified should be preserved, unless the force flag is set via xbps-remove(8).
 2014-10-25 06:43:30 +02:00
Juan RP
b81dedb770 lib/transaction_package_replace.c: simplify. 2014-10-25 05:20:13 +02:00
Juan RP
789326cf3a xbps_repo_sync: fix regression introduced in 87ca42f3. 2014-10-24 11:16:24 +02:00
Juan RP
87ca42f399 Remove xdelta support: it never worked and wasn't fully implemented. 2014-10-24 11:04:51 +02:00
Juan RP
654c77df25 Switch back to uncompressed plists. 
There's no point in slowing down read performance just to save a few bytes.
 2014-10-24 10:15:41 +02:00
Juan RP
e35d0c202c unpack: simplify pkg metadata extraction. 
There's no need to internalize props.plist because there are no changes
compared to the pkg dictionary stored in the repo index, simply ignore it.
The code only cares for the files.plist to check for obsolete files.
 2014-10-21 09:25:15 +02:00
Juan RP
627a5afaaf Make sure that automatic/manual installation modes are set as expected. 2014-10-20 07:59:06 +02:00
Juan RP
231582e671 libxbps: make sure to not add dups in transaction for remove. 2014-10-19 11:22:17 +02:00
Juan RP
fb868454b2 libxbps: make sure to not add dups in transaction for install/update. 2014-10-19 11:00:40 +02:00
Juan RP
e884270e06 xbps_transaction_prepare: ignore pkgs that will be removed. 2014-10-18 16:07:52 +02:00
Juan RP
ff189fd210 Replaced redundant dependency sorting code with a simpler implementation. 
This fixes the issue found by "xbps-src bootstrap" when a package
without "provides" was declared as a virtual package.
 2014-10-18 12:35:47 +02:00
Juan RP
adc0643ee4 Fully switch to zplists. 2014-10-17 10:27:58 +02:00
Juan RP
b1eb62a2df lib/package_unpack.c: switch pkg meta files to zplist too. 2014-10-17 10:23:12 +02:00
Juan RP
fc368e159d lib/portableproplib/prop_zlib.c: use a stack buffer to process compressed chunks. 2014-10-17 10:12:12 +02:00
Juan RP
83f5e35ec7 pkgdb: switch to zplists by default. 2014-10-17 10:11:56 +02:00
Juan RP
47310d3408 lib/archive.c: remove support to read zplists in archives. 
It was never used and the binpkgs are already compressed...
 2014-10-17 10:10:16 +02:00
Juan RP
d7633e88e0 Fix #62 (Dup replaced pkgs in transaction) 2014-10-17 09:52:32 +02:00
Juan RP
1c20086896 Package remove: disable file owner checks if euid==0. 
All package files even not owned by root should be removed, so make sure
that those checks return success while being root.

This fixes package removal for polkit, that had /etc/polkit/rules.d
files owned by the polkitd user.
 2014-10-17 09:17:07 +02:00
Juan RP
fe76af7702 proplib: use GCC atomic builtins if supported. 2014-10-09 14:41:43 +02:00
Juan RP
09c630a825 lib/transaction_commit.c: CID 62740 (toctou) 2014-10-08 10:13:21 +02:00
Juan RP
513f8a2bae lib/repo.c: CID 62757 (toctou) 2014-10-08 10:00:17 +02:00
Juan RP
805f6aa1b2 lib/repo_sync.c: CID 62763 (toctou) 2014-10-08 09:55:12 +02:00
Juan RP
0c74a5d7fe Revert "lib/portableproplib/prop_object.c: CID 62694 (data race condition)" 
This reverts commit dc63aed221.
 2014-10-07 11:51:53 +02:00
Juan RP
967acd82b0 lib/fetch/http.c: CID 62725 (NULL pointer dereference) 2014-10-07 11:12:04 +02:00
Juan RP
a6cdd9a698 lib/fetch/common.c: CID 62709 (NULL pointer dereference) 2014-10-07 11:07:24 +02:00
Juan RP
6e7c160195 lib/fetch/file.c: CID 62701 (NULL pointer dereference) 2014-10-07 11:02:12 +02:00
Juan RP
d434b44cfc lib/fetch/http.c: CID 62698 (NULL pointer dereference) 2014-10-07 10:51:37 +02:00
Juan RP
dc63aed221 lib/portableproplib/prop_object.c: CID 62694 (data race condition) 2014-10-07 10:27:07 +02:00
Juan RP
9c5af90fae lib/portableproplib/prop_object.c: CID 62703 (argument cannot be negative) 2014-10-07 10:23:02 +02:00
Juan RP
6a02cb6534 lib/portableproplib/prop_data.c: CID 62728 (integer overflowed argument) 2014-10-07 10:19:32 +02:00
Juan RP
3a71db1d0b lib/pubkey2fp.c: fix CID 62724 correctly. 2014-10-07 09:34:14 +02:00
Juan RP
ec438c36f9 Fix 1a19adf85c correctly. 2014-10-07 09:18:28 +02:00
Juan RP
680abe50e7 lib/fetch/ftp.c: CID 62745 (unusued value) 2014-10-07 08:25:57 +02:00
Juan RP
fe87bc1a88 lib/util.c: CID 62710 (dead code) 2014-10-07 08:16:45 +02:00
Juan RP
a730a61df9 lib/initend.c: CID 62720 (NULL pointer dereference) 2014-10-07 07:59:07 +02:00
Juan RP
4be2a0ee84 lib/pkgdb.c: CID 62719 (NULL pointer dereference) 2014-10-07 07:57:38 +02:00
Juan RP
fcf464d2fa lib/transaction_sortdeps.c: CID 62717 (NULL pointer dereference) 2014-10-07 07:45:20 +02:00
Juan RP
1a19adf85c lib/transaction_commit.c: CID 62716 (argument cannot be negative) 2014-10-07 07:29:58 +02:00
Juan RP
9fc6c9d70e lib/repo.c: CID 62706 (argument cannot be negative) 2014-10-07 07:27:45 +02:00
Juan RP
3a77ab0847 lib/download.c: CID 62691 (dereference NULL check) 2014-10-06 08:23:34 +02:00
Juan RP
fae4ef0cd6 lib/pubkey2fp.c: CID 62724 (dereference NULL return value) 2014-10-06 08:17:53 +02:00
Juan RP
a6f128a578 lib/plist.c: CID 62704 (argument cannot be negative) 2014-10-05 13:22:28 +02:00
Juan RP
be256ed77b lib/repo.c: fix CID 62783 correctly 2014-10-05 13:11:59 +02:00
Juan RP
68ef66eb51 lib/fetch/fetch.c: CID 62784 (uninitialized pointer read) 2014-10-05 13:10:05 +02:00
Juan RP
8ccb48e65b lib/initend.c: CID 62697 (dereference before NULL check) 2014-10-05 12:55:07 +02:00
Juan RP
7310322cbf lib/transaction_package_replace.c: CID 62693 (dereference NULL return value) 2014-10-05 12:50:50 +02:00
Juan RP
66292180a3 lib/repo.c: CID 62671 (unchecked return value) 2014-10-05 12:22:18 +02:00
Juan RP
2212a05f89 lib/download.c: CID 62696 (dead code) 2014-10-05 12:13:34 +02:00
Juan RP
44f5fb107e lib/fetch/fetch.c: CID 62738 (unused value) 2014-10-05 12:01:25 +02:00
Juan RP
89b8c61c47 lib/package_unpack.c: remove unused var (CID 62731) 2014-10-05 11:57:20 +02:00
Juan RP
c3dc804bc0 lib/fetch/http.c: try to fix CID 62683 (resource leak) 2014-10-05 10:32:09 +02:00
Juan RP
25e8fca7b4 lib/fetch/common.c: fix CID 62681 correctly (resource leak). 2014-10-05 10:21:18 +02:00
Juan RP
23fccb17f7 lib/transaction_revdeps.c: use-after-free (CID 62765) 2014-10-05 09:18:59 +02:00
Juan RP
3378c4487d lib/package_config_files.c: resource leak (CID 62682) 2014-10-05 09:13:03 +02:00
Juan RP
c1959b3915 lib/fetch/common.c: resource leak (CID 62681) 2014-10-05 09:08:05 +02:00
Juan RP
9d90c75fcc lib/fetch/http.c: buffer not NUL terminated (CID 62666) 2014-10-05 09:04:16 +02:00
Juan RP
6dcac6a840 lib/transaction_sortdeps.c: resource leak (CID 62688) 2014-10-05 08:12:49 +02:00
Juan RP
b28e85bfaa lib/repo_pkgdeps.c: resource leak (CID 62700) 2014-10-05 07:38:20 +02:00
Juan RP
0608e0057f lib/repo.c: fix build after aa8d88272e. 2014-10-05 07:38:14 +02:00
Juan RP
aa8d88272e lib/repo.c: resource leak (CID 62715) 2014-10-05 07:32:43 +02:00
Juan RP
4ae3d03594 lib/transaction_revdeps.c: resource leak (CID 62723) 2014-10-05 07:29:23 +02:00
Juan RP
aae88aa253 lib/verifysig.c: resource leak (CID 62727) 2014-10-05 07:27:13 +02:00
Juan RP
dd851f18a2 lib/package_unpack.c: zero out struct (CID 62755) 2014-10-05 07:12:30 +02:00
Juan RP
96a117c558 lib/repo_pkgdeps.c: fix a double free in error branch (CID 62754) 2014-10-05 07:09:40 +02:00
Juan RP
bc9ddcfcc8 lib/initend.c: rename a var to make gcc-4.6.x happy. 2014-10-04 22:02:56 +02:00
Juan RP
2fe35a5bf3 lib/package_unpack.c: do not initialize xucd at all, unnecessary. 
Initializing with {0} wasn't understood with gcc-4.6.x on travis-ci,
so just remove it.
 2014-10-04 21:59:47 +02:00
Juan RP
742af69185 Fix libxbps/update_shlibs:shlib_bump_revdep_diff test. 
How to reproduce it:

	- A-1.0_1 provides liba.so.1
	- B-1.0_1 provides libb.so.1
	- C-1.0_1 requires liba.so.1 and libb.so.1
	- A-2.0_1 provides liba.so.2
	- C-2.0_1 required liba.so.2

This test case failed because it was checking the required shared libraries
from current installed package, rather than the updated pkg in transaction.
 2014-09-29 15:25:09 +02:00
Enno Boland
42f0152dce trans_find_pkg(): search for reverts match with correct pkgver 2014-09-28 22:22:20 +02:00
Juan RP
2711b07b77 Fix package files removal with only read bit set. 
The previous code was checking incorrectly if the file had the write
bit set, and this is wrong because a package could have files with
only the read bit set (0444).
 2014-09-28 13:33:15 +02:00
Juan RP
72cefcfc83 Introduce xbps_mmap_file() and use it in strategic points. 
Rather than using a random buffer from stack or heap, and decide
what size to use, create a private memory mapped object...

This simplifies the code in lib/verifysig.c and xbps-create.
 2014-09-27 13:00:34 +02:00
Juan RP
97045960f9 xbps_pkg_reverts: style. 2014-09-27 11:28:29 +02:00
Enno Boland
b5a169b65c xbps_pkg_reverts: this function can do more than just return false! 2014-09-23 21:18:47 +02:00
Enno Boland
a421bf7db5 xbps_pkg_reverts: return bool instead of int. 2014-09-23 20:50:34 +02:00
Enno Boland
dbab3f2cfc xbps_pkg_reverts: use version instead of pkgname-version to find reverts 2014-09-23 18:22:57 +02:00
Enno Boland
50fb6c1605 rename xbps_pkgver_is_reverted to xbps_pkg_reverts 2014-09-23 13:54:06 +02:00
Enno Boland
cd9a9e78a8 lib/transaction_ops.c: trans_find_pkg will check the revert field too. 
- if a package on the repo has a lower version than installed
  libxbps will check if this package reverts the one installed
  and downgrades to it if so.
 2014-09-23 13:54:06 +02:00
Enno Boland
18204aeac1 lib/util.c: add function which tests if a given pkgver is reverted by a given pkg. 2014-09-23 13:54:06 +02:00
Enno Boland
5bbcdf2c62 lib/util_hash.c: enlarge read buffer for xbps_file_hash to increase performance. 2014-09-18 18:34:15 +02:00
Juan RP
f52eea34d4 xbps-install: abort transaction if there's insufficient disk space on rootdir. 
The free disk space wasn't computed correctly and xbps-install(8) wasn't
handling ENOSPC rval in xbps_transaction_prepare().
 2014-09-18 12:11:02 +02:00
Juan RP
741f8fbe04 lib/util_hash.c: update copyright year. 2014-09-17 07:24:00 +02:00
Juan RP
72c64c7626 xbps_file_hash: reduce memory footprint and process file in small chunks. 
With xbps-rindex(8) -c/-r being multithreaded, the memory usage was
insanely high in the build server, with peaks of almost 4GB (this depends
on the file size being processed and number of threads).

Process the file in small chunks instead to compute the SHA256 hash.
 2014-09-17 06:50:46 +02:00
Juan RP
6894980983 lib/package_msg.c: fix a heap overflow (noticed by @Gottox). 2014-09-16 09:13:32 +02:00
Juan RP
e902619220 Remove empty self replaced pkg arrays from pkgdb. 2014-09-14 18:16:43 +02:00
Juan RP
ac2c517bd7 Fixed install/update tests on pkgs with no files. 2014-09-14 18:04:10 +02:00
Juan RP
c9514ad617 libxbps: fixed replaces/replace_vpkg test case. 2014-09-14 12:50:17 +02:00
Juan RP
2b7c4d568a Remove pkg self replacement from pkgdb; this must not be propagated. 2014-09-13 18:14:04 +02:00
Juan RP
dea31f0a15 Add xbps_remove_{pkgname,string}_from_array() to the API. 2014-09-13 18:13:25 +02:00
Juan RP
b42c3d8498 lib/pkgdb_conversion.c: avoid copying dangling pointer if "repository-origin" is unexistent. 2014-09-13 16:59:19 +02:00
Juan RP
d67f8bdc8c xbps_register_pkg: do not modify the transaction pkg dictionary, use a copy instead. 
Due to not using a copy the replace tests were failing at the configure phase,
because the "transaction" object was removed.
 2014-09-13 13:31:56 +02:00
Juan RP
598022a60b xbps_transaction_commit: add more debugging to know the unconfigured pkg reason. 2014-09-13 12:21:49 +02:00
Juan RP
411480e43d pkgdb: repository-origin -> repository to match the repo pkg obj. 2014-09-13 10:49:13 +02:00
Juan RP
287665009b Drop unused headers. 2014-09-13 08:54:12 +02:00
Juan RP
39aca1bbc9 Implement shlib checks for all pkg revdeps in the transaction. 
Added three new test cases to verify its correctness.
 2014-09-12 11:49:34 +02:00
Juan RP
4978fe9844 lib/transaction_package_replace.c: misc optimizations. 2014-09-11 17:55:05 +02:00
Juan RP
4ab831888a xbps_repo_sync: fix swapped args (Hi Tox!) 2014-09-11 13:38:26 +02:00
Juan RP
2207517e13 Disable best pkg matching code; see NEWS for more information. 2014-09-11 12:19:52 +02:00
Juan RP
ed6b3c00f5 xbps_entry_install_conf_file: fix non debug build. 2014-09-11 11:56:23 +02:00
Juan RP
e1124800a5 lib/repo_sync.c: xbps_fetch_file_dest() expects 4 args not 5 (hi Tox) 2014-09-11 11:51:20 +02:00
Enno Boland
4689b07b85 lib/repo_sync.c: use xbps_fetch_file_dest() instead of xbps_fetch_delta(). 
Until the generation of deltas does not work reliably just download
the repo files instead of trying to get the delta.
 2014-09-11 11:39:54 +02:00
Juan RP
30ea08e605 lib/transaction_ops.c: detect updates when an exact pkg version is set. 2014-09-11 11:13:20 +02:00
Juan RP
e4ff957e42 xbps_find_pkg_orphans: fix regression adding false positives. 2014-09-11 09:05:57 +02:00
Juan RP
dba767fb05 lib/pkgdb_conversion.c: remove metafile-sha256 obj if pkg contains no files. 2014-09-11 08:18:03 +02:00
Juan RP
01dbb968dd Welcome pkgdb-0.38. 2014-09-11 00:12:12 +02:00