fba65ad9da
This change ensures that no multiple versions of the same pkg are added to the transaction; if a new version of the same package is being added as a dependency, compare stored and current and use the greatest one. This fixes the recent issue seen in the aarch64 builders, where two versions of the same package were added to the transaction. Added a new test case.
115 lines
3.5 KiB
C
115 lines
3.5 KiB
C
/*-
|
|
* Copyright (c) 2014-2020 Juan Romero Pardines.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
|
|
#include "xbps_api_impl.h"
|
|
|
|
int HIDDEN
|
|
xbps_transaction_store(struct xbps_handle *xhp, xbps_array_t pkgs,
|
|
xbps_dictionary_t pkgrd, const char *tract, bool autoinst)
|
|
{
|
|
xbps_dictionary_t d, pkgd;
|
|
xbps_array_t replaces;
|
|
const char *pkgver, *curpkgver, *repo;
|
|
char pkgname[XBPS_NAME_SIZE], *self_replaced;
|
|
int rv;
|
|
|
|
if (!xbps_dictionary_get_cstring_nocopy(pkgrd, "pkgver", &pkgver)) {
|
|
abort();
|
|
}
|
|
if (!xbps_pkg_name(pkgname, sizeof(pkgname), pkgver)) {
|
|
abort();
|
|
}
|
|
d = xbps_find_pkg_in_array(pkgs, pkgname, NULL);
|
|
if (xbps_object_type(d) == XBPS_TYPE_DICTIONARY) {
|
|
/* compare version stored in transaction vs current */
|
|
if (!xbps_dictionary_get_cstring_nocopy(d, "pkgver", &curpkgver)) {
|
|
abort();
|
|
}
|
|
rv = xbps_cmpver(pkgver, curpkgver);
|
|
if (rv == 0 || rv == -1) {
|
|
/* same version or stored version greater than current */
|
|
return 0;
|
|
} else {
|
|
/*
|
|
* Current version is greater than stored,
|
|
* replace stored with current.
|
|
*/
|
|
if (!xbps_remove_pkg_from_array_by_pkgver(pkgs, curpkgver)) {
|
|
abort();
|
|
}
|
|
xbps_dbg_printf(xhp, "[trans] replaced %s with %s\n",
|
|
curpkgver, pkgver);
|
|
}
|
|
}
|
|
|
|
if ((pkgd = xbps_dictionary_copy_mutable(pkgrd)) == NULL)
|
|
return ENOMEM;
|
|
|
|
/*
|
|
* Add required objects into package dep's dictionary.
|
|
*/
|
|
if (autoinst && !xbps_dictionary_set_bool(pkgd, "automatic-install", true))
|
|
goto err;
|
|
|
|
/*
|
|
* Set a replaces to itself, so that virtual packages are always replaced.
|
|
*/
|
|
if ((replaces = xbps_dictionary_get(pkgd, "replaces")) == NULL)
|
|
replaces = xbps_array_create();
|
|
|
|
self_replaced = xbps_xasprintf("%s>=0", pkgname);
|
|
xbps_array_add_cstring(replaces, self_replaced);
|
|
free(self_replaced);
|
|
|
|
if (!xbps_dictionary_set(pkgd, "replaces", replaces))
|
|
goto err;
|
|
|
|
/*
|
|
* Add the dictionary into the unsorted queue.
|
|
*/
|
|
if (!xbps_array_add(pkgs, pkgd))
|
|
goto err;
|
|
|
|
xbps_dictionary_get_cstring_nocopy(pkgd, "repository", &repo);
|
|
|
|
xbps_set_cb_state(xhp, XBPS_STATE_TRANS_ADDPKG, 0, pkgver,
|
|
"Found %s (%s) in repository %s", pkgver, tract, repo);
|
|
|
|
xbps_dbg_printf(xhp, "Added `%s' into the dependency list (%s)\n",
|
|
pkgver, repo);
|
|
|
|
xbps_object_release(pkgd);
|
|
|
|
return 0;
|
|
err:
|
|
xbps_object_release(pkgd);
|
|
return EINVAL;
|
|
}
|