6b84d75dc1
Found by clang-analyzer. Bug Summary File: lib/transaction_dictionary.c Warning: line 68, column 2 Value stored to 'rootdir_free_size' is never read
358 lines
10 KiB
C
358 lines
10 KiB
C
/*-
|
|
* Copyright (c) 2009-2015 Juan Romero Pardines.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdbool.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
#include <sys/statvfs.h>
|
|
|
|
#include "xbps_api_impl.h"
|
|
|
|
/**
|
|
* @file lib/transaction_dictionary.c
|
|
* @brief Transaction handling routines
|
|
* @defgroup transaction Transaction handling functions
|
|
*
|
|
* The following image shows off the full transaction dictionary returned
|
|
* by xbps_transaction_prepare().
|
|
*
|
|
* @image html images/xbps_transaction_dictionary.png
|
|
*
|
|
* Legend:
|
|
* - <b>Salmon bg box</b>: The transaction dictionary.
|
|
* - <b>White bg box</b>: mandatory objects.
|
|
* - <b>Grey bg box</b>: optional objects.
|
|
* - <b>Green bg box</b>: possible value set in the object, only one of them
|
|
* will be set.
|
|
*
|
|
* Text inside of white boxes are the key associated with the object, its
|
|
* data type is specified on its edge, i.e string, array, integer, dictionary.
|
|
*/
|
|
|
|
static int
|
|
compute_transaction_stats(struct xbps_handle *xhp)
|
|
{
|
|
xbps_dictionary_t pkg_metad;
|
|
xbps_object_iterator_t iter;
|
|
xbps_object_t obj;
|
|
struct statvfs svfs;
|
|
uint64_t rootdir_free_size, tsize, dlsize, instsize, rmsize;
|
|
uint32_t inst_pkgcnt, up_pkgcnt, cf_pkgcnt, rm_pkgcnt, dl_pkgcnt;
|
|
const char *tract, *pkgver, *repo;
|
|
|
|
inst_pkgcnt = up_pkgcnt = cf_pkgcnt = rm_pkgcnt = dl_pkgcnt = 0;
|
|
tsize = dlsize = instsize = rmsize = 0;
|
|
|
|
iter = xbps_array_iter_from_dict(xhp->transd, "packages");
|
|
if (iter == NULL)
|
|
return EINVAL;
|
|
|
|
while ((obj = xbps_object_iterator_next(iter)) != NULL) {
|
|
bool preserve = false;
|
|
/*
|
|
* Count number of pkgs to be removed, configured,
|
|
* installed and updated.
|
|
*/
|
|
xbps_dictionary_get_cstring_nocopy(obj, "pkgver", &pkgver);
|
|
xbps_dictionary_get_cstring_nocopy(obj, "transaction", &tract);
|
|
xbps_dictionary_get_cstring_nocopy(obj, "repository", &repo);
|
|
xbps_dictionary_get_bool(obj, "preserve", &preserve);
|
|
|
|
if (strcmp(tract, "configure") == 0) {
|
|
cf_pkgcnt++;
|
|
continue;
|
|
} else if (strcmp(tract, "install") == 0) {
|
|
inst_pkgcnt++;
|
|
} else if (strcmp(tract, "update") == 0) {
|
|
up_pkgcnt++;
|
|
} else if (strcmp(tract, "remove") == 0) {
|
|
rm_pkgcnt++;
|
|
}
|
|
|
|
tsize = 0;
|
|
if ((strcmp(tract, "install") == 0) ||
|
|
(strcmp(tract, "update") == 0)) {
|
|
xbps_dictionary_get_uint64(obj,
|
|
"installed_size", &tsize);
|
|
instsize += tsize;
|
|
if (xbps_repository_is_remote(repo) &&
|
|
!xbps_binpkg_exists(xhp, obj)) {
|
|
xbps_dictionary_get_uint64(obj,
|
|
"filename-size", &tsize);
|
|
/* signature file: 512 bytes */
|
|
tsize += 512;
|
|
dlsize += tsize;
|
|
instsize += tsize;
|
|
dl_pkgcnt++;
|
|
xbps_dictionary_set_bool(obj, "download", true);
|
|
}
|
|
}
|
|
/*
|
|
* If removing or updating a package, get installed_size
|
|
* from pkg's metadata dictionary.
|
|
*/
|
|
if ((strcmp(tract, "remove") == 0) ||
|
|
((strcmp(tract, "update") == 0) && !preserve)) {
|
|
char *pkgname;
|
|
|
|
pkgname = xbps_pkg_name(pkgver);
|
|
assert(pkgname);
|
|
pkg_metad = xbps_pkgdb_get_pkg(xhp, pkgname);
|
|
free(pkgname);
|
|
if (pkg_metad == NULL)
|
|
continue;
|
|
xbps_dictionary_get_uint64(pkg_metad,
|
|
"installed_size", &tsize);
|
|
rmsize += tsize;
|
|
}
|
|
}
|
|
xbps_object_iterator_release(iter);
|
|
|
|
if (instsize > rmsize) {
|
|
instsize -= rmsize;
|
|
rmsize = 0;
|
|
} else if (rmsize > instsize) {
|
|
rmsize -= instsize;
|
|
instsize = 0;
|
|
} else {
|
|
instsize = rmsize = 0;
|
|
}
|
|
|
|
if (!xbps_dictionary_set_uint32(xhp->transd,
|
|
"total-install-pkgs", inst_pkgcnt))
|
|
return EINVAL;
|
|
if (!xbps_dictionary_set_uint32(xhp->transd,
|
|
"total-update-pkgs", up_pkgcnt))
|
|
return EINVAL;
|
|
if (!xbps_dictionary_set_uint32(xhp->transd,
|
|
"total-configure-pkgs", cf_pkgcnt))
|
|
return EINVAL;
|
|
if (!xbps_dictionary_set_uint32(xhp->transd,
|
|
"total-remove-pkgs", rm_pkgcnt))
|
|
return EINVAL;
|
|
if (!xbps_dictionary_set_uint32(xhp->transd,
|
|
"total-download-pkgs", dl_pkgcnt))
|
|
return EINVAL;
|
|
if (!xbps_dictionary_set_uint64(xhp->transd,
|
|
"total-installed-size", instsize))
|
|
return EINVAL;
|
|
if (!xbps_dictionary_set_uint64(xhp->transd,
|
|
"total-download-size", dlsize))
|
|
return EINVAL;
|
|
if (!xbps_dictionary_set_uint64(xhp->transd,
|
|
"total-removed-size", rmsize))
|
|
return EINVAL;
|
|
|
|
/* Get free space from target rootdir: return ENOSPC if there's not enough space */
|
|
if (statvfs(xhp->rootdir, &svfs) == -1) {
|
|
xbps_dbg_printf(xhp, "%s: statvfs failed: %s\n", __func__, strerror(errno));
|
|
return 0;
|
|
}
|
|
/* compute free space on disk */
|
|
rootdir_free_size = svfs.f_bfree * svfs.f_bsize;
|
|
|
|
if (!xbps_dictionary_set_uint64(xhp->transd,
|
|
"disk-free-size", rootdir_free_size))
|
|
return EINVAL;
|
|
|
|
if (instsize > rootdir_free_size)
|
|
return ENOSPC;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int HIDDEN
|
|
xbps_transaction_init(struct xbps_handle *xhp)
|
|
{
|
|
xbps_array_t array;
|
|
|
|
if (xhp->transd != NULL)
|
|
return 0;
|
|
|
|
if ((xhp->transd = xbps_dictionary_create()) == NULL)
|
|
return ENOMEM;
|
|
|
|
if ((array = xbps_array_create()) == NULL) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return ENOMEM;
|
|
}
|
|
if (!xbps_dictionary_set(xhp->transd, "packages", array)) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return EINVAL;
|
|
}
|
|
xbps_object_release(array);
|
|
|
|
if ((array = xbps_array_create()) == NULL) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return ENOMEM;
|
|
}
|
|
if (!xbps_dictionary_set(xhp->transd, "missing_deps", array)) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return EINVAL;
|
|
}
|
|
xbps_object_release(array);
|
|
|
|
if ((array = xbps_array_create()) == NULL) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return ENOMEM;
|
|
}
|
|
if (!xbps_dictionary_set(xhp->transd, "missing_shlibs", array)) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return EINVAL;
|
|
}
|
|
xbps_object_release(array);
|
|
|
|
if ((array = xbps_array_create()) == NULL) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return ENOMEM;
|
|
}
|
|
if (!xbps_dictionary_set(xhp->transd, "conflicts", array)) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return EINVAL;
|
|
}
|
|
xbps_object_release(array);
|
|
|
|
return 0;
|
|
}
|
|
|
|
int
|
|
xbps_transaction_prepare(struct xbps_handle *xhp)
|
|
{
|
|
xbps_array_t array, pkgs, edges;
|
|
unsigned int i, cnt;
|
|
int rv = 0;
|
|
|
|
if (xhp->transd == NULL)
|
|
return ENXIO;
|
|
|
|
/*
|
|
* Collect dependencies for pkgs in transaction.
|
|
*/
|
|
if ((edges = xbps_array_create()) == NULL)
|
|
return ENOMEM;
|
|
/*
|
|
* The edges are also appended after its dependencies have been
|
|
* collected; the edges at the original array are removed later.
|
|
*/
|
|
pkgs = xbps_dictionary_get(xhp->transd, "packages");
|
|
assert(xbps_object_type(pkgs) == XBPS_TYPE_ARRAY);
|
|
cnt = xbps_array_count(pkgs);
|
|
for (i = 0; i < cnt; i++) {
|
|
xbps_dictionary_t pkgd;
|
|
xbps_string_t str;
|
|
const char *tract = NULL;
|
|
|
|
pkgd = xbps_array_get(pkgs, i);
|
|
str = xbps_dictionary_get(pkgd, "pkgver");
|
|
xbps_dictionary_get_cstring_nocopy(pkgd, "transaction", &tract);
|
|
if ((strcmp(tract, "remove") == 0) || strcmp(tract, "hold") == 0)
|
|
continue;
|
|
|
|
assert(xbps_object_type(str) == XBPS_TYPE_STRING);
|
|
|
|
if (!xbps_array_add(edges, str))
|
|
return ENOMEM;
|
|
|
|
if ((rv = xbps_repository_find_deps(xhp, pkgs, pkgd)) != 0)
|
|
return rv;
|
|
|
|
if (!xbps_array_add(pkgs, pkgd))
|
|
return ENOMEM;
|
|
}
|
|
/* ... remove dup edges at head */
|
|
for (i = 0; i < xbps_array_count(edges); i++) {
|
|
const char *pkgver;
|
|
xbps_array_get_cstring_nocopy(edges, i, &pkgver);
|
|
xbps_remove_pkg_from_array_by_pkgver(pkgs, pkgver);
|
|
}
|
|
xbps_object_release(edges);
|
|
|
|
/*
|
|
* Check for packages to be replaced.
|
|
*/
|
|
if ((rv = xbps_transaction_package_replace(xhp, pkgs)) != 0) {
|
|
xbps_object_release(xhp->transd);
|
|
xhp->transd = NULL;
|
|
return rv;
|
|
}
|
|
/*
|
|
* If there are missing deps or revdeps bail out.
|
|
*/
|
|
xbps_transaction_revdeps(xhp, pkgs);
|
|
array = xbps_dictionary_get(xhp->transd, "missing_deps");
|
|
if (xbps_array_count(array)) {
|
|
if (xhp->flags & XBPS_FLAG_FORCE_REMOVE_REVDEPS) {
|
|
xbps_dbg_printf(xhp, "[trans] continuing with broken reverse dependencies!");
|
|
} else {
|
|
return ENODEV;
|
|
}
|
|
}
|
|
/*
|
|
* If there are package conflicts bail out.
|
|
*/
|
|
xbps_transaction_conflicts(xhp, pkgs);
|
|
array = xbps_dictionary_get(xhp->transd, "conflicts");
|
|
if (xbps_array_count(array))
|
|
return EAGAIN;
|
|
/*
|
|
* Check for unresolved shared libraries.
|
|
*/
|
|
if (xbps_transaction_shlibs(xhp, pkgs,
|
|
xbps_dictionary_get(xhp->transd, "missing_shlibs"))) {
|
|
if (xhp->flags & XBPS_FLAG_FORCE_REMOVE_REVDEPS) {
|
|
xbps_dbg_printf(xhp, "[trans] continuing with unresolved shared libraries!");
|
|
} else {
|
|
return ENOEXEC;
|
|
}
|
|
}
|
|
/*
|
|
* Add transaction stats for total download/installed size,
|
|
* number of packages to be installed, updated, configured
|
|
* and removed to the transaction dictionary.
|
|
*/
|
|
if ((rv = compute_transaction_stats(xhp)) != 0) {
|
|
return rv;
|
|
}
|
|
/*
|
|
* Remove now unneeded objects.
|
|
*/
|
|
xbps_dictionary_remove(xhp->transd, "missing_shlibs");
|
|
xbps_dictionary_remove(xhp->transd, "missing_deps");
|
|
xbps_dictionary_remove(xhp->transd, "conflicts");
|
|
xbps_dictionary_make_immutable(xhp->transd);
|
|
|
|
return 0;
|
|
}
|