06c9891ae3
This commit implements multiple performance improvements to the transaction code: - Don't process xbps_pkg_name() N times each time we access its package dictionary (via pkgdb or rpool), just do it once at xbps_pkgdb_init() time. At pkgdb init time, it just creates a property in pkgdb, "pkgname". At rpool time, each time a package is accessed, the "pkgname" string property is added. - The package transaction dictionary contains the "transaction" object to know what's the pkg type. This has been changed to an uint8, this simplifies the logic and it's faster than checking a string object. See xbps_trans_type_t and xbps_transaction_pkg_type(). - Fixed the issue that was marked with XXX in transaction shlibs checking code. This has been fixed and improved and resources are now just freed as expected. - Simplified random code all over the place, avoiding unnecessary allocations or operations. - Rename some transaction files to have a better description. This is my first rototill to the code in 2020.
279 lines
8.1 KiB
C
279 lines
8.1 KiB
C
/*-
|
|
* Copyright (c) 2009-2020 Juan Romero Pardines.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdbool.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
#include <ctype.h>
|
|
#include <unistd.h>
|
|
#include <limits.h>
|
|
#include <locale.h>
|
|
|
|
#include "xbps_api_impl.h"
|
|
|
|
/**
|
|
* @file lib/transaction_commit.c
|
|
* @brief Transaction handling routines
|
|
* @defgroup transaction Transaction handling functions
|
|
*
|
|
* The following image shows off the full transaction dictionary returned
|
|
* by xbps_transaction_prepare().
|
|
*
|
|
* @image html images/xbps_transaction_dictionary.png
|
|
*
|
|
* Legend:
|
|
* - <b>Salmon bg box</b>: The transaction dictionary.
|
|
* - <b>White bg box</b>: mandatory objects.
|
|
* - <b>Grey bg box</b>: optional objects.
|
|
* - <b>Green bg box</b>: possible value set in the object, only one of them
|
|
* will be set.
|
|
*
|
|
* Text inside of white boxes are the key associated with the object, its
|
|
* data type is specified on its edge, i.e string, array, integer, dictionary.
|
|
*/
|
|
|
|
int
|
|
xbps_transaction_commit(struct xbps_handle *xhp)
|
|
{
|
|
xbps_object_t obj;
|
|
xbps_object_iterator_t iter;
|
|
xbps_trans_type_t ttype;
|
|
const char *pkgver = NULL;
|
|
int rv = 0;
|
|
bool update;
|
|
|
|
setlocale(LC_ALL, "");
|
|
|
|
assert(xbps_object_type(xhp->transd) == XBPS_TYPE_DICTIONARY);
|
|
/*
|
|
* Create cachedir if necessary.
|
|
*/
|
|
if (xbps_mkpath(xhp->cachedir, 0755) == -1) {
|
|
if (errno != EEXIST) {
|
|
xbps_set_cb_state(xhp, XBPS_STATE_TRANS_FAIL,
|
|
errno, NULL,
|
|
"[trans] cannot create cachedir `%s': %s",
|
|
xhp->cachedir, strerror(errno));
|
|
return errno;
|
|
}
|
|
}
|
|
if (chdir(xhp->cachedir) == -1) {
|
|
xbps_set_cb_state(xhp, XBPS_STATE_TRANS_FAIL,
|
|
errno, NULL,
|
|
"[trans] failed to change dir to cachedir `%s': %s",
|
|
xhp->cachedir, strerror(errno));
|
|
return errno;
|
|
}
|
|
iter = xbps_array_iter_from_dict(xhp->transd, "packages");
|
|
if (iter == NULL)
|
|
return EINVAL;
|
|
|
|
/*
|
|
* Download and verify binary packages.
|
|
*/
|
|
if ((rv = xbps_transaction_fetch(xhp, iter)) != 0) {
|
|
xbps_dbg_printf(xhp, "[trans] failed to fetch and verify binpkgs: "
|
|
"%s\n", strerror(rv));
|
|
goto out;
|
|
}
|
|
if (xhp->flags & XBPS_FLAG_DOWNLOAD_ONLY) {
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* Collect files in the transaction and find some issues
|
|
* like multiple packages installing the same file.
|
|
*/
|
|
xbps_set_cb_state(xhp, XBPS_STATE_TRANS_FILES, 0, NULL, NULL);
|
|
if ((rv = xbps_transaction_files(xhp, iter)) != 0) {
|
|
xbps_dbg_printf(xhp, "[trans] failed to verify transaction files: "
|
|
"%s\n", strerror(rv));
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* Install, update, configure or remove packages as specified
|
|
* in the transaction dictionary.
|
|
*/
|
|
xbps_set_cb_state(xhp, XBPS_STATE_TRANS_RUN, 0, NULL, NULL);
|
|
|
|
/*
|
|
* Create rootdir if necessary.
|
|
*/
|
|
if (xbps_mkpath(xhp->rootdir, 0750) == -1) {
|
|
rv = errno;
|
|
if (rv != EEXIST) {
|
|
xbps_set_cb_state(xhp, XBPS_STATE_TRANS_FAIL, errno, xhp->rootdir,
|
|
"[trans] failed to create rootdir `%s': %s",
|
|
xhp->rootdir, strerror(rv));
|
|
goto out;
|
|
}
|
|
}
|
|
if (chdir(xhp->rootdir) == -1) {
|
|
rv = errno;
|
|
xbps_set_cb_state(xhp, XBPS_STATE_UNPACK_FAIL, rv, xhp->rootdir,
|
|
"[trans] failed to chdir to rootdir `%s': %s",
|
|
xhp->rootdir, strerror(errno));
|
|
goto out;
|
|
}
|
|
while ((obj = xbps_object_iterator_next(iter)) != NULL) {
|
|
xbps_dictionary_get_cstring_nocopy(obj, "pkgver", &pkgver);
|
|
|
|
ttype = xbps_transaction_pkg_type(obj);
|
|
if (ttype == XBPS_TRANS_REMOVE) {
|
|
/*
|
|
* Remove package.
|
|
*/
|
|
update = false;
|
|
xbps_dictionary_get_bool(obj, "remove-and-update", &update);
|
|
rv = xbps_remove_pkg(xhp, pkgver, update);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf(xhp, "[trans] failed to "
|
|
"remove %s: %s\n", pkgver, strerror(rv));
|
|
goto out;
|
|
}
|
|
continue;
|
|
|
|
} else if (ttype == XBPS_TRANS_CONFIGURE) {
|
|
/*
|
|
* Reconfigure pending package.
|
|
*/
|
|
rv = xbps_configure_pkg(xhp, pkgver, false, false);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf(xhp, "[trans] failed to "
|
|
"configure %s: %s\n", pkgver, strerror(rv));
|
|
goto out;
|
|
}
|
|
continue;
|
|
|
|
} else if (ttype == XBPS_TRANS_UPDATE) {
|
|
/*
|
|
* Update a package: execute pre-remove action of
|
|
* existing package before unpacking new version.
|
|
*/
|
|
xbps_set_cb_state(xhp, XBPS_STATE_UPDATE, 0, pkgver, NULL);
|
|
rv = xbps_remove_pkg(xhp, pkgver, true);
|
|
if (rv != 0) {
|
|
xbps_set_cb_state(xhp,
|
|
XBPS_STATE_UPDATE_FAIL,
|
|
rv, pkgver,
|
|
"%s: [trans] failed to update "
|
|
"package `%s'", pkgver,
|
|
strerror(rv));
|
|
goto out;
|
|
}
|
|
} else if (ttype == XBPS_TRANS_HOLD) {
|
|
/*
|
|
* Package is on hold mode, ignore it.
|
|
*/
|
|
continue;
|
|
} else {
|
|
/* Install or reinstall package */
|
|
xbps_set_cb_state(xhp, XBPS_STATE_INSTALL, 0,
|
|
pkgver, NULL);
|
|
}
|
|
/*
|
|
* Unpack binary package.
|
|
*/
|
|
if ((rv = xbps_unpack_binary_pkg(xhp, obj)) != 0) {
|
|
xbps_dbg_printf(xhp, "[trans] failed to unpack "
|
|
"%s: %s\n", pkgver, strerror(rv));
|
|
goto out;
|
|
}
|
|
/*
|
|
* Register package.
|
|
*/
|
|
if ((rv = xbps_register_pkg(xhp, obj)) != 0) {
|
|
xbps_dbg_printf(xhp, "[trans] failed to register "
|
|
"%s: %s\n", pkgver, strerror(rv));
|
|
goto out;
|
|
}
|
|
}
|
|
/* if there are no packages to install or update we are done */
|
|
if (!xbps_dictionary_get(xhp->transd, "total-update-pkgs") &&
|
|
!xbps_dictionary_get(xhp->transd, "total-install-pkgs"))
|
|
goto out;
|
|
|
|
if (xhp->target_arch && strcmp(xhp->native_arch, xhp->target_arch)) {
|
|
/* if installing packages for target_arch, don't configure anything */
|
|
goto out;
|
|
/* do not configure packages if only unpacking is desired */
|
|
} else if (xhp->flags & XBPS_FLAG_UNPACK_ONLY) {
|
|
goto out;
|
|
}
|
|
|
|
xbps_object_iterator_reset(iter);
|
|
/* Force a pkgdb write for all unpacked pkgs in transaction */
|
|
if ((rv = xbps_pkgdb_update(xhp, true, true)) != 0)
|
|
goto out;
|
|
|
|
/*
|
|
* Configure all unpacked packages.
|
|
*/
|
|
xbps_set_cb_state(xhp, XBPS_STATE_TRANS_CONFIGURE, 0, NULL, NULL);
|
|
|
|
while ((obj = xbps_object_iterator_next(iter)) != NULL) {
|
|
xbps_dictionary_get_cstring_nocopy(obj, "pkgver", &pkgver);
|
|
ttype = xbps_transaction_pkg_type(obj);
|
|
if (ttype == XBPS_TRANS_REMOVE || ttype == XBPS_TRANS_HOLD ||
|
|
ttype == XBPS_TRANS_CONFIGURE) {
|
|
xbps_dbg_printf(xhp, "%s: skipping configuration for "
|
|
"%s: %d\n", __func__, pkgver, ttype);
|
|
continue;
|
|
}
|
|
update = false;
|
|
if (ttype == XBPS_TRANS_UPDATE)
|
|
update = true;
|
|
|
|
rv = xbps_configure_pkg(xhp, pkgver, false, update);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf(xhp, "%s: configure failed for "
|
|
"%s: %s\n", __func__, pkgver, strerror(rv));
|
|
goto out;
|
|
}
|
|
/*
|
|
* Notify client callback when a package has been
|
|
* installed or updated.
|
|
*/
|
|
if (update) {
|
|
xbps_set_cb_state(xhp, XBPS_STATE_UPDATE_DONE, 0,
|
|
pkgver, NULL);
|
|
} else {
|
|
xbps_set_cb_state(xhp, XBPS_STATE_INSTALL_DONE, 0,
|
|
pkgver, NULL);
|
|
}
|
|
}
|
|
|
|
out:
|
|
xbps_object_iterator_release(iter);
|
|
if (rv == 0) {
|
|
/* Force a pkgdb write for all unpacked pkgs in transaction */
|
|
rv = xbps_pkgdb_update(xhp, true, true);
|
|
}
|
|
return rv;
|
|
}
|