fdec663855
- Rename regpkgs_dictionary to regpkgdb_dictionary to better describe what is is.
- Change some funcs in plist.c to return a boolean rather than int.
- Hide more internal funcs off the API.
- Simplify xbps_repository_update_pkg() and remove its second arg.
- Hide implementation details in xbps_repository_pool, now to iterate over the
pool you have to use xbps_repository_pool_foreach and its struct
repository_pool_index.
- Introduce xbps_{init,end}, to initialize/destroy some stuff in the library.
- Introduce xbps_dbg_printf to printf stuff for debugging purposes.
- xbps-{bin,repo}: added -d arg to enable debugging output.
- Before checking if a config file needs to be installed or such, check that
package contains the "conf_files" array.
- Remove obsolete dirs as well while updating packages.
- If transaction dictionary is ready remove the "missing_deps" array.
Bump XBPS_RELVER to 20101118.
--HG--
rename : lib/regpkgs_dictionary.c => lib/regpkgdb_dictionary.c
553 lines
14 KiB
C
553 lines
14 KiB
C
/*-
|
|
* Copyright (c) 2008-2010 Juan Romero Pardines.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <errno.h>
|
|
|
|
#include <xbps_api.h>
|
|
#include "xbps_api_impl.h"
|
|
|
|
static int
|
|
store_dependency(prop_dictionary_t trans_dict, prop_dictionary_t repo_pkg_dict,
|
|
const char *repoloc)
|
|
{
|
|
prop_dictionary_t dict;
|
|
prop_array_t array;
|
|
const char *pkgname, *pkgver;
|
|
int rv = 0;
|
|
pkg_state_t state = 0;
|
|
|
|
assert(trans_dict != NULL);
|
|
assert(repo_pkg_dict != NULL);
|
|
assert(repoloc != NULL);
|
|
/*
|
|
* Get some info about dependencies and current repository.
|
|
*/
|
|
prop_dictionary_get_cstring_nocopy(repo_pkg_dict, "pkgname", &pkgname);
|
|
prop_dictionary_get_cstring_nocopy(repo_pkg_dict, "pkgver", &pkgver);
|
|
|
|
dict = prop_dictionary_copy(repo_pkg_dict);
|
|
if (dict == NULL)
|
|
return errno;
|
|
|
|
array = prop_dictionary_get(trans_dict, "unsorted_deps");
|
|
if (array == NULL) {
|
|
prop_object_release(dict);
|
|
return errno;
|
|
}
|
|
/*
|
|
* Always set "not-installed" package state. Will be overwritten
|
|
* to its correct state later.
|
|
*/
|
|
xbps_dbg_printf_append("\n");
|
|
rv = xbps_set_pkg_state_dictionary(dict, XBPS_PKG_STATE_NOT_INSTALLED);
|
|
if (rv != 0) {
|
|
prop_object_release(dict);
|
|
return rv;
|
|
}
|
|
|
|
/*
|
|
* Overwrite package state in dictionary if it was unpacked
|
|
* previously.
|
|
*/
|
|
if ((rv = xbps_get_pkg_state_installed(pkgname, &state)) == 0) {
|
|
if ((rv = xbps_set_pkg_state_dictionary(dict, state)) != 0) {
|
|
prop_object_release(dict);
|
|
return rv;
|
|
}
|
|
}
|
|
/*
|
|
* Add required objects into package dep's dictionary.
|
|
*/
|
|
if (!prop_dictionary_set_cstring(dict, "repository", repoloc)) {
|
|
prop_object_release(dict);
|
|
return errno;
|
|
}
|
|
if (!prop_dictionary_set_bool(dict, "automatic-install", true)) {
|
|
prop_object_release(dict);
|
|
return errno;
|
|
}
|
|
/*
|
|
* Add the dictionary into the array.
|
|
*/
|
|
if (!xbps_add_obj_to_array(array, dict)) {
|
|
prop_object_release(dict);
|
|
return EINVAL;
|
|
}
|
|
xbps_dbg_printf("Added package '%s' into "
|
|
"the transaction (%s).\n", pkgver, repoloc);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
add_missing_reqdep(prop_dictionary_t trans_dict, const char *reqpkg)
|
|
{
|
|
prop_array_t missing_rdeps;
|
|
prop_string_t reqpkg_str;
|
|
prop_object_iterator_t iter = NULL;
|
|
prop_object_t obj;
|
|
size_t idx = 0;
|
|
bool add_pkgdep, pkgfound, update_pkgdep;
|
|
|
|
assert(trans_dict != NULL);
|
|
assert(reqpkg != NULL);
|
|
|
|
add_pkgdep = update_pkgdep = pkgfound = false;
|
|
|
|
reqpkg_str = prop_string_create_cstring_nocopy(reqpkg);
|
|
if (reqpkg_str == NULL)
|
|
return errno;
|
|
|
|
missing_rdeps = prop_dictionary_get(trans_dict, "missing_deps");
|
|
iter = prop_array_iterator(missing_rdeps);
|
|
if (iter == NULL)
|
|
goto out;
|
|
|
|
while ((obj = prop_object_iterator_next(iter)) != NULL) {
|
|
const char *curdep, *curver, *pkgver;
|
|
char *curpkgnamedep = NULL, *pkgnamedep = NULL;
|
|
|
|
assert(prop_object_type(obj) == PROP_TYPE_STRING);
|
|
curdep = prop_string_cstring_nocopy(obj);
|
|
curver = xbps_get_pkgpattern_version(curdep);
|
|
pkgver = xbps_get_pkgpattern_version(reqpkg);
|
|
if (curver == NULL || pkgver == NULL)
|
|
goto out;
|
|
curpkgnamedep = xbps_get_pkgpattern_name(curdep);
|
|
if (curpkgnamedep == NULL)
|
|
goto out;
|
|
pkgnamedep = xbps_get_pkgpattern_name(reqpkg);
|
|
if (pkgnamedep == NULL) {
|
|
free(curpkgnamedep);
|
|
goto out;
|
|
}
|
|
if (strcmp(pkgnamedep, curpkgnamedep) == 0) {
|
|
pkgfound = true;
|
|
/*
|
|
* if new dependency version is greater than current
|
|
* one, store it.
|
|
*/
|
|
xbps_dbg_printf("Missing pkgdep name matched, "
|
|
"curver: %s newver: %s\n", curver, pkgver);
|
|
if (xbps_cmpver(curver, pkgver) <= 0) {
|
|
add_pkgdep = false;
|
|
free(curpkgnamedep);
|
|
free(pkgnamedep);
|
|
goto out;
|
|
}
|
|
update_pkgdep = true;
|
|
}
|
|
free(curpkgnamedep);
|
|
free(pkgnamedep);
|
|
if (pkgfound)
|
|
break;
|
|
|
|
idx++;
|
|
}
|
|
add_pkgdep = true;
|
|
out:
|
|
if (iter)
|
|
prop_object_iterator_release(iter);
|
|
if (update_pkgdep)
|
|
prop_array_remove(missing_rdeps, idx);
|
|
if (add_pkgdep && !xbps_add_obj_to_array(missing_rdeps, reqpkg_str)) {
|
|
prop_object_release(reqpkg_str);
|
|
return errno;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
remove_missing_reqdep(prop_dictionary_t trans_dict, const char *reqpkg)
|
|
{
|
|
prop_array_t missing_rdeps;
|
|
prop_object_iterator_t iter = NULL;
|
|
prop_object_t obj;
|
|
size_t idx = 0;
|
|
int rv = 0;
|
|
bool found = false;
|
|
|
|
assert(trans_dict != NULL);
|
|
assert(reqpkg != NULL);
|
|
|
|
missing_rdeps = prop_dictionary_get(trans_dict, "missing_deps");
|
|
iter = prop_array_iterator(missing_rdeps);
|
|
if (iter == NULL)
|
|
return errno;
|
|
|
|
while ((obj = prop_object_iterator_next(iter)) != NULL) {
|
|
const char *curdep;
|
|
char *curpkgnamedep, *reqpkgname;
|
|
|
|
curdep = prop_string_cstring_nocopy(obj);
|
|
curpkgnamedep = xbps_get_pkgpattern_name(curdep);
|
|
if (curpkgnamedep == NULL) {
|
|
rv = errno;
|
|
goto out;
|
|
}
|
|
reqpkgname = xbps_get_pkgpattern_name(reqpkg);
|
|
if (reqpkgname == NULL) {
|
|
free(curpkgnamedep);
|
|
rv = errno;
|
|
goto out;
|
|
}
|
|
if (strcmp(reqpkgname, curpkgnamedep) == 0)
|
|
found = true;
|
|
|
|
free(curpkgnamedep);
|
|
free(reqpkgname);
|
|
if (found)
|
|
break;
|
|
idx++;
|
|
}
|
|
out:
|
|
prop_object_iterator_release(iter);
|
|
if (found) {
|
|
prop_array_remove(missing_rdeps, idx);
|
|
return 0;
|
|
}
|
|
if (rv == 0)
|
|
rv = ENOENT;
|
|
|
|
return rv;
|
|
}
|
|
|
|
static int
|
|
find_repo_deps(prop_dictionary_t trans_dict, prop_dictionary_t repo_dict,
|
|
const char *repoloc, const char *originpkgn,
|
|
prop_array_t pkg_rdeps_array)
|
|
{
|
|
prop_dictionary_t curpkgd, tmpd;
|
|
prop_array_t curpkg_rdeps;
|
|
prop_object_t obj;
|
|
prop_object_iterator_t iter;
|
|
pkg_state_t state = 0;
|
|
const char *reqpkg, *reqvers, *pkg_queued, *repo_pkgver;
|
|
char *pkgname;
|
|
int rv = 0;
|
|
|
|
iter = prop_array_iterator(pkg_rdeps_array);
|
|
if (iter == NULL)
|
|
return ENOMEM;
|
|
|
|
/*
|
|
* Iterate over the list of required run dependencies for
|
|
* current package.
|
|
*/
|
|
while ((obj = prop_object_iterator_next(iter)) != NULL) {
|
|
reqpkg = prop_string_cstring_nocopy(obj);
|
|
if (reqpkg == NULL) {
|
|
rv = EINVAL;
|
|
break;
|
|
}
|
|
if (originpkgn)
|
|
xbps_dbg_printf(" %s requires dependency '%s' "
|
|
"[direct]: ", originpkgn, reqpkg);
|
|
else
|
|
xbps_dbg_printf(" requires dependency '%s' "
|
|
"[indirect]: ", reqpkg);
|
|
|
|
/*
|
|
* Check if required dep is satisfied and installed.
|
|
*/
|
|
rv = xbps_check_is_installed_pkg(reqpkg);
|
|
if (rv == -1) {
|
|
/* There was an error checking it... */
|
|
xbps_dbg_printf_append("error matching reqdep %s\n",
|
|
reqpkg);
|
|
break;
|
|
} else if (rv == 1) {
|
|
/* Required pkg dependency is satisfied */
|
|
xbps_dbg_printf_append("satisfied and installed.\n");
|
|
rv = 0;
|
|
continue;
|
|
}
|
|
pkgname = xbps_get_pkgpattern_name(reqpkg);
|
|
if (pkgname == NULL) {
|
|
rv = EINVAL;
|
|
break;
|
|
}
|
|
reqvers = xbps_get_pkgpattern_version(reqpkg);
|
|
if (reqvers == NULL) {
|
|
free(pkgname);
|
|
rv = EINVAL;
|
|
break;
|
|
}
|
|
/*
|
|
* Check if package is already added in the
|
|
* array of unsorted deps, and check if current required
|
|
* dependency pattern is matched.
|
|
*/
|
|
curpkgd = xbps_find_pkg_in_dict_by_name(trans_dict,
|
|
"unsorted_deps", pkgname);
|
|
if (curpkgd == NULL) {
|
|
if (errno && errno != ENOENT) {
|
|
free(pkgname);
|
|
rv = errno;
|
|
break;
|
|
}
|
|
} else if (curpkgd) {
|
|
prop_dictionary_get_cstring_nocopy(curpkgd,
|
|
"pkgver", &pkg_queued);
|
|
if (xbps_pkgpattern_match(pkg_queued,
|
|
__UNCONST(reqpkg))) {
|
|
xbps_dbg_printf_append(
|
|
"queued in the transaction.\n");
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* If required package is not in repo, add it into the
|
|
* missing deps array and pass to the next one.
|
|
*/
|
|
curpkgd = xbps_find_pkg_in_dict_by_name(repo_dict,
|
|
"packages", pkgname);
|
|
if (curpkgd == NULL) {
|
|
if (errno && errno != ENOENT) {
|
|
free(pkgname);
|
|
rv = errno;
|
|
break;
|
|
}
|
|
|
|
rv = add_missing_reqdep(trans_dict, reqpkg);
|
|
if (rv != 0 && rv != EEXIST) {
|
|
xbps_dbg_printf_append("add missing reqdep "
|
|
"failed %s\n", reqpkg);
|
|
free(pkgname);
|
|
break;
|
|
} else if (rv == EEXIST) {
|
|
xbps_dbg_printf_append("missing dep %s "
|
|
"already added.\n", reqpkg);
|
|
rv = 0;
|
|
free(pkgname);
|
|
continue;
|
|
} else {
|
|
xbps_dbg_printf_append(
|
|
"missing package in repository!\n");
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
}
|
|
/*
|
|
* If version in repo does not satisfy the rundep, pass
|
|
* to the next rundep.
|
|
*/
|
|
prop_dictionary_get_cstring_nocopy(curpkgd, "pkgver", &repo_pkgver);
|
|
if (xbps_pkgpattern_match(repo_pkgver, __UNCONST(reqpkg)) < 1) {
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
|
|
/*
|
|
* If package is installed but version doesn't satisfy
|
|
* the dependency mark it as an update, otherwise as
|
|
* an install. Packages that were unpacked previously
|
|
* will be marked as pending to be configured.
|
|
*/
|
|
tmpd = xbps_find_pkg_dict_installed(pkgname, false);
|
|
if (tmpd == NULL) {
|
|
if (errno && errno != ENOENT) {
|
|
free(pkgname);
|
|
rv = errno;
|
|
break;
|
|
}
|
|
prop_dictionary_set_cstring_nocopy(curpkgd,
|
|
"trans-action", "install");
|
|
} else if (tmpd) {
|
|
rv = xbps_get_pkg_state_installed(pkgname, &state);
|
|
if (rv != 0) {
|
|
free(pkgname);
|
|
prop_object_release(tmpd);
|
|
break;
|
|
}
|
|
if (state == XBPS_PKG_STATE_INSTALLED)
|
|
prop_dictionary_set_cstring_nocopy(curpkgd,
|
|
"trans-action", "update");
|
|
else
|
|
prop_dictionary_set_cstring_nocopy(curpkgd,
|
|
"trans-action", "configure");
|
|
|
|
prop_object_release(tmpd);
|
|
}
|
|
/*
|
|
* Package is on repo, add it into the dictionary.
|
|
*/
|
|
rv = store_dependency(trans_dict, curpkgd, repoloc);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf("store_dependency failed %s",
|
|
reqpkg);
|
|
free(pkgname);
|
|
break;
|
|
}
|
|
|
|
/*
|
|
* If package was added in the missing_deps array, we
|
|
* can remove it now it has been found in current repository.
|
|
*/
|
|
rv = remove_missing_reqdep(trans_dict, reqpkg);
|
|
if (rv == ENOENT) {
|
|
rv = 0;
|
|
} else if (rv == 0) {
|
|
xbps_dbg_printf("Removed missing dep %s.\n", reqpkg);
|
|
} else {
|
|
xbps_dbg_printf("Removing missing dep %s "
|
|
"returned %s\n", reqpkg, strerror(rv));
|
|
free(pkgname);
|
|
break;
|
|
}
|
|
|
|
/*
|
|
* If package doesn't have rundeps, pass to the next one.
|
|
*/
|
|
curpkg_rdeps = prop_dictionary_get(curpkgd, "run_depends");
|
|
if (curpkg_rdeps == NULL) {
|
|
free(pkgname);
|
|
continue;
|
|
}
|
|
|
|
/*
|
|
* Iterate on required pkg to find more deps.
|
|
*/
|
|
xbps_dbg_printf_append("\n");
|
|
xbps_dbg_printf("Finding dependencies for '%s-%s' [%s]:\n",
|
|
pkgname, reqvers, originpkgn ? "direct" : "indirect");
|
|
|
|
free(pkgname);
|
|
if ((rv = find_repo_deps(trans_dict, repo_dict, repoloc,
|
|
NULL, curpkg_rdeps)) != 0) {
|
|
xbps_dbg_printf("Error checking %s for rundeps: %s\n",
|
|
reqpkg, strerror(rv));
|
|
break;
|
|
}
|
|
}
|
|
prop_object_iterator_release(iter);
|
|
|
|
return rv;
|
|
}
|
|
|
|
struct rpool_index_data {
|
|
prop_dictionary_t transd;
|
|
prop_array_t rdeps;
|
|
const char *pkgname;
|
|
};
|
|
|
|
static int
|
|
find_repo_deps_in_pool(struct repository_pool_index *rpi, void *arg, bool *done)
|
|
{
|
|
struct rpool_index_data *rid = arg;
|
|
int rv;
|
|
|
|
(void)done;
|
|
|
|
rv = find_repo_deps(rid->transd, rpi->rpi_repod, rpi->rpi_uri,
|
|
rid->pkgname, rid->rdeps);
|
|
return rv;
|
|
}
|
|
|
|
|
|
int HIDDEN
|
|
xbps_repository_find_pkg_deps(prop_dictionary_t trans_dict,
|
|
prop_dictionary_t repo_pkg_dict)
|
|
{
|
|
prop_array_t pkg_rdeps, missing_rdeps;
|
|
struct rpool_index_data *rid;
|
|
const char *pkgname, *pkgver;
|
|
int rv = 0;
|
|
|
|
assert(trans_dict != NULL);
|
|
assert(repo_pkg_dict != NULL);
|
|
|
|
pkg_rdeps = prop_dictionary_get(repo_pkg_dict, "run_depends");
|
|
if (pkg_rdeps == NULL)
|
|
return 0;
|
|
|
|
rid = malloc(sizeof(struct rpool_index_data));
|
|
if (rid == NULL)
|
|
return ENOMEM;
|
|
|
|
prop_dictionary_get_cstring_nocopy(repo_pkg_dict, "pkgname", &pkgname);
|
|
prop_dictionary_get_cstring_nocopy(repo_pkg_dict, "pkgver", &pkgver);
|
|
|
|
if ((rv = xbps_repository_pool_init()) != 0)
|
|
goto out;
|
|
|
|
xbps_dbg_printf("Finding required dependencies for '%s':\n", pkgver);
|
|
|
|
/*
|
|
* Iterate over the repository pool and find out if we have
|
|
* all available binary packages.
|
|
*/
|
|
rid->transd = trans_dict;
|
|
rid->rdeps = pkg_rdeps;
|
|
rid->pkgname = pkgname;
|
|
|
|
/*
|
|
* This will find direct and indirect deps,
|
|
* if any of them is not there it will be added
|
|
* into the missing_deps array.
|
|
*/
|
|
rv = xbps_repository_pool_foreach(find_repo_deps_in_pool, rid);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf("Error '%s' while checking rundeps!\n",
|
|
strerror(errno));
|
|
goto out;
|
|
}
|
|
|
|
/*
|
|
* If there are no missing deps, there's nothing to do.
|
|
*/
|
|
missing_rdeps = prop_dictionary_get(trans_dict, "missing_deps");
|
|
if (prop_array_count(missing_rdeps) == 0)
|
|
goto out;
|
|
|
|
/*
|
|
* Iterate one more time, but this time with missing deps
|
|
* that were found in previous pass.
|
|
*/
|
|
rid->rdeps = missing_rdeps;
|
|
rid->pkgname = NULL;
|
|
|
|
xbps_dbg_printf("Checking for missing deps in %s.\n", pkgname);
|
|
rv = xbps_repository_pool_foreach(find_repo_deps_in_pool, rid);
|
|
if (rv != 0) {
|
|
xbps_dbg_printf("Error '%s' while checking for "
|
|
"missing rundeps!\n", strerror(errno));
|
|
goto out;
|
|
}
|
|
out:
|
|
if (rid)
|
|
free(rid);
|
|
|
|
xbps_repository_pool_release();
|
|
|
|
return rv;
|
|
}
|