From e88a9ace8d28cc773822b63903637670bf23be2f Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 5 Jun 2019 16:05:34 -0400 Subject: [PATCH] yuzu/CMakeLists: Disable implicit QString->QUrl conversions Enforces the use of the proper URL resolution functions. e.g. url = some_local_path_string; should actually be: url = QUrl::fromLocalPath(some_local_path_string); etc. This makes it harder to cause bugs when operating with both strings and URLs at the same time. --- src/citra_qt/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/citra_qt/CMakeLists.txt b/src/citra_qt/CMakeLists.txt index fb2e8742f..edd2a3eb2 100644 --- a/src/citra_qt/CMakeLists.txt +++ b/src/citra_qt/CMakeLists.txt @@ -234,6 +234,9 @@ target_compile_definitions(citra-qt PRIVATE # Disable unsafe overloads of QProcess' start() function. -DQT_NO_PROCESS_COMBINED_ARGUMENT_START + + # Disable implicit QString->QUrl conversions to enforce use of proper resolving functions. + -DQT_NO_URL_CAST_FROM_STRING ) if (CITRA_ENABLE_COMPATIBILITY_REPORTING)