midou/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

configure_hotkeys: Avoid dialog memory leak within Configure()

Browse Source 
Without a parent, this dialog won't have its memory freed when it
happens to get destroyed.
This commit is contained in:
Lioncash 2019-04-09 19:50:59 -04:00 committed by fearlessTobi
parent d7d1be509b
commit 562e0114eb
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/citra_qt/configuration/configure_hotkeys.cpp
View File

@ -78,10 +78,10 @@ void ConfigureHotkeys::Configure(QModelIndex index) {
auto* const model = ui->hotkey_list->model(); auto* const model = ui->hotkey_list->model();
const auto previous_key = model->data(index); const auto previous_key = model->data(index);
auto* const hotkey_dialog = new SequenceDialog; SequenceDialog hotkey_dialog;
const int return_code = hotkey_dialog->exec(); const int return_code = hotkey_dialog.exec();
const auto key_sequence = hotkey_dialog->GetSequence(); const auto key_sequence = hotkey_dialog.GetSequence();
if (return_code == QDialog::Rejected || key_sequence.isEmpty()) { if (return_code == QDialog::Rejected || key_sequence.isEmpty()) {
return; return;
} }