midou/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

audio_core/sink_details: Change std::string parameter into std::string_view

Browse Source 
The given string is only ever used for lookup and comparison, so we can
just utilize a non-owning view to string data here
This commit is contained in:
Lioncash 2018-09-11 21:36:07 -04:00 committed by fearlessTobi
parent 2ba62ec196
commit 93bd630d40
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/audio_core/sink_details.cpp
View File

@ -30,7 +30,7 @@ const std::vector<SinkDetails> g_sink_details = {
[] { return std::vector<std::string>{"null"}; }}, [] { return std::vector<std::string>{"null"}; }},
}; };
const SinkDetails& GetSinkDetails(std::string sink_id) { const SinkDetails& GetSinkDetails(std::string_view sink_id) {
auto iter = auto iter =
std::find_if(g_sink_details.begin(), g_sink_details.end(), std::find_if(g_sink_details.begin(), g_sink_details.end(),
[sink_id](const auto& sink_detail) { return sink_detail.id == sink_id; }); [sink_id](const auto& sink_detail) { return sink_detail.id == sink_id; });

4
src/audio_core/sink_details.h
View File

@ -6,6 +6,8 @@
#include <functional> #include <functional>
#include <memory> #include <memory>
#include <string>
#include <string_view>
#include <utility> #include <utility>
#include <vector> #include <vector>
@ -30,6 +32,6 @@ struct SinkDetails {
extern const std::vector<SinkDetails> g_sink_details; extern const std::vector<SinkDetails> g_sink_details;
const SinkDetails& GetSinkDetails(std::string sink_id); const SinkDetails& GetSinkDetails(std::string_view sink_id);
} // namespace AudioCore } // namespace AudioCore