midou/citra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

common/thread_queue_list: Remove unnecessary dependency on boost

Browse Source 
We really don't need to pull in several headers of boost related
machinery just to perform the erase-remove idiom (particularly with
C++20 around the corner, which adds universal container std::erase and
std::erase_if, which we can just use instead).

With this, we don't need to link in anything boost-related into common.
This commit is contained in:
Lioncash 2019-03-16 04:41:34 -04:00 committed by fearlessTobi
parent 17c0e903db
commit bd4c04aec1
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/CMakeLists.txt
View File

@ -107,7 +107,7 @@ endif()
create_target_directory_groups(common) create_target_directory_groups(common)
target_link_libraries(common PUBLIC Boost::boost fmt microprofile) target_link_libraries(common PUBLIC fmt microprofile)
if (ARCHITECTURE_x86_64) if (ARCHITECTURE_x86_64)
target_link_libraries(common PRIVATE xbyak) target_link_libraries(common PRIVATE xbyak)
endif() endif()

6
src/common/thread_queue_list.h
View File

@ -6,7 +6,6 @@
#include <array> #include <array>
#include <deque> #include <deque>
#include <boost/range/algorithm_ext/erase.hpp>
namespace Common { namespace Common {
@ -95,8 +94,9 @@ struct ThreadQueueList {
} }
void remove(Priority priority, const T& thread_id) { void remove(Priority priority, const T& thread_id) {
Queue* cur = &queues[priority]; Queue* const cur = &queues[priority];
boost::remove_erase(cur->data, thread_id); const auto iter = std::remove(cur->data.begin(), cur->data.end(), thread_id);
cur->data.erase(iter, cur->data.end());
} }
void rotate(Priority priority) { void rotate(Priority priority) {