0xf8/pollymc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: LGTM warnings

Browse Source 
Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow 2022-08-13 14:35:44 -03:00
parent e2ab2aea32
commit 0b81b283bf
No known key found for this signature in database
GPG Key ID: 8D0F221F0A59F469
2 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
launcher/minecraft/mod/ModDetails.h
View File

@ -91,4 +91,32 @@ struct ModDetails
, authors(other.authors)
, status(other.status)
{}
ModDetails& operator=(ModDetails& other)
{
this->mod_id = other.mod_id;
this->name = other.name;
this->version = other.version;
this->mcversion = other.mcversion;
this->homeurl = other.homeurl;
this->description = other.description;
this->authors = other.authors;
this->status = other.status;
return *this;
}
ModDetails& operator=(ModDetails&& other)
{
this->mod_id = other.mod_id;
this->name = other.name;
this->version = other.version;
this->mcversion = other.mcversion;
this->homeurl = other.homeurl;
this->description = other.description;
this->authors = other.authors;
this->status = other.status;
return *this;
}
};

4
launcher/minecraft/mod/ResourceFolderModel.cpp
View File

@ -380,8 +380,8 @@ bool ResourceFolderModel::validateIndex(const QModelIndex& index) const
if (!index.isValid())
return false;
size_t row = index.row();
if (row < 0 || row >= size())
int row = index.row();
if (row < 0 || row >= m_resources.size())
return false;
return true;