Replace __call__ in dir(*) with callable(*) for performance gain
svn: r10856
This commit is contained in:
		| @@ -53,7 +53,7 @@ class UpdateCallback: | ||||
|         @param interval: number of seconds at most between the updates | ||||
|         @type interval: int | ||||
|         """ | ||||
|         if '__call__' in dir(callback): # callback is really callable | ||||
|         if callable(callback): # callback is really callable | ||||
|             self.update = self.update_real | ||||
|             self.callback = callback | ||||
|             self.interval = interval | ||||
|   | ||||
| @@ -237,7 +237,7 @@ class CSVWriter: | ||||
|         self.cl = cl | ||||
|         self.filename = filename | ||||
|         self.callback = callback | ||||
|         if '__call__' in dir(self.callback): # callback is really callable | ||||
|         if callable(self.callback): # callback is really callable | ||||
|             self.update = self.update_real | ||||
|         else: | ||||
|             self.update = self.update_empty | ||||
|   | ||||
| @@ -136,7 +136,7 @@ class CalendarWriter: | ||||
|         self.cl = cl | ||||
|         self.filename = filename | ||||
|         self.callback = callback | ||||
|         if '__call__' in dir(self.callback): # callback is really callable | ||||
|         if callable(self.callback): # callback is really callable | ||||
|             self.update = self.update_real | ||||
|         else: | ||||
|             self.update = self.update_empty | ||||
|   | ||||
| @@ -133,7 +133,7 @@ class CardWriter: | ||||
|         self.cl = cl | ||||
|         self.filename = filename | ||||
|         self.callback = callback | ||||
|         if '__call__' in dir(self.callback): # callback is really callable | ||||
|         if callable(self.callback): # callback is really callable | ||||
|             self.update = self.update_real | ||||
|         else: | ||||
|             self.update = self.update_empty | ||||
|   | ||||
| @@ -141,7 +141,7 @@ class FtreeWriter: | ||||
|         self.cl = cl | ||||
|         self.filename = filename | ||||
|         self.callback = callback | ||||
|         if '__call__' in dir(self.callback): # callback is really callable | ||||
|         if callable(self.callback): # callback is really callable | ||||
|             self.update = self.update_real | ||||
|         else: | ||||
|             self.update = self.update_empty | ||||
|   | ||||
| @@ -162,7 +162,7 @@ class GeneWebWriter: | ||||
|         self.cl = cl | ||||
|         self.filename = filename | ||||
|         self.callback = callback | ||||
|         if '__call__' in dir(self.callback): # callback is really callable | ||||
|         if callable(self.callback): # callback is really callable | ||||
|             self.update = self.update_real | ||||
|         else: | ||||
|             self.update = self.update_empty | ||||
|   | ||||
		Reference in New Issue
	
	Block a user