4739: Update addon list crashes when working offline with 'plugin_dict referenced before assignment'

svn: r16802
2011-03-10 21:13:47 +00:00 · 2011-03-10 21:13:47 +00:00 · ef2b19589e
commit ef2b19589e
parent 00a07fb05c
1 changed files with 6 additions and 1 deletions
--- a/src/gui/viewmanager.py
+++ b/src/gui/viewmanager.py
@ -374,8 +374,13 @@ class ViewManager(CLIManager):
                for line in lines:
                    try:
                        plugin_dict = safe_eval(line)
+                        if type(plugin_dict) != type({}):
+                            raise TypeError("Line with addon metadata is not "
+                                            "a dictionary")
                    except:
-                        pass
+                        LOG.debug("Skipped a line in the addon listing: " +
+                                 str(line))
+                        continue
                    id = plugin_dict["i"]
                    plugin = self._pmgr.get_plugin(id)
                    if plugin: