ElyBy-Mirror/accounts-frontend
1
0
Fork 0
mirror of https://github.com/elyby/accounts-frontend.git synced 2024-11-26 16:52:06 +05:30
Code Issues Packages Projects Releases Wiki Activity

Improve dev/applications e2e coverage

Browse Source
This commit is contained in:
SleepWalker 2019-12-29 16:44:07 +02:00
parent f8670db315
commit f8ae8282ed
5 changed files with 122 additions and 71 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/app/components/dev/apps/list/ApplicationItem.tsx
View File

@ -124,6 +124,7 @@ export default class ApplicationItem extends React.Component<
skin={SKIN_LIGHT}
disabled
value={app.clientSecret}
data-testid="client-secret"
copy
/>
</div>
@ -228,6 +229,7 @@ export default class ApplicationItem extends React.Component<
color={COLOR_RED}
className={styles.appActionButton}
onClick={this.onSubmitDelete}
data-testid="delete-app"
small
/>
)}

117
tests-e2e/cypress/integration/dev/applications.test.ts Normal file
View File

@ -0,0 +1,117 @@
describe('Applications', () => {
describe('user', () => {
before(() => {
cy.login({ accounts: ['default'] }).then(({ accounts: [user] }) => {
cy.visit('/dev/applications');
// remove all previously added apps
cy.window().then(async win => {
const { oauthApi } = (win as any) as {
oauthApi: typeof import('app/services/api/oauth').default;
};
const apps = await oauthApi.getAppsByUser(user.id);
await Promise.all(apps.map(app => oauthApi.delete(app.clientId)));
});
});
});
it('should add website app', () => {
cy.server();
cy.route({
method: 'POST',
url: '/api/v1/oauth2/*/reset',
}).as('revoke');
cy.route({
method: 'DELETE',
url: '/api/v1/oauth2/*',
}).as('delete');
cy.route({
method: 'POST',
url: '/api/v1/oauth2/*/reset?regenerateSecret',
}).as('revokeSecret');
cy.visit('/dev/applications');
cy.get('[data-e2e="noApps"]').should('exist');
cy.get('[data-e2e="newApp"]').click();
cy.url().should('include', '/dev/applications/new');
cy.get('[value="application"]').check({ force: true });
cy.get('[name="name"]').type('The Foo');
cy.get('[name="description"]').type('The Foo Description');
cy.get('[name="websiteUrl"]').type('https://ely.by');
cy.get('[name="redirectUri"]').type('https://ely.by/the/redirect/uri');
cy.get('[type="submit"]').click();
cy.url().should('include', '/dev/applications#the-foo');
cy.get('[data-e2e-app-name="The Foo"]').should('exist');
// test cancel
cy.contains('Cancel').should('not.exist');
cy.contains('Revoke all tokens').click();
cy.contains('Cancel').click();
cy.contains('Cancel').should('not.exist');
// test revoke tokens
cy.contains('Revoke all tokens').click();
cy.contains('Continue').click();
cy.wait('@revoke');
cy.contains('Cancel').should('not.exist');
// test reset client secret
cy.getByTestId('client-secret').then(([el]) => {
const prevSecret = el.value;
cy.getByTestId('client-secret').should('have.value', prevSecret);
cy.contains('Reset Client Secret').click();
cy.contains('Continue').click();
cy.wait('@revokeSecret');
cy.contains('Cancel').should('not.exist');
cy.getByTestId('client-secret').should('not.have.value', prevSecret);
});
// test delete
cy.contains('Delete').click();
cy.getByTestId('delete-app').click();
cy.wait('@delete');
cy.contains("You don't have any app registered yet.").should(
'be.visible',
);
});
});
describe('guest', () => {
it('should render login button', () => {
cy.visit('/dev/applications');
cy.get('[data-e2e-content] [href="/login"]').click();
cy.url().should('include', '/login');
});
it('should not allow create new app', () => {
cy.visit('/dev/applications/new');
cy.url().should('include', '/login');
});
it('should not allow edit app', () => {
cy.visit('/dev/applications/foo-bar');
cy.url().should('include', '/login');
});
it('should have feedback popup link', () => {
cy.visit('/dev/applications');
cy.get('[data-e2e-content] [data-e2e-button="feedbackPopup"]').click();
cy.getByTestId('feedbackPopup').should('be.visible');
});
});
});

28
tests-e2e/cypress/integration/dev/guest.test.ts
View File

@ -1,28 +0,0 @@
describe('/dev/applications - guest', () => {
it('should render login button', () => {
cy.visit('/dev/applications');
cy.get('[data-e2e-content] [href="/login"]').click();
cy.url().should('include', '/login');
});
it('should not allow create new app', () => {
cy.visit('/dev/applications/new');
cy.url().should('include', '/login');
});
it('should not allow edit app', () => {
cy.visit('/dev/applications/foo-bar');
cy.url().should('include', '/login');
});
it('should have feedback popup link', () => {
cy.visit('/dev/applications');
cy.get('[data-e2e-content] [data-e2e-button="feedbackPopup"]').click();
cy.getByTestId('feedbackPopup').should('be.visible');
});
});

40
tests-e2e/cypress/integration/dev/user.test.ts
View File

@ -1,40 +0,0 @@
describe('/dev/applications - user', () => {
before(() => {
cy.login({ accounts: ['default'] }).then(({ user }) => {
cy.visit('/dev/applications');
// remove all previously added apps
cy.window().then(async (/** @type {any} */ { oauthApi }) => {
const apps = await oauthApi.getAppsByUser(user.id);
await Promise.all(apps.map(app => oauthApi.delete(app.clientId)));
});
});
});
// TODO: test the first screen is without any list rendered
// TODO: test validation
it('should add website app', () => {
cy.visit('/dev/applications');
cy.get('[data-e2e="noApps"]').should('exist');
cy.get('[data-e2e="newApp"]').click();
cy.url().should('include', '/dev/applications/new');
cy.get('[value="application"]').check({ force: true });
cy.get('[name="name"]').type('The Foo');
cy.get('[name="description"]').type('The Foo Description');
cy.get('[name="websiteUrl"]').type('https://ely.by');
cy.get('[name="redirectUri"]').type('https://ely.by/the/redirect/uri');
cy.get('[type="submit"]').click();
cy.url().should('include', '/dev/applications#the-foo');
cy.get('[data-e2e-app-name="The Foo"]').should('exist');
});
});

6
tests-e2e/cypress/support/index.d.ts vendored
View File

@ -2,8 +2,8 @@
type AccountAlias = 'default' | 'default2';
interface Account {
id: string;
interface TAccount {
id: number;
username: string;
password: string;
email: string;
@ -31,7 +31,7 @@ declare namespace Cypress {
* Whether return raw api response without any conversion. Defaults to: `false`
*/
rawApiResp?: boolean;
}): Promise<{ accounts: Account[] }>;
}): Promise<{ accounts: TAccount[] }>;
getByTestId<S = any>(
id: string,