reads: fix bug 1078

2006-10-31 22:46:08 +00:00 · 2006-10-31 22:46:08 +00:00 · b141b9b512
commit b141b9b512
parent 4126b1f5c6
1 changed files with 2 additions and 1 deletions
--- a/libbb/read.c
+++ b/libbb/read.c
@ -86,7 +86,8 @@ char *reads(int fd, char *buffer, size_t size)
 	if (p) {
 		off_t offset;
 		*p++ = '\0';
-		offset = (p-buffer) - size;
+		// avoid incorrect (unsigned) widening
+		offset = (off_t)(p-buffer) - (off_t)size;
 		// set fd position the right after the \n
 		if (offset && lseek(fd, offset, SEEK_CUR) == (off_t)-1)
 			return NULL;