emo/busybox
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
4,002 Commits 1 Branch 0 Tags 33 MiB
C 93.2%
Shell 4.1%
Assembly 1%
Makefile 0.7%
C++ 0.5%
Other 0.2%
46390ed829
Go to file
Eric Andersen 46390ed829 Junio Hamano, junio at twinsun dot com writes: 
The sed command in busybox 1.0.0-pre8 loses leading whitespace
in 'a' command ('i' and 'c' commands are also affected).  A
patch to fix this is attached at the end of this message.

The following is a transcript that reproduces the problem.  The
first run uses busybox 1.0.0-pre3 as "/bin/sed" command, which
gets the expected result.  Later in the test, /bin/sed symlink
is changed to point at busybox 1.0.0-pre8 and the test script is
run again, which shows the failure.

=== reproduction recipe ===
* Part 1.  Use busybox 1.0.0-pre3 as sed; this works.

root# cd /tmp
root# cat 1.sh
#!/bin/sh

cd /tmp
rm -f ipsec.conf ipsec.conf+
cat >ipsec.conf <<\EOF
version 2.0

config setup
        klipsdebug=none
        plutodebug=none
        plutostderrlog=/dev/null

conn %default
        keyingtries=1
        ...
EOF
sed -e '/^config setup/a\
	nat_traversal=yes' ipsec.conf >ipsec.conf+
mv -f ipsec.conf+ ipsec.conf
root# sh -x 1.sh
+ cd /tmp
+ rm -f ipsec.conf ipsec.conf+
+ cat
+ sed -e /^config setup/a\
        nat_traversal=yes ipsec.conf
+ mv -f ipsec.conf+ ipsec.conf
root# cat ipsec.conf
version 2.0

config setup
        nat_traversal=yes
        klipsdebug=none
        plutodebug=none
        plutostderrlog=/dev/null

conn %default
        keyingtries=1
        ...
root# sed --version
sed: invalid option -- -
BusyBox v1.00-pre3 (2004.02.26-18:47+0000) multi-call binary

Usage: sed [-nef] pattern [files...]

* Part 2.  Continuing from the above, use busybox 1.0.0-pre8
  as sed; this fails.

root# ln -s busybox-pre8 /bin/sed-8
root# mv /bin/sed-8 /bin/sed
root# sed --version
This is not GNU sed version 4.0
root# sed --
BusyBox v1.00-pre8 (2004.03.30-02:44+0000) multi-call binary

Usage: sed [-nef] pattern [files...]
root# sh -x 1.sh
+ cd /tmp
+ rm -f ipsec.conf ipsec.conf+
+ cat
+ sed -e /^config setup/a\
        nat_traversal=yes ipsec.conf
+ mv -f ipsec.conf+ ipsec.conf
root# cat ipsec.conf
version 2.0

config setup
nat_traversal=yes
        klipsdebug=none
        plutodebug=none
        plutostderrlog=/dev/null

conn %default
        keyingtries=1
        ...
root#
=== reproduction recipe ends here ===

This problem was introduced in 1.0.0-pre4.  The problem is that
the command argument parsing code strips leading whitespaces too
aggressively.  When running the above example, the piece of code
in question gets "\n\tnat_traversal=yes" as its argument in
cmdstr variable (shown part in the following patch).  What it
needs to do at this point is to strip the first newline and
nothing else, but it instead strips all the leading whitespaces
at the beginning of the string, thus losing the tab character.
The following patch fixes this.
2004-03-31 11:42:40 +00:00
applets Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
archival Add missing include files 2004-03-27 11:26:32 +00:00
console-tools Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
coreutils s/fileno\(stdin\)/STDIN_FILENO/g 2004-03-27 10:02:48 +00:00
debian Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
debianutils Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
docs Yet more doc cleanups 2004-03-27 11:35:46 +00:00
editors Junio Hamano, junio at twinsun dot com writes: 2004-03-31 11:42:40 +00:00
examples Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
findutils Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
include As noted by Martin Schwenke, the example for find was wrong 2004-03-29 08:20:08 +00:00
init Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
libbb Add missing include files 2004-03-27 11:26:32 +00:00
libpwdgrp Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
loginutils passwd and sulogin also need libcrypt, via libbb/pw_encrypt() 2004-03-27 10:08:53 +00:00
miscutils Tito noticed a printf that should have been a bb_error_msg. 2004-03-20 00:56:46 +00:00
modutils As noted in a patch from Kendrick Hamilton, rmmod was only 2004-03-19 21:00:03 +00:00
networking Patch from Thomas Winkler: 2004-03-31 11:30:08 +00:00
patches Patch from Thomas Winkler showing the the system time for each process 2004-03-31 11:21:24 +00:00
procps Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
scripts Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
shell s/fileno\(stdin\)/STDIN_FILENO/g 2004-03-27 10:02:48 +00:00
sysdeps/linux Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
sysklogd Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
tests Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
testsuite Isolate code better for unused options, config option to enable long 2003-12-26 14:01:37 +00:00
util-linux Sigh. what a mess. 2004-03-30 09:33:18 +00:00
.cvsignore Yet another major rework of the BusyBox config system, using the considerably 2002-12-05 08:41:41 +00:00
.indent.pro First revision of the Busybox Style Guide and an accompanying .indent.pro 2000-07-24 22:36:06 +00:00
AUTHORS Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
Changelog Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
INSTALL Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
LICENSE Update a bunch of docs. Run a script to update my email addr. 2003-07-14 21:21:08 +00:00
Makefile Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00
README Update docs 2004-03-27 09:40:15 +00:00
Rules.mak Remove trailing whitespace. Update copyright to include 2004. 2004-03-15 08:29:22 +00:00

README 

Please see the LICENSE file for details on copying and usage.

BusyBox combines tiny versions of many common UNIX utilities into a single
small executable. It provides minimalist replacements for most of the utilities
you usually find in GNU coreutils, util-linux, etc. The utilities in BusyBox
generally have fewer options than their full-featured GNU cousins; however, the
options that are included provide the expected functionality and behave very
much like their GNU counterparts. BusyBox provides a fairly complete POSIX
environment for any small or embedded system.

BusyBox has been written with size-optimization and limited resources in mind.
It is also extremely modular so you can easily include or exclude commands (or
features) at compile time. This makes it easy to customize your embedded
systems. To create a working system, just add /dev, /etc, and a Linux kernel.

BusyBox is extremely configurable.  This allows you to include only the
components you need, thereby reducing binary size. Run 'make config' or
'make menuconfig' for select the functionality that you wish to enable.

After the build is complete, a busybox.links file is generated.  This is
used by 'make install' to create symlinks to the BusyBox binary for all
compiled in functions.  By default, 'make install' will place the symlink
forest into `pwd`/_install unless you have defined the PREFIX environment
variable (i.e., 'make PREFIX=/tmp/foo install')

If you wish to install hard links, rather than symlinks, you can use
'make PREFIX=/tmp/foo install-hardlinks' instead.

----------------

Supported architectures:

   BusyBox in general will build on any architecture supported by gcc.  It has
   a few specialized features added for __sparc__ and __alpha__.  insmod
   functionality is currently limited to x86, ARM, SH3/4, powerpc, m68k,
   MIPS, cris, and v850e.

Supported C Libraries:

   glibc-2.0.x, glibc-2.1.x, glibc-2.2.x, glibc-2.3.x, uClibc.  People
   are looking at newlib and diet-libc, but consider them unsupported,
   untested, or worse.  Linux-libc5 is no longer supported -- you
   should probably use uClibc instead if you want a small C library.

Supported kernels:

   Full functionality requires Linux 2.2.x or better.  A large fraction of the
   code should run on just about anything.  While the current code is fairly
   Linux specific, it should be fairly easy to port the majority of the code
   to, say, FreeBSD or Solaris, or MacOsX, or even Windows (if you are into that
   sortof thing).

----------------

Getting help:

When you find you need help, you can check out the BusyBox mailing list
archives at http://busybox.net/lists/busybox/ or even join
the mailing list if you are interested.

----------------

Bugs:

If you find bugs, please submit a detailed bug report to the BusyBox mailing
list at busybox@mail.busybox.net.  A well-written bug report should include a
transcript of a shell session that demonstrates the bad behavior and enables
anyone else to duplicate the bug on their own machine. The following is such
an example:

    To: busybox@mail.busybox.net
    From: diligent@testing.linux.org
    Subject: /bin/date doesn't work

    Package: BusyBox
    Version: 1.00

    When I execute BusyBox 'date' it produces unexpected results.
    With GNU date I get the following output:

	$ date
	Sat Mar 27 14:19:41 MST 2004

    But when I use BusyBox date I get this instead:

	$ date
	illegal instruction

    I am using Debian unstable, kernel version 2.4.25-vrs2 on a Netwinder,
    and the latest uClibc from CVS.  Thanks for the wonderful program!

	-Diligent

Note the careful description and use of examples showing not only what BusyBox
does, but also a counter example showing what an equivalent GNU app does.  Bug
reports lacking such detail may never be fixed...  Thanks for understanding.

----------------

Downloads:

Source for the latest released version, as well as daily snapshots, can always
be downloaded from
    http://busybox.net/downloads/

----------------

CVS:

BusyBox now has its own publicly browsable CVS tree at:
    http://busybox.net/cgi-bin/cvsweb/busybox/

Anonymous CVS access is available.  For instructions, check out:
    http://busybox.net/cvs_anon.html

For those that are actively contributing there is even CVS write access:
    http://busybox.net/cvs_write.html

----------------

Please feed suggestions, bug reports, insults, and bribes back to:
	Erik Andersen
	<andersen@codepoet.org>