emo/openrc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,514 Commits 1 Branch 0 Tags
63a5ee3d8c75db0ce89a755264f0d871107668d3
Commit Graph

3514 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
NRK 63a5ee3d8c seedrng: fix memory leak reported by clang-tidy 
`seed_dir` gets allocated via xstrdup but never gets freed - which
clang-tidy flags as a memory leak.

instead of free-ing the allocation, just don't allocate to begin with
since there's no need for it.

also bump the copyright year.
 2023-02-05 00:38:20 -05:00
NRK 36cc40a9d6 bash-completions/rc-service: don't use grep 
Co-authored-by: Mike Frysinger <vapier@gentoo.org>
Closes: https://github.com/OpenRC/openrc/issues/344
 2023-02-02 19:37:09 -05:00
NRK ae5e38dce5 start-stop-daemon: avoid malloc inside sig-handler 
same rational as 459783bb

Bug: https://github.com/OpenRC/openrc/issues/589
 2023-01-30 22:54:20 -05:00
NRK 5858f980c8 openrc-run: avoid malloc inside sig-handler 
same rational as 459783bb

Bug: https://github.com/OpenRC/openrc/issues/589
 2023-01-30 22:54:20 -05:00
Sam James db96295e00 value: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James f5ed484920 swclock: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 00f90f2b0e supervise-daemon: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James b405681926 start-stop-daemon: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James d5700d036a shell_var: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 616f756ca8 shared: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 17cfb41d81 service: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 1bc87b7a7c seedrng: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James f3be11a00d rc-update: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 406ab2a4ca rc-status: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 7878a53542 rc-service: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 084e6b5e20 rc-depend: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James a7bd13145b rc-abort: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 28ecb38515 openrc-shutdown: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 91737be1ab openrc-run: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James fb6ffc5713 openrc: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 01acbe3c27 openrc-init: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James aa5c3ccd0b mountinfo: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James d795ea183f mark_service: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 5af3944440 librc: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 01bcdb43b6 libeinfo: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James bcd1975fe7 kill_all: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 57e194df4f is_older_than: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James dacd0ab189 is_newer_than: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 7cfe93d032 fstabinfo: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James 893df75e30 einfo: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James c80d6bb2ed checkpath: missing includes from IWYU 2023-01-29 11:32:22 -06:00
Sam James bfe38c98a8 src: shared: schedules: add missing includes to header 
Needed for clang-tidy prep work, as it requires headers to work standalone
(which is useful anyway).
 2023-01-28 22:14:30 -06:00
Sam James e8a76ad6e6 src: shared: plugin: add missing includes to header 
Needed for clang-tidy prep work, as it requires headers to work standalone
(which is useful anyway).
 2023-01-28 22:14:30 -06:00
Sam James 7d63049adb src: shared: misc: add missing includes to header 
Needed for clang-tidy prep work, as it requires headers to work standalone
(which is useful anyway).
 2023-01-28 22:14:30 -06:00
Sam James dc0b3157a9 src: shared: helpers: add missing includes to header 
Needed for clang-tidy prep work, as it requires headers to work standalone
(which is useful anyway).
 2023-01-28 22:14:30 -06:00
Sam James 2f6b5b7ef4 openrc: rc-logger: add missing includes to header 
Needed for clang-tidy prep work, as it requires headers to work standalone
(which is useful anyway).
 2023-01-28 22:14:30 -06:00
NRK eb3635dd1f swclock: fix codeql warning and upgrade to futimens 
this was reported by codeql's scan as a TOCTOU bug. while that's true in
theory, i don't believe it would've had any practical effect.

a better justification for this change might be the fact that it
upgrades from `utime` (which is depreciated by POSIX [0]) to `futimens`.

[0]: https://www.man7.org/linux/man-pages/man3/utime.3p.html#FUTURE_DIRECTIONS
 2023-01-28 16:19:33 -05:00
NRK 459783bbad openrc: avoid unnecessary malloc inside sig-handler 
malloc (called by xasprintf) is not async-signal-safe. beside, the
string here is constant, so there's no need to malloc it all.

eerrorx isn't async-signal-safe either (due to calling fprintf and exit)
but consequence of them are _typically_ not as grave as calling malloc
while it's internal state is inconsistent.

Bug: https://github.com/OpenRC/openrc/issues/589
 2023-01-28 13:08:00 -05:00
Sam James a28bdc7e5c openrc-shutdown: mark handler as noreturn, use _unused macro 2023-01-25 01:11:25 -05:00
Sam James bcae7d03b4 openrc: mark handle_bad_signal as noreturn 
For -Wmissing-noreturn.
 2023-01-25 00:51:13 -05:00
Sam James ccc2b71145 supervise-daemon: mark various functions as noreturn 
For -Wmissing-noreturn.
 2023-01-25 00:50:43 -05:00
Sam James 78c0693c50 openrc-shutdown: mark stop_shutdown as noreturn, fix typo/indentation 
For -Wmissing-noreturn.
 2023-01-25 00:50:15 -05:00
Sam James ddf4a3a7a0 shared: move _noreturn definition into helpers.h 2023-01-25 00:49:47 -05:00
Sam James a6568c304f libeinfo: fix -Wunused-but-set-variable 2023-01-25 00:49:22 -05:00
Sam James d6a5264a9d librc: fix 'init' memory leak 
From scan-build w/ clang-16.0.0_pre20230107:
```
../src/librc/librc.c:759:14: warning: Potential leak of memory pointed to by 'init' [unix.Malloc]
                                                return false;
                                                       ^~~~~
```
 2023-01-25 00:48:26 -05:00
Sam James 9f227e8b49 openrc-run: drop strlen dead store 2023-01-25 00:08:30 -05:00
Sam James 3bb5450320 openrc-shutdown: fix need_warning dead store 
It's already initialised to false at the start and it's clear when reading
what the flow is.

While at it, fix some indentation and adjust whitespace to make more readable.
 2023-01-25 00:07:03 -05:00
Sam James a689fdb7be openrc-run: fix -Wunused-but-set-variable 2023-01-25 00:06:27 -05:00
Sam James fc4f15d6cd openrc: fix double-assignment to dir 
This one is a bit odd, it didn't get fixed in e273b4e08e,
and goes all the way back to cb9da6a262.
 2023-01-25 00:05:32 -05:00
Sam James 19f329d2f4 openrc, openrc-run: Fix -Wstrict-prototypes 
These become fine with C23 because () starts to mean (void) then, but for
previous language versions, it's deprecated, and it causes an annoying
warning when building with Clang by default.

Plus, GCC lacks specific flags to trigger what C23 *does* ban, so a lot
of people are going around building with -Wstrict-prototypes, so let's
just fix this to be consistent with the rest of the codebase anyway
to fend off false positive reports.
 2023-01-25 00:05:05 -05:00