emo/procps
1
0
Fork 0
Code Issues Pull Requests Packages Releases Activity

Allow core file generation by ps command (rhbz#871825, rhbz#512857)

Browse Source 
Since the ps command handles signals with it's own handler, it doesn't create
core files when something wrong happens. The attached patch restores the ps
command ability to create core files by calling the default handler once we
print our custom message. The original RH's workaround masked SIGABRT and
SIGSEGV signals and that would conflict with the original intention of the
custom signal handler and also with the filtering patch I sent in my previous
email. Moreover, this solution generates core for all relevant signals (SIGFPE,
etc.).

Bug-Redhat: http://bugzilla.redhat.com/871825
Bug-Redhat: http://bugzilla.redhat.com/512857
Reference: http://www.freelists.org/post/procps/PATCH-Allow-core-file-generation-by-ps-command-rhbz871825-rhbz512857

Signed-off-by: Craig Small <csmall@enc.com.au>
This commit is contained in:
Jaromir Capik 2012-12-12 15:37:42 +01:00 committed by Craig Small
parent cfd0dbd336
commit c1f10d11bc
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ps/display.c
View File

@ -62,7 +62,9 @@ static void signal_handler(int signo){
case SIGUSR2:
exit(EXIT_FAILURE);
default:
catastrophic_failure(__FILE__, __LINE__, _("please report this bug"));
error_at_line(0, 0, __FILE__, __LINE__, "%s", _("please report this bug"));
signal(signo, SIG_DFL); /* allow core file creation */
kill(getpid(), signo);
}
}