a210d898b6
* man/po/fr.po: Fix some spacing issues due to configuration variants.
nekral-guest
2011-07-14 14:14:36 +00:00
8bce7fc016
* src/passwd.c: Overflow when computing the number of days based on the scaling. Use of long long needed.
nekral-guest
2011-07-14 14:03:19 +00:00
39cecdab06
* NEWS, lib/commonio.h, lib/commonio.c: Additional messages to indicate why locking failed. * NEWS, lib/commonio.c: Fix the sort algorithm in case of NIS. NIS entries were dropped. * lib/commonio.c: NIS entries can start by '+' or '-'.
nekral-guest
2011-07-14 13:58:17 +00:00
a7fee9db00
* NEWS, src/groupmod.c: When the gshadow file exists but there are no gshadow entries, an entry is created if the password is changed and group requires a shadow entry.
nekral-guest
2011-07-14 13:30:05 +00:00
d4e630b8cc
* src/usermod.c (process_flags): Indicate that the user name is invalid, instead of just a 'field'.
nekral-guest
2011-07-14 13:29:59 +00:00
82b92af086
* src/usermod.c (process_flags): Do not display the usage in case of an invalid -f value (similar to -e).
nekral-guest
2011-07-14 13:29:54 +00:00
c23e851074
* src/usermod.c (new_pwent): Document that pw_locate will not fail because getpwnam returned successfully.
nekral-guest
2011-07-14 13:29:48 +00:00
c2333946c0
* man/usermod.8.xml: Document behavior of an empty EXPIRE_DATE. * man/usermod.8.xml: Document that the mail spool might have to be renamed (as for the homedir)
nekral-guest
2011-07-14 13:29:43 +00:00
2c6782b501
* NEWS, src/usermod.c; man/usermod.8.xml: When the shadow file exists but there are no shadow entries, an entry has to be created if the password is changed and passwd requires a shadow entry, or if aging features are used (-e or -f). Document this and also that -e and -f require a shadow file.
nekral-guest
2011-07-14 13:29:37 +00:00
c2f5088067
* src/usermod.c (update_group, update_gshadow): Reduce complexity and document checks. Some checks were always true/false within their call context.
nekral-guest
2011-07-14 13:29:32 +00:00
2798e35d86
* src/usermod.c: usage() does not return. Add annotations.
nekral-guest
2011-07-14 13:29:22 +00:00
d1753cc25d
* src/usermod.c (process_flags): Check for oflg is not needed to check if changes are needed.
nekral-guest
2011-07-14 13:29:16 +00:00
a5ded26850
* src/usermod.c (process_flags): Report usage if no options are provided. Update the error message. * src/usermod.c (process_flags): Check option compatibility and dependency before options are discarded when no changes are requested.
nekral-guest
2011-07-14 13:29:10 +00:00
d51420bb01
* src/usermod.c (move_home): It is always an error to use -m if the new home directory already exist (independently from the existence of the old home directory did not exist)
nekral-guest
2011-07-14 13:29:05 +00:00
95257d63a1
* src/groupmod.c: Avoid implicit conversion of pointer to boolean. * src/groupmod.c: osgrp can be set only if pflg || nflg. No need to check for pflg || nflg again
nekral-guest
2011-07-08 19:58:40 +00:00
13873a8799
* lib/fields.c: Fixed typo from 2010-02-15. field insteadof cp ought to be checked. * src/vipw.c: Use Prog instead of progname. This is needed since Prog is used in the library.
nekral-guest
2011-07-08 19:56:18 +00:00
cc6eaf9584
Fix typo in comment.
nekral-guest
2011-07-08 19:51:32 +00:00
3bdad35e9f
* man/*.xml, man/config.xml.in: Add source and version information. This reduce the amount of warnings during the manpages generation.
nekral-guest
2011-07-08 19:49:09 +00:00
275ac4c5e0
* man/po/ru.po: Add space between option and argument.
nekral-guest
2011-06-25 09:13:14 +00:00
907025eb40
* src/su.c: environ is provided by <unistd.h>. * src/su.c: Added function prototypes. * src/su.c: Rename shellstr parameter to shellname to avoid collision with static variable. * NEWS, src/su.c: Added support for PAM modules which change PAM_USER.
nekral-guest
2011-06-16 21:21:29 +00:00
317939e821
* src/su.c: After prepare_pam_close_session() there is no need to close the session in the child. Added pam_setcred to prepare_pam_close_session().
nekral-guest
2011-06-13 18:27:46 +00:00
1340beed16
* src/su.c: Also drop the controlling terminal when PAM is not used. * src/su.c: Remove run_shell().
nekral-guest
2011-06-13 18:27:40 +00:00
e9045e9f55
* src/su.c (prepare_pam_close_session): Extract the creation of a child and listening for signal in the parent from run_shell(). prepare_pam_close_session() is now executed before the creation of the pam session and before the UID is changed. This allows to close the session as root.
nekral-guest
2011-06-13 18:27:34 +00:00
69371ba2c2
* src/su.c: Extract export of environment from main().
nekral-guest
2011-06-13 18:27:28 +00:00
dbe0b96404
* src/su.c: Extract command line processing from main().
nekral-guest
2011-06-13 18:27:23 +00:00
43e65fdd46
* src/su.c: Close the password databases together with syslog.
nekral-guest
2011-06-13 18:27:17 +00:00
5d6f4f8ea4
* src/su.c: Merge environment setting blocks after the creation of the session.
nekral-guest
2011-06-13 18:27:12 +00:00
927c2f06a3
* src/su.c: Split check_perms() in to a PAM (check_perms_pam) and a non-PAM (check_perms_nopam) version.
nekral-guest
2011-06-13 18:26:58 +00:00
7ebfb5c90f
* lib/prototypes.h, src/suauth.c, src/su.c (check_su_auth): Do not use the pwent global variable to communicate between APIs of different files. Added boolean parameter su_to_root to check_su_auth(). * src/su.c (check_perms): Return the passwd entry of the finally authenticated user. Remove usage of the pwent variable. * src/su.c: The password of the caller is the one from the spwd structure only if the passwd's password is 'x'.
nekral-guest
2011-06-13 18:26:26 +00:00
3abd71c526
* src/su.c: Extract the authentication from the main function.
nekral-guest
2011-06-13 18:26:16 +00:00
dc90c77285
* src/su.c: Define shellstr before the environment so that restricted_shell is called only once. This will allow moving the environment definition after the switch to the new user.
nekral-guest
2011-06-13 18:26:10 +00:00
2f71935616
* src/su.c: Move definition of change_environment and shellstr after the switch to the final subsystem. The previous architecture forced to always change the environment (the shell starts with a '*' and was thus restricted, and change_environment could not be reset to false).
nekral-guest
2011-06-13 18:25:57 +00:00
941e94f1d2
* src/su.c: No need to change the user's shell in case of subsystem root. Update the comments.
nekral-guest
2011-06-13 18:25:51 +00:00
4be8077a56
* src/su.c: Group some of the environment processing blocks. The definition of shellstr, PATH and IFS is not influenced (getenv, getdef, restricted_shell) by and does not influence (addenv does not change environ) the authentication. And the authentication does not overwrite those definitions. This will ease an extraction from the big main() function.
nekral-guest
2011-06-13 18:25:45 +00:00
aef33a89c2
* src/su.c: No need to call expire() if there are no shadow entry. No need to convert a passwd entry into an spwd entry in that case.
nekral-guest
2011-06-13 18:25:40 +00:00
1ddde00b1d
* src/su.c: Updating pwent after expire() is not useful. Only the password information may have changed and they are not used anymore afterwards.
nekral-guest
2011-06-13 18:25:34 +00:00
f66bd259cf
French manpages translation
bubulle
2011-06-12 19:55:58 +00:00
ea34d36d62
Document the updated translations.
nekral-guest
2011-06-05 14:56:11 +00:00
b5403415f7
* NEWS, src/su.c: Do not forward the controlling terminal to commands executed with -c. This prevents tty hijacking which could lead to execution with the caller's privileges. This required to forward signals from the terminal (SIGINT, SIGQUIT, SIGTSTP) to the executed command.
nekral-guest
2011-06-05 14:41:15 +00:00
a8ca723277
* NEWS, src/userdel.c: Do not remove a group with the same name as the user (usergroup) if this group isn't the user's primary group.
nekral-guest
2011-06-05 12:23:59 +00:00
14f44bd9c9
* NEWS, src/userdel.c: Check the existence of the user's mail spool before trying to remove it. If it does not exist, a warning is issued, but no failure.
nekral-guest
2011-06-04 22:38:57 +00:00
ce737cf543
* src/sulogin.c: Added Prog, needed because of the last xmalloc() change.
nekral-guest
2011-06-03 21:08:56 +00:00
e8723c375f
* man/zh_CN/, man/zh_CN/Makefile.am: Added directory, and zh_CN Makefile. * man/Makefile.am: Build zh_CN pages. * man/generate_translations.mak: Add config.xml to CLEANFILES. * man/po/zh_CN.po: limits, groups, faillog, expiry should not be translated (command name, file name), also this broke the build system as they are used to derive manpage names.
nekral-guest
2011-06-03 21:07:58 +00:00
6b14946d81
* man/zh_CN/, man/zh_CN/Makefile.am: Added directory, and zh_CN Makefile. * man/Makefile.am: Build zh_CN pages. * man/generate_translations.mak: Add config.xml to CLEANFILES. * man/po/zh_CN.po: limits, groups, faillog, expiry should not be translated (command name, file name), also this broke the build system as they are used to derive manpage names.
nekral-guest
2011-06-03 21:06:23 +00:00
597bb764f1
* src/lastlog.c, src/faillog.c: Fix underflows causing wrong entry to be displayed.
nekral-guest
2011-06-02 20:26:30 +00:00
ee163bed33
* libmisc/user_busy.c, src/userdel.c, src/usermod.c: Warn in user_busy() rather than in src/userdel.c or src/usermod.c to provide more accurate failure cause (user is logged in or user still executes processes).
nekral-guest
2011-02-16 20:46:27 +00:00
f4b544786c
Added missing Changelog entry for lib/fields.c: * lib/fields.c: Fail if input pointer is NULL.
nekral-guest
2011-02-16 20:33:16 +00:00
d7fa77f03b
* lib/groupio.c, lib/sgroupio.c, lib/shadowio.c, lib/pwio.c: Check entry validity before commits to databases. * libmisc/fields.c, libmisc/Makefile.am, lib/fields.c, lib/Makefile.am, po/POTFILES.in: fields.c moved from libmisc to lib.
nekral-guest
2011-02-16 20:32:16 +00:00
a9b8e7aaa3
Adapt ignore list to previous commits.
nekral-guest
2011-02-16 20:27:25 +00:00
0419fc4f5f
* NEWS, src/chfn.c, src/chsh.c: Fix CVE-2011-0721: forbid \n in gecos or shell.
nekral-guest
2011-02-16 00:18:45 +00:00
0398323a60
* autogen.sh: Restore original autoreconf (see 2010-08-29's change for autogen.sh) * configure.in, man/po/Makefile.in.in, man/po/Makefile.in: Makefile.in.in replaced by Makefile.in to avoid config.status issues when there are multiple po directories. * man/po/LINGUAS: Adapted to above change. * man/po/POTFILES.in, man/po/XMLFILES: POTFILES.in replaced by XMLFILES. * man/Makefile.am: generate_mans.deps shall be included by make, not automake.
nekral-guest
2011-02-12 14:57:37 +00:00
8b4f07692e
* NEWS, libmisc/console.c: Fix CONSOLE parser. This caused login to hang when CONSOLE was configured with a colon separated list of TTYs. See http://bugs.gentoo.org/show_bug.cgi?id=324419
nekral-guest
2010-11-19 21:54:41 +00:00
dffc624b37
Integrate review comments from Julien Cristau * libmisc/copydir.c: Missing parenthesis in comment. * libmisc/chowndir.c: Fixed memory leak on failed realloc(). * libmisc/chowndir.c: Make sure the buffer for the path is large enough. * libmisc/remove_tree.c: Remove check for NULL before free().
nekral-guest
2010-09-05 15:34:42 +00:00
1d336d3a1e
* lib/protoypes.h, libmisc/copydir.c, src/useradd.c: selinux_file_context renamed set_selinux_file_context. * lib/protoypes.h, libmisc/copydir.c, src/useradd.c: Added reset_selinux_file_context. * src/useradd.c: Check the return value of set_selinux_file_context and reset_selinux_file_context. * libmisc/copydir.c: Check the return value of reset_selinux_file_context.
nekral-guest
2010-08-28 19:58:00 +00:00
991ce97170
* src/su.c: Fix handling of environment variables when the environment is not changed. In particular, this makes su behave as documented regarding PATH and IFS (i.e. they are reset) when -p is provided.
nekral-guest
2010-08-28 19:55:31 +00:00
07e462f01f
* libmisc/limits.c: Avoid implicit conversion of integer to boolean. * libmisc/basename.c: Avoid implicit conversion of pointer to boolean. * libmisc/basename.c, lib/prototypes.h (Basename): Return a constant string. * libmisc/basename.c, libmisc/obscure.c, lib/prototypes.h, libmisc/xmalloc.c, libmisc/getdate.h, libmisc/system.c, libmisc/getgr_nam_gid.c, libmisc/failure.c, libmisc/valid.c: Add splint annotations. * libmisc/chowndir.c: Avoid memory leak. * libmisc/chowndir.c: Do not check *printf/*puts return value. * libmisc/chowntty.c: Avoid implicit conversion between integer types. * libmisc/obscure.c: Return a bool when possible instead of int. * libmisc/shell.c: Do not check *printf/*puts return value. * libmisc/shell.c: Do not check execle return value. * libmisc/setupenv.c: Avoid implicit conversion between integer types. * libmisc/xmalloc.c: size should not be zero to avoid returning NULL pointers. * libmisc/hushed.c: Do not check *printf/*puts return value. * libmisc/system.c: Avoid implicit conversion of integer to boolean. safe_system last argument is a boolean. * libmisc/system.c: Check return value of dup2. * libmisc/system.c: Do not check *printf/*puts return value. * libmisc/system.c: Do not check execve return value. * libmisc/salt.c: Do not check *printf/*puts return value. * libmisc/loginprompt.c: Do not check gethostname return value. * libmisc/find_new_gid.c, libmisc/find_new_uid.c: Do not check gr_rewind/pw_rewind return value. * libmisc/ttytype.c: Limit the number of parsed characters in the sscanf format. * libmisc/ttytype.c: Test if a type was really read. * libmisc/sub.c: Do not check *printf/*puts return value. * libmisc/sub.c: Avoid implicit conversion of integer to boolean. * src/userdel.c: Fix typo in comment. * src/userdel.c: Avoid implicit conversion of boolean to integer. * src/userdel.c: safe_system last argument is a boolean. * src/newusers.c: Avoid implicit conversion of boolean to integer. * src/newusers.c: Avoid implicit conversion of integer to boolean. * src/usermod.c: Add brackets. * src/usermod.c: Avoid implicit conversion of characters or integers to booleans. * src/vipw.c: Avoid implicit conversion of integer to boolean. * src/su.c: Avoid implicit conversion of integer to boolean. * src/su.c: Add brackets. * src/useradd.c: Avoid implicit conversion of characters or integers to booleans.
nekral-guest
2010-08-22 19:13:53 +00:00
471a2df3a6
* libmisc/obscure.c, lib/prototypes.h (obscure): Return a bool instead of an int. * libmisc/obscure.c, libmisc/tz.c, src/passwd.c, lib/encrypt.c, libmisc/copydir.c, lib/prototypes.h: Add splint annotations. * libmisc/tz.c: Fix some const issues. * libmisc/tz.c: Avoid multi-statements lines. * libmisc/tz.c: Add brackets. * libmisc/copydir.c: Do not check *printf/*puts return value. * libmisc/copydir.c: Fail if we cannot set or reset the SELinux fscreate context. * libmisc/copydir.c: Use xmalloc instead of malloc. * libmisc/copydir.c: Do not check lutimes return value * src/vipw.c: Avoid implicit conversion of integer to boolean. * src/su.c (iswheel): Return a bool instead of an int. * src/passwd.c: Remove insert_crypt_passwd(). Use xstrdup instead. * src/passwd.c: Return constant strings when sufficient. * src/passwd.c: Do not check *printf/*puts return value. * src/passwd.c: Avoid implicit conversion of character to boolean. * src/passwd.c: Do not check sleep return value. * src/sulogin.c: Do not check *printf/*puts return value. * lib/encrypt.c: Do not check fprintf return value.
nekral-guest
2010-08-22 12:49:07 +00:00
nekral-guest
bubulle