57f9d5ae9c
* src/chage.c, src/chfn.c, src/chgpasswd.c, src/chpasswd.c, src/chsh.c, src/groupadd.c, src/groupdel.c, src/groupmems.c, src/groupmod.c, src/newusers.c, src/useradd.c, src/userdel.c, src/usermod.c: Provide the PAM error message instead of our own, and log error to syslog. * src/groupmems.c: Exit with exit rather than fail_exit in usage(). * src/newusers.c: Check the number of arguments. * src/newusers.c: Do not create the home directory when it is not changed. * src/useradd.c: Set the group password to "!" rather "x" if there are no gshadow file.
nekral-guest
2011-11-13 16:24:57 +00:00
2ecea675ee
Fix cut&paste issue from yesterday.
nekral-guest
2011-11-13 16:24:49 +00:00
f64c88d629
* src/pwck.c: Removed pw_opened. * src/pwck.c: optind cannot be greater than argc. * src/pwck.c: If spw_opened, then is_shadow is implicitly set. * src/pwck.c: Do not report passwd entry without x password and a shadow entry in --quiet mode (no interaction with the caller) * src/pwck.c: Do not check if the last password change is in the future if the time is set to 0.
nekral-guest
2011-11-13 16:24:39 +00:00
3c608e56f6
* libmisc/root_flag.c: Drop privileges before changing root. The --root option should not be used by regular users for suid utils. * libmisc/root_flag.c: Improve error messages.
nekral-guest
2011-11-11 12:09:58 +00:00
e4fbf98b18
* man/limits.5.xml, libmisc/limits.c: Sort limit identifiers. * libmisc/limits.c: Fix support for the K limit identifier. * libmisc/limits.c: Add missing default limit for L and U.
nekral-guest
2011-11-06 18:39:47 +00:00
a2d23700e4
* NEWS, src/faillog.c, man/faillog.8.xml: Add --root option. * NEWS, src/lastlog.c, man/lastlog.8.xml: Likewise. * src/faillog.c: Add Prog variable, and prefix error messages with Prog rather than "faillog". * src/lastlog.c: Likewise. * src/lastlog.c: Split usage in smaller messages.
nekral-guest
2011-11-06 18:39:03 +00:00
0857837e64
* NEWS, src/chage.c, man/chage.1.xml: Add --root option. Open audit and syslog after the potential chroot. chage's usage split in smaller messages.
nekral-guest
2011-11-06 18:38:57 +00:00
d15f2c6214
* src/login.c: re-indent. * src/login.c: Fix support for sub-logins.
nekral-guest
2011-11-06 18:38:51 +00:00
6eb0500d3d
* src/faillog.c, src/chage.c, src/newusers.c, src/su.c: The getopt index of long options is not used.
nekral-guest
2011-11-06 18:38:45 +00:00
7b8c4952a8
* NEWS, src/gpasswd.c, man/gpasswd.1.xml: Add --root option. * src/gpasswd.c: The getopt index of long options is not used.
nekral-guest
2011-11-06 18:38:39 +00:00
4beca611fb
* NEWS, src/chsh.c, man/chsh.1.xml: Add --root option. chsh's usage split in smaller messages. * src/chsh.c: The getopt index of long options is not used.
nekral-guest
2011-11-06 18:38:32 +00:00
1aa30ba551
* NEWS, src/groupmems.c, man/groupmems.8.xml: Add --root option. Open syslog after the potential chroot. * src/groupmems.c: The getopt index of long options is not used.
nekral-guest
2011-11-06 18:38:26 +00:00
fc5cd8840e
sort per util.
nekral-guest
2011-11-06 18:38:21 +00:00
ec2b9f59f7
* NEWS, src/passwd.c, man/passwd.1.xml: Add --root option. passwd's usage split in smaller messages. * src/passwd.c: Call sanitize_env() before setting the locales.
nekral-guest
2011-11-06 18:38:16 +00:00
799f30b08d
* NEWS, src/chpasswd.c, man/chpasswd.8.xml, src/chgpasswd.c, man/chgpasswd.8.xml: Add --root option. * src/chpasswd.c, src/chgpasswd.c: The getopt index of long options is not used.
nekral-guest
2011-11-06 18:38:10 +00:00
c017dd73aa
* src/groupdel.c: Add process_flags(). * src/groupdel.c, man/groupdel.8.xml: Add --help option. * NEWS, src/groupdel.c, man/groupdel.8.xml: Add --root option. Open audit and syslog after the potential chroot. * src/groupdel.c: Check atexit failures.
nekral-guest
2011-11-06 18:37:57 +00:00
9195f6085d
* NEWS, src/groupadd.c, man/groupadd.8.xml: Add --root option. Open audit and syslog after the potential chroot. * src/groupmod.c: The index of long options is not used.
nekral-guest
2011-11-06 18:37:51 +00:00
057cbaa4ae
* NEWS, src/groupadd.c, man/groupadd.8.xml: Add --root option. Open audit after the potential chroot. * src/groupadd.c: Check atexit failures. * src/groupadd.c: Return E_SUCCESS instead of exit'ing at the end of main().
nekral-guest
2011-11-06 18:37:45 +00:00
aa2957e62a
* NEWS, src/usermod.c, man/usermod.8.xml: Add --root option. Open audit and syslog after the potential chroot. userdel's usage split in smaller messages.
nekral-guest
2011-11-06 18:37:39 +00:00
50eafd769b
* NEWS, src/userdel.c, man/userdel.8.xml: Add --root option. Open audit and syslog after the potential chroot. userdel's usage split in smaller messages.
nekral-guest
2011-11-06 18:37:32 +00:00
cecae46ccf
* NEWS, src/useradd.c, man/useradd.8.xml: Add --root option. Open audit after the potential chroot.
nekral-guest
2011-11-06 18:37:25 +00:00
0b5574c28a
* lib/prototypes.h, libmisc/Makefile.am, libmisc/root_flag.c, po/POTFILES.in: Add process_root_flag() to process the --root option and chroot so that the chroot config is used and changes are applied to the chroot.
nekral-guest
2011-11-06 18:37:19 +00:00
c237be820b
* man/ja/Makefile.am, man/fr/Makefile.am, man/ru/Makefile.am, man/sv/Makefile.am, man/pl/Makefile.am, man/zh_CN/Makefile.am, man/it/Makefile.am, man/Makefile.am: Include man_nopam in EXTRA_DIST only when USE_PAM (they are already in man_MANS otherwise).
nekral-guest
2011-10-22 08:59:08 +00:00
eee4152981
* man/su.1.xml: Document that su -c does not providea controlling terminal.
nekral-guest
2011-10-22 08:56:51 +00:00
2afa955401
* src/sulogin.c (main): env is only used when USE_PAM is not set.
nekral-guest
2011-10-18 20:28:01 +00:00
f870cc7eab
Miscellaneous: * lib/prototypes, libmisc/basename.c (Basename): Input is a constant string. * lib/prototypes.h, lib/spawn.h, lib/spawn.c, src/userdel.c, lib/nscd.c, lib/Makefile.am: Delete spawn.h. Move from spawn.h to prototypes.h. * src/userdel.c: Remove unused variables. * lib/nscd.c: Remove unused header files. * lib/nscd.c: Add the program name to error messages. * lib/nscd.c: Indicate when nscd does not terminate normally (signal). * lib/spawn.c: Updated header. * lib/spawn.c: Flush stdout and stderr to avoid inheriting from ongoing buffers. * lib/spawn.c: Avoid implicit conversion of pointer to boolean. * lib/spawn.c: Replace perror by a complete message. * lib/spawn.c: Continue to wait for the child if another child terminates. * lib/prototypes.h: The name field from cleanup_info_mod is a constant string. (username).
nekral-guest
2011-09-18 21:02:43 +00:00
05b55446da
* libmisc/cleanup.c: Spawn children should no trigger cleanup actions. Make sure only the parent (initial caller) perform the cleanup actions.
nekral-guest
2011-09-18 20:43:28 +00:00
f1db2383fc
* libmisc/salt.c (SHA_salt_rounds): It is statically ensured that the format fits in rounds_prefix. * libmisc/loginprompt.c: Likewise.
nekral-guest
2011-09-18 20:41:38 +00:00
cd10be6c91
* libmisc/salt.c (SHA_salt_rounds): It is statically ensured that the format fits in rounds_prefix.
nekral-guest
2011-09-18 20:40:50 +00:00
2b5ba27ff8
* src/grpconv.c: Fail if not called correctly. * src/grpconv.c: At the end of main, the passwd and shadow files are locked. No need to check before unlocking. No need to set the lock as false neither since there cannot be anymore failures.
nekral-guest
2011-09-18 20:26:27 +00:00
fa96d1bb78
* src/chage.c: EPOCH is not needed, it's converted to -1 by strtoday(). But we need to support "-1" specifically. * src/chage.c: Fix usage: LOGIN is mandatory. * src/chage.c: Display disabled expiry or last change as "-1" instead of 1969-12-31. 1969-12-31 is still supported as input from the user. * src/chage.c: Exit cleanly with fail_exit() (lock files were not removed).
nekral-guest
2011-09-18 20:24:36 +00:00
23afb3fd07
* src/useradd.c: Remove def_file. It was always set to USER_DEFAULTS_FILE. * src/useradd.c: Fix cut&paste issue causing bad warning when the useradd.default file contains an invalid INACTIVE= value. * src/useradd.c: Added missing end of line for rename errors. * src/useradd.c: Added -D synopsis to the usage message. * src/useradd.c: Do not scale_age(-1), just use -1. * src/useradd.c: Added FIXME to be fixed later. * src/useradd.c: Allow -e -1 when there is no shadow file. * src/useradd.c: Fail, but do not print the usage message when the -e argument is not valid. * src/useradd.c: No need to check for oflg since uflg is already checked.
nekral-guest
2011-09-18 18:00:06 +00:00
6f05b866bc
* src/su.c: Too much const were added on 2011-08-15. pw in save_caller_context() is allocated and freed. * src/su.c: Added missing #endif indication * src/su.c save_caller_context(): password only needed if SU_ACCESS and !USE_PAM.
nekral-guest
2011-09-18 17:47:03 +00:00
603d949ed5
* src/usermod.c: date_to_str() is always called with negativ set to "never", remove this argument. * src/usermod.c: Added missing cast for gr_free argument.
nekral-guest
2011-09-18 17:34:21 +00:00
4ce849a5ed
* src/pwconv.c: Fail if not called correctly. * src/pwconv.c: At the end of main, the passwd and shadow files are locked. No need to check before unlocking.
nekral-guest
2011-09-18 17:32:04 +00:00
7b0116c5b4
* src/newusers.c: Initially set the passwd's password to '*' instead of 'x'. Only when it is confirmed that a shadow entry is (will be) added, set the passwd's password to 'x'. * src/newusers.c: An invalid line is an error. A failure needs to be reported.
nekral-guest
2011-09-18 17:29:52 +00:00
a52a8d8a5d
* src/gpasswd.c: Remove log_gpasswd_success_gshadow(). Writing in gshadowis the last sub-task.
nekral-guest
2011-09-18 17:27:18 +00:00
75936bf9f7
* src/chsh.c: No needto remove lines tarting with '#' from /etc/shells. This is already done by getusershell() and these shell would fail the access(X_OK) test.
nekral-guest
2011-09-18 17:24:15 +00:00
0d00d3eecf
* man/generate_mans.mak: Fix the generation of translated man pages. xml2po removed the comment from empty headers and the config was no more inserted.
nekral-guest
2011-09-18 17:02:10 +00:00
93ee4927bc
* man/login.defs.d/QUOTAS_ENAB.xml: Document the dependency between /etc/limits and QUOTAS_ENAB.
nekral-guest
2011-09-18 17:00:28 +00:00
5570ec21b4
* man/chage.1.xml: The LOGIN argument is not optional.
nekral-guest
2011-09-18 16:59:16 +00:00
7f842bdf4f
* src/groupmod.c: Ignore return value from snprintf. * src/groupmod.c: Add static qualifier to the cleanup structures.
nekral-guest
2011-08-15 14:22:33 +00:00
7c96d6cbcc
* src/usermod.c: Do not assign static to NULL. * src/usermod.c (date_to_str): buf needs to be unique (e.g. independent from negativ), and is an out buffer. * src/usermod.c: Ignore return value from snprintf, and force nul-termination of buffer. * src/usermod.c: Improve memory management. * src/usermod.c: An audit bloc was not reachable, moved above on success to move the home directory. * src/usermod.c: Ignore close() return value for the mailbox (opened read only).
nekral-guest
2011-08-15 09:56:43 +00:00
00d1ab6454
* src/usermod.c: Add annotations to indicate that fail_exit() does not return. * src/usermod.c: Fix typo in notreached annotation.
nekral-guest
2011-07-30 01:41:03 +00:00
019048c555
* libmisc/find_new_uid.c: free (used_uids) on return. * libmisc/find_new_gid.c: free (used_gids) on return.
nekral-guest
2011-07-30 01:38:07 +00:00
e7c09ab3df
* NEWS, src/chpasswd.c: Create a shadow entry if the password is set to 'x' in passwd and there are no entry in shadow for the user. * NEWS, src/chgpasswd.c: Create a gshadow entry if the password is set to 'x' in group and there are no entry in gshadow for the group.
nekral-guest
2011-07-28 15:18:39 +00:00
75fa697526
* NEWS, src/chpasswd.c: Create a shadow entry if the password is set to 'x' in passwd and there are no entry in shadow for the user. * NEWS, src/chgpasswd.c: Create a gshadow entry if the password is set to 'x' in group and there are no entry in gshadow for the group.
nekral-guest
2011-07-28 15:17:28 +00:00
771a3624f5
* src/pwunconv.c: Exit after printing usage when arguments or options are provided. * src/pwunconv.c: Re-indent. * src/pwunconv.c: Open the shadow file read only. * src/grpunconv.c: Exit after printing usage when arguments or options are provided. * src/grpunconv.c: Open the gshadow file read only.
nekral-guest
2011-07-28 14:40:56 +00:00
7180f03376
Add more info on the change of behavior.
nekral-guest
2011-07-23 11:05:59 +00:00
2aefca0f2e
* NEWS, src/login.c: Do not log in utmp / utmpx / wtmp when PAM is enabled. This is already done by pam_lastlog.
nekral-guest
2011-07-23 11:03:50 +00:00
7e8aa5429a
* src/chpasswd.c: Add annotations to indicate that usage() does not return. * src/chpasswd.c: Reindent. * src/chpasswd.c: Remove dead code. No need to set crypt_method to NULL when it is already NULL. sflg is only set if crypt_method is not NULL.
nekral-guest
2011-07-23 08:14:15 +00:00
2be8650d2c
* src/lastlog.c: Add annotations to indicate that usage() does not return.
nekral-guest
2011-07-23 08:10:27 +00:00
495125415b
* src/faillog.c: Add annotations to indicate that usage() does not return. * src/faillog.c: Fix message: this is faillog, not lastlog. * src/faillog.c: Check that there are no extra arguments after parsing the options.
nekral-guest
2011-07-22 23:59:57 +00:00
1def4ef49d
* src/chgpasswd.c: Add annotations to indicate that usage() does not return. * src/chgpasswd.c: Split usage in smaller parts. Those parts are already translated for chpasswd. Usage is now closer to chpasswd's. * src/chgpasswd.c: Remove dead code. No need to set crypt_method to NULL when it is already NULL. sflg is only set if crypt_method is not NULL.
nekral-guest
2011-07-22 23:52:08 +00:00
e8373305b4
* src/grpck.c: Added comments. * src/grpck.c: Avoid implicit conversion of pointer to boolean. * src/grpck.c: Remove dead code. argc cannot be lower than optind. Avoid checking twice in a row for NULL != list[i].
nekral-guest
2011-07-22 22:07:23 +00:00
275ffe2e01
* libmisc/find_new_gid.c, libmisc/find_new_uid.c: Fail in case of invalid configuration. * libmisc/find_new_gid.c, libmisc/find_new_uid.c: Updated comments. * libmisc/find_new_gid.c, libmisc/find_new_uid.c: Be more strict on the loop stop conditions. Stop if we passed the limit, even if the limit itself was never noticed.
nekral-guest
2011-07-22 21:53:01 +00:00
nekral-guest