emo/sysklogd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor, wording and formatting of comment

Browse Source 
Signed-off-by: Joachim Nilsson <troglobit@gmail.com>
This commit is contained in:
Joachim Nilsson 2020-03-22 09:47:01 +01:00
parent 4c9ede6e43
commit 5eec48df9d
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Makefile.am
View File

@ -57,12 +57,15 @@ libsyslog_la_CPPFLAGS = $(AM_CPPFLAGS) -D_XOPEN_SOURCE=600
libsyslog_la_LDFLAGS = $(AM_LDFLAGS) -version-info 0:0:0
libsyslog_la_LIBADD = $(LTLIBOBJS)
# Both libsyslog_la and syslogd/logger requires objects like lib/pidfile.o, for
# libsyslog_la, the objects should be compiled with -fPIC, but for
# syslogd/logger, it doesn't need -fPIC, so there is a race issue when the two
# different lib/pidfile.o are compiled at the same time, which would cause errors like:
# ld: syslogd-syslogd.o: in function `main':
# syslogd.c:417: undefined reference to `__pidfile'
# Both libsyslog and syslogd/logger require objects like lib/pidfile.o.
# For libsyslog_la, the object files should be compiled with -fPIC, but
# for syslogd and logger these object files should not be compled with
# -fPIC. There is a race issue when the two different lib/pidfile.o are
# compiled at the same time, which cause errors like:
#
# Make LIBOBJS depend on LTLIBOBJS to fix the problem.
# ld: syslogd-syslogd.o: in function `main': syslogd.c:417: undefined
# reference to `__pidfile'
#
# Work around the problem by building one .o from lib at a time, this
# can be achieved by making LIBOBJS depend on LTLIBOBJS.
$(LIBOBJS): $(LTLIBOBJS)