Drop posix_fadvise(3) completely before unpacking.
Some systems with small memory might fail to make the preallocation, as seen in the rpi. It doesn't give us too much gain anyway.
This commit is contained in:
parent
1f324a76a2
commit
e525e2c251
18
configure
vendored
18
configure
vendored
@ -344,24 +344,6 @@ else
|
||||
fi
|
||||
rm -f _$func.c _$func
|
||||
|
||||
# Check for posix_fadvise(2)
|
||||
func=posix_fadvise
|
||||
printf "Checking for $func() ... "
|
||||
cat <<EOF >_$func.c
|
||||
#include <fcntl.h>
|
||||
int main(void) {
|
||||
posix_fadvise(0, 0, 0, POSIX_FADV_NORMAL);
|
||||
return 0;
|
||||
}
|
||||
EOF
|
||||
if $XCC _$func.c -o _$func 2>/dev/null; then
|
||||
echo "yes."
|
||||
echo "CPPFLAGS += -DHAVE_POSIX_FADVISE" >>$CONFIG_MK
|
||||
else
|
||||
echo "no."
|
||||
fi
|
||||
rm -f _$func _$func.c
|
||||
|
||||
#
|
||||
# Check for strcasestr().
|
||||
#
|
||||
|
@ -586,7 +586,6 @@ int HIDDEN
|
||||
xbps_unpack_binary_pkg(struct xbps_handle *xhp, prop_dictionary_t pkg_repod)
|
||||
{
|
||||
struct archive *ar = NULL;
|
||||
struct stat pkg_stat;
|
||||
const char *pkgname, *version, *pkgver;
|
||||
char *bpkg;
|
||||
int pkg_fd, rv = 0;
|
||||
@ -634,10 +633,6 @@ xbps_unpack_binary_pkg(struct xbps_handle *xhp, prop_dictionary_t pkg_repod)
|
||||
archive_read_open_fd(ar, pkg_fd, ARCHIVE_READ_BLOCKSIZE);
|
||||
free(bpkg);
|
||||
|
||||
#ifdef HAVE_POSIX_FADVISE
|
||||
fstat(pkg_fd, &pkg_stat);
|
||||
posix_fadvise(pkg_fd, 0, pkg_stat.st_size, POSIX_FADV_SEQUENTIAL);
|
||||
#endif
|
||||
/*
|
||||
* Extract archive files.
|
||||
*/
|
||||
@ -648,9 +643,6 @@ xbps_unpack_binary_pkg(struct xbps_handle *xhp, prop_dictionary_t pkg_repod)
|
||||
pkgver, strerror(rv));
|
||||
goto out;
|
||||
}
|
||||
#ifdef HAVE_POSIX_FADVISE
|
||||
posix_fadvise(pkg_fd, 0, pkg_stat.st_size, POSIX_FADV_DONTNEED);
|
||||
#endif
|
||||
/*
|
||||
* Set package state to unpacked.
|
||||
*/
|
||||
|
Loading…
Reference in New Issue
Block a user