midou/invidious
1
0
Fork 1
mirror of https://github.com/iv-org/invidious.git synced 2024-12-25 17:49:49 +05:30
Code Issues Packages Projects Releases Wiki Activity

Don't double-encode file title

Browse Source
This commit is contained in:
Samantaz Fox 2022-02-24 22:37:54 +01:00
parent 2f335b3d2c
commit 004e371051
No known key found for this signature in database
GPG Key ID: F42821059186176E
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/invidious/routes/video_playback.cr
View File

@ -164,7 +164,9 @@ module Invidious::Routes::VideoPlayback
if title = query_params["title"]?
# https://blog.fastmail.com/2011/06/24/download-non-english-filenames/
env.response.headers["Content-Disposition"] = "attachment; filename=\"#{URI.encode_www_form(title)}\"; filename*=UTF-8''#{URI.encode_www_form(title)}"
filename = URI.encode_www_form(title, space_to_plus: false)
header = "attachment; filename=\"#{filename}\"; filename*=UTF-8''#{filename}"
env.response.headers["Content-Disposition"] = header
end
if !resp.headers.includes_word?("Transfer-Encoding", "chunked")

7
src/invidious/routes/watch.cr
View File

@ -304,12 +304,9 @@ module Invidious::Routes::Watch
end
download_widget = JSON.parse(selection)
extension = download_widget["ext"].as_s
filename = URI.encode_www_form(
"#{video_id}-#{title}.#{extension}",
space_to_plus: false
)
extension = download_widget["ext"].as_s
filename = "#{video_id}-#{title}.#{extension}"
# Pass form parameters as URL parameters for the handlers of both
# /latest_version and /api/v1/captions. This avoids an un-necessary